Skip to content

[CP] Fix file deletion crash in BuildIOSArchiveCommand.runCommand #138752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Nov 21, 2023
Merged

[CP] Fix file deletion crash in BuildIOSArchiveCommand.runCommand #138752

auto-submit merged 2 commits into from
Nov 21, 2023

Conversation

@vashworth
Copy link
Contributor

@vashworth vashworth commented Nov 20, 2023

Original PR: #138734

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@vashworth vashworth changed the base branch from master to flutter-3.16-candidate.0 November 20, 2023 21:42
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: focus Focus traversal, gaining or losing focus labels Nov 20, 2023
@vashworth vashworth mentioned this pull request Nov 20, 2023
Closed
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 20, 2023
christopherfujino
christopherfujino approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 21, 2023
@auto-submit auto-submit bot merged commit 6f753f7 into flutter:flutter-3.16-candidate.0 Nov 21, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 28, 2023
@engine-flutter-autoroll
6f753f71b [CP] Fix file deletion crash in BuildIOSArchiveCommand.runC…
2d8b51a 
…ommand (flutter/flutter#138752)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 28, 2023
@engine-flutter-autoroll
6f753f71b [CP] Fix file deletion crash in BuildIOSArchiveCommand.runC…
50d7ae0 
…ommand (flutter/flutter#138752)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 29, 2023
@engine-flutter-autoroll
6f753f71b [CP] Fix file deletion crash in BuildIOSArchiveCommand.runC…
de56fa9 
…ommand (flutter/flutter#138752)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 1, 2023
@engine-flutter-autoroll
6f753f71b [CP] Fix file deletion crash in BuildIOSArchiveCommand.runC…
602bdf5 
…ommand (flutter/flutter#138752)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 1, 2023
@engine-flutter-autoroll
6f753f71b [CP] Fix file deletion crash in BuildIOSArchiveCommand.runC…
b799c74 
…ommand (flutter/flutter#138752)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 2, 2023
@engine-flutter-autoroll
6f753f71b [CP] Fix file deletion crash in BuildIOSArchiveCommand.runC…
69adc93 
…ommand (flutter/flutter#138752)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
6f753f71b [CP] Fix file deletion crash in BuildIOSArchiveCommand.runC…
f02d31e 
…ommand (flutter/flutter#138752)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
6f753f71b [CP] Fix file deletion crash in BuildIOSArchiveCommand.runC…
c1d8249 
…ommand (flutter/flutter#138752)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
6f753f71b [CP] Fix file deletion crash in BuildIOSArchiveCommand.runC…
af381c3 
…ommand (flutter/flutter#138752)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos engine flutter/engine related. See also e: labels. f: focus Focus traversal, gaining or losing focus framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vashworth @christopherfujino @CaseyHillers