Skip to content

Reverts "Introduce AnimationStyle" #138628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Nov 17, 2023
Merged

Reverts "Introduce AnimationStyle" #138628

auto-submit merged 1 commit into from
Nov 17, 2023

Conversation

@auto-submit
Copy link
Contributor

@auto-submit auto-submit bot commented Nov 17, 2023

Reverts #137945
Initiated by: HansMuller
This change reverts the following previous change:
Original Description:
This PR introduces AnimationStyle, it is used to override default animation curves and durations in several widgets.

fixes Add the ability to customize MaterialApp theme animation duration
fixes Allow customization of showMenu transition animation curves and duration

Here is an example where popup menu curve and transition duration is overriden:

          popUpAnimationStyle: AnimationStyle(
            curve: Easing.emphasizedAccelerate,
            duration: Durations.medium4,
          ),

Set AnimationStyle.noAnimation to disable animation.

    return MaterialApp(
      themeAnimationStyle: AnimationStyle.noAnimation,

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Nov 17, 2023
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs f: material design flutter/packages/flutter/material repository. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Nov 17, 2023
@auto-submit auto-submit bot merged commit 0135a33 into master Nov 17, 2023
@auto-submit auto-submit bot deleted the revert_19e284f88ff96074e23ce52961a41ad52af8c37d branch November 17, 2023 16:59
@HansMuller HansMuller mentioned this pull request Nov 17, 2023
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2023
@engine-flutter-autoroll
0135a33 Reverts "Introduce AnimationStyle" (flutter/flutter#138628)
a900b27
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2023
@engine-flutter-autoroll
0135a33 Reverts "Introduce AnimationStyle" (flutter/flutter#138628)
2f3d149
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 18, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 18, 2023
@engine-flutter-autoroll
0135a33 Reverts "Introduce AnimationStyle" (flutter/flutter#138628)
19ed63c
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 18, 2023
@engine-flutter-autoroll
Roll Flutter from 53a57ad to 6cf9ab0 (31 revisions) (#5426)
2e010d8 
flutter/flutter@53a57ad...6cf9ab0

2023-11-18 [email protected] Roll Flutter Engine from 53c4fde7732b to d7af5fb60b4c (2 revisions) (flutter/flutter#138668)
2023-11-18 [email protected] Update release.yml (flutter/flutter#138561)
2023-11-18 [email protected] Roll Flutter Engine from 384f75061257 to 53c4fde7732b (2 revisions) (flutter/flutter#138660)
2023-11-18 [email protected] Roll Flutter Engine from 5f40c9f49f88 to 384f75061257 (2 revisions) (flutter/flutter#138658)
2023-11-18 [email protected] Roll Flutter Engine from 66f764a16610 to 5f40c9f49f88 (1 revision) (flutter/flutter#138655)
2023-11-18 [email protected] Roll Flutter Engine from 1d2ee544c5e5 to 66f764a16610 (1 revision) (flutter/flutter#138652)
2023-11-18 [email protected] Roll Flutter Engine from c38272b5e036 to 1d2ee544c5e5 (3 revisions) (flutter/flutter#138650)
2023-11-17 [email protected] Roll Flutter Engine from e010f17eeb10 to c38272b5e036 (4 revisions) (flutter/flutter#138647)
2023-11-17 [email protected] Update links and surrounding text for new `main-api` docs (flutter/flutter#138602)
2023-11-17 [email protected] Roll Flutter Engine from 141a01c5c70b to e010f17eeb10 (2 revisions) (flutter/flutter#138643)
2023-11-17 [email protected] Roll Flutter Engine from 90c3ada3682c to 141a01c5c70b (16 revisions) (flutter/flutter#138637)
2023-11-17 [email protected] Roll Flutter Engine from 5064aeff00de to 90c3ada3682c (9 revisions) (flutter/flutter#138599)
2023-11-17 [email protected] Fix NoSplash not being disposed (flutter/flutter#138542)
2023-11-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Introduce `AnimationStyle`" (flutter/flutter#138628)
2023-11-17 [email protected] Enable `flutter screenshot` outside Flutter project directory (flutter/flutter#138160)
2023-11-17 [email protected] Roll Flutter Engine from aae07e989b0a to 5064aeff00de (2 revisions) (flutter/flutter#138585)
2023-11-16 [email protected] Improves output file path logic in Android analyze (flutter/flutter#136981)
2023-11-16 [email protected] Turn off leak tracker in master to make found leaks not blocking. (flutter/flutter#138567)
2023-11-16 [email protected] Roll Flutter Engine from 094a3383a406 to aae07e989b0a (2 revisions) (flutter/flutter#138574)
2023-11-16 [email protected] Enable the silent flag for invalid string exceptions when building a TextSpan (flutter/flutter#138564)
2023-11-16 [email protected] Roll Flutter Engine from 22baa83db63b to 094a3383a406 (13 revisions) (flutter/flutter#138568)
2023-11-16 [email protected] #60704: Pass cert for TLS localhost connection (flutter/flutter#106635)
2023-11-16 [email protected] Bump cupertino_icons to 1.0.6 (flutter/flutter#136962)
2023-11-16 [email protected] Fix sliver persistent header expand animation (flutter/flutter#137913)
2023-11-16 [email protected] Reduce animations further when --no-cli-animations is set. (flutter/flutter#133598)
2023-11-16 [email protected] Roll Flutter Engine from 0c57a50810e8 to 22baa83db63b (4 revisions) (flutter/flutter#138560)
2023-11-16 [email protected] Introduce `AnimationStyle` (flutter/flutter#137945)
2023-11-16 [email protected] Just use string interpolation for ws url for tests (flutter/flutter#138235)
2023-11-16 [email protected] Adding new packages to the first-party package issue template (flutter/flutter#138540)
2023-11-16 [email protected] Roll Packages from 0cd2378 to 07b4b29 (3 revisions) (flutter/flutter#138549)
2023-11-16 [email protected] Roll Flutter Engine from 2e9f0df868b3 to 0c57a50810e8 (1 revision) (flutter/flutter#138546)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
0135a33 Reverts "Introduce AnimationStyle" (flutter/flutter#138628)
d5c5bbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees

@HansMuller HansMuller

Labels

a: animation Animation APIs d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow customization of showMenu transition animation curves and duration Add the ability to customize MaterialApp theme animation duration

2 participants

@fluttergithubbot @HansMuller