Skip to content

AnimationStyle.noAnimation replaces AnimatedTheme with just Theme in MaterialApp.themeAnimationStyle #138619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TahaTesser wants to merge 1 commit into from
Closed

AnimationStyle.noAnimation replaces AnimatedTheme with just Theme in MaterialApp.themeAnimationStyle #138619

TahaTesser wants to merge 1 commit into from

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Nov 17, 2023

fixes AnimationStyle.noAnimation needs to replace AnimatedTheme with just Theme in the MaterialApp

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Nov 17, 2023
@TahaTesser TahaTesser marked this pull request as ready for review November 17, 2023 14:46
@HansMuller HansMuller mentioned this pull request Nov 17, 2023
Merged
8 tasks
@TahaTesser TahaTesser closed this Nov 18, 2023
@TahaTesser TahaTesser deleted the update_MaterialApp branch November 18, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AnimationStyle.noAnimation needs to replace AnimatedTheme with just Theme in the MaterialApp

1 participant

@TahaTesser