support for --strong option#13859
Merged
Merged
Conversation
so that we can run flutter apps in preview-dart-2 and strong mode
- correctly set up strong mode option in the case of AOT builds
aam
reviewed
Jan 3, 2018
| if (kernelContent != null) { | ||
| final String platformKernelDill = artifacts.getArtifactPath(Artifact.platformKernelDill); | ||
| final String platformKernelDill = strongMode ? | ||
| artifacts.getArtifactPath(Artifact.platformKernelStrongDill) : |
Member
There was a problem hiding this comment.
This would require changes in engine's dart_init.cc(line 89) so that correct platform.dill is picked up from the archive.
Member
There was a problem hiding this comment.
Scratch that. Like you explained, the file will be put into archive under _kPlatformKernelKey name.
aam
approved these changes
Jan 3, 2018
Contributor
|
You can do dart2 without strong mode? |
Contributor
Author
|
Strong mode will be an integral part of dart2. This pull request enables us to run flutter apps with strong mode enabled and clean up all the runtime type errors we might potentially hit before we make it the default. |
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
* Plumb a --strong option through to the front end server and the engine so that we can run flutter apps in preview-dart-2 and strong mode * - Address analyzer lint issues *- correctly set up strong mode option in the case of AOT builds
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 15, 2019
flar
pushed a commit
that referenced
this pull request
Nov 15, 2019
* 174e0e9 Roll src/third_party/dart dc35290111..dc808f3fcb (5 commits) (flutter-team-archive/engine#13859) * 33d997c Roll fuchsia/sdk/core/mac-amd64 from 7XOyl... to VMTIz... (flutter-team-archive/engine#13861) * b4899d9 Roll src/third_party/skia d860a78fd60c..e57ca4931952 (44 commits) (flutter-team-archive/engine#13862) * f456423 RendererContextSwitch guard flutter's gl context rework. (flutter-team-archive/engine#13812) * 6bab64e Fix test to account for pixel ratio transformations being framework responsibility. (flutter-team-archive/engine#13850) * 5b10fa3 Guard against orphaned semantic objects from referencing dead accessibility bridge on iOS (flutter-team-archive/engine#13857) * 97df087 [fuchsia] Package flutter_frontend_server snapshot for fuchsia (flutter-team-archive/engine#13865) * 0832dfd [flow][fuchsia] Add more tracing to layers and Fuchsia surface pool (flutter-team-archive/engine#13864) * 141dc785d Roll src/third_party/skia e57ca4931952..c1c4634dcb07 (15 commits) (flutter-team-archive/engine#13866) * 90a6054 Revert "Roll src/third_party/dart dc35290111..dc808f3fcb (5 commits) (#13859)" (flutter-team-archive/engine#13867)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plumb the --strong option through to the front end server and the engine so that we can run
apps with strong mode checks enabled.