Skip to content

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented Nov 16, 2023

The goal of this PR is to monitor memory leaks in flutter master.

Leak tracking is OFF in flutter master, but is ON in this PR.
Bot failures will show memory leaks.

All leak_tracker related failures will be listed in this comment.

Status: old integration removed and new one is not created yet.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Nov 16, 2023
@polina-c
Copy link
Contributor Author

For some reasons disabled Google testing keeps returning. Started discussion with owners to figure this out.

@polina-c polina-c marked this pull request as ready for review November 20, 2023 16:54
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@text-exemption-reviewers" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@polina-c polina-c marked this pull request as draft December 19, 2023 03:20
@polina-c polina-c closed this Jan 11, 2024
@polina-c polina-c deleted the leak-tracking branch August 2, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant