refactored cli tool ipa method name to support --export-options-plist #138555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
github-actions
bot
added
the
tool
Contributor
Thank you for contributing! Per this message, you will need to sign FLutter's CLA before we can review. |
Contributor
Author
|
I have signed the CLA and if I refresh the CLA Link it is green. Let me know if I have to do anything else. Thanks for your time |
andrewkolos
reviewed
Dec 14, 2023
Contributor
|
@vashworth, do you have the time to look at this? I would like someone with Apple ecosystem expertise as a second reviewer here (in hindsight, @jmagman might have been the better choice since they have prior experience with this code; so feel free to reroute if it makes sense). |
jmagman
reviewed
Dec 15, 2023
Member
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
Thank you so much for fixing this! Just a few nits but overall LGTM.
packages/flutter_tools/test/commands.shard/hermetic/build_ipa_test.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/test/commands.shard/hermetic/build_ipa_test.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Jenn Magder <[email protected]>
…test.dart Co-authored-by: Jenn Magder <[email protected]>
…test.dart Co-authored-by: Jenn Magder <[email protected]>
jmagman
approved these changes
Dec 16, 2023
Member
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
This LGTM! It will require a second reviewer (@vashworth or @christopherfujino maybe?)
andrewkolos
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 18, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 18, 2023
flutter/flutter@2407f69...cdc83e5 2023-12-18 [email protected] Roll Flutter Engine from b3de65a6d3ea to 7f1a81d5545a (1 revision) (flutter/flutter#140309) 2023-12-18 [email protected] refactored cli tool ipa method name to support --export-options-plist (flutter/flutter#138555) 2023-12-18 [email protected] Restore and fix flavors_test_macos (flutter/flutter#139841) 2023-12-18 [email protected] Roll Flutter Engine from 626c93260f79 to b3de65a6d3ea (1 revision) (flutter/flutter#140308) 2023-12-17 [email protected] Roll Flutter Engine from f9c7aa27f13a to 626c93260f79 (1 revision) (flutter/flutter#140291) 2023-12-17 [email protected] Roll Flutter Engine from 726a137e3f99 to f9c7aa27f13a (1 revision) (flutter/flutter#140289) 2023-12-16 [email protected] Roll Flutter Engine from c5fc179cf0b3 to 726a137e3f99 (1 revision) (flutter/flutter#140280) 2023-12-16 [email protected] Roll Flutter Engine from a8d8fbbcef22 to c5fc179cf0b3 (1 revision) (flutter/flutter#140277) 2023-12-16 [email protected] Center Floating Snackbar with custom width when direction is RTL (flutter/flutter#140215) 2023-12-16 [email protected] Roll Flutter Engine from 6752398c2f54 to a8d8fbbcef22 (1 revision) (flutter/flutter#140274) 2023-12-16 [email protected] Use `SemanticsUpdateBuilder` again, remove all references to temporary `SemanticsUpdateBuilderNew` (flutter/flutter#139942) 2023-12-16 [email protected] Roll Flutter Engine from 7d300e5b9587 to 6752398c2f54 (1 revision) (flutter/flutter#140270) 2023-12-16 [email protected] Roll Flutter Engine from 832238a3b493 to 7d300e5b9587 (1 revision) (flutter/flutter#140268) 2023-12-16 [email protected] Roll Flutter Engine from 34d427aa009c to 832238a3b493 (1 revision) (flutter/flutter#140265) 2023-12-16 [email protected] Roll Flutter Engine from 74e4965a2845 to 34d427aa009c (1 revision) (flutter/flutter#140263) 2023-12-16 [email protected] Roll Flutter Engine from ca329dd84207 to 74e4965a2845 (4 revisions) (flutter/flutter#140262) 2023-12-16 [email protected] [github actions] minor PR to test latest github actions (flutter/flutter#140252) 2023-12-16 [email protected] Roll Flutter Engine from 6e3a04874be5 to ca329dd84207 (3 revisions) (flutter/flutter#140255) 2023-12-15 [email protected] Remove usage of testWidgetsWithLeakTracking. (flutter/flutter#140239) 2023-12-15 [email protected] Roll Flutter Engine from a8d861b53db1 to 6e3a04874be5 (1 revision) (flutter/flutter#140244) 2023-12-15 [email protected] Roll Flutter Engine from c48b08ac4682 to a8d861b53db1 (1 revision) (flutter/flutter#140240) 2023-12-15 [email protected] Use new `enabledFeature` param for `Analytics` (flutter/flutter#139934) 2023-12-15 [email protected] Roll Flutter Engine from db98451b063c to c48b08ac4682 (2 revisions) (flutter/flutter#140236) 2023-12-15 [email protected] Reorganize dependencies on leak_tracker. (flutter/flutter#140233) 2023-12-15 [email protected] [macOS,iOS] CocoaPods recommended version: 1.13.0 (flutter/flutter#135447) 2023-12-15 [email protected] Roll Flutter Engine from b36374085c4b to db98451b063c (1 revision) (flutter/flutter#140230) 2023-12-15 [email protected] Roll Flutter Engine from e89b7ed8812b to b36374085c4b (1 revision) (flutter/flutter#140228) 2023-12-15 [email protected] Roll Flutter Engine from 986a6fe198dc to e89b7ed8812b (1 revision) (flutter/flutter#140224) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way the IPA method is read in the run command for
build ipacommand. If export options plist argument is provided it takes method name from plist, otherwise it uses the method name from export method argument.List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
fixes #122179
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.