Skip to content

Conversation

@mossmana
Copy link
Contributor

Addresses #1670

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Nov 10, 2023
@mossmana
Copy link
Contributor Author

@gspencergoog I'm just now familiarizing myself with this area of the code, so before I continue along this path and add the associated tests, etc. Do you think this is a valid approach? Or would you recommend I start somewhere else?

@mossmana mossmana added the platform-android Android applications specifically label Nov 10, 2023
@gspencergoog
Copy link
Contributor

That should be a good start. You might even be able to add it to the default shortcuts, since the select key would only be mapped on a system that produces it. Then if, say, we started mapping that key on iOS, then it would just work. We currently seem to map it already on Windows, so it would be nice if it worked there.

@mossmana mossmana linked an issue Nov 16, 2023 that may be closed by this pull request
@goderbauer
Copy link
Member

(triage): @mossmana said she would get back to this.

@mossmana mossmana force-pushed the issue1670 branch 2 times, most recently from 24063a5 to fcf6da9 Compare December 8, 2023 21:05
@mossmana mossmana marked this pull request as ready for review December 11, 2023 17:29
@mossmana mossmana added platform-windows Building on or for Windows specifically platform-linux Building on or for Linux specifically labels Dec 20, 2023
@mossmana
Copy link
Contributor Author

mossmana commented Dec 20, 2023

In my first pass I made a change that would have only taken effect for Android. However, now the defaults for Fuchsia, Windows and Linux have been updated as well.

@gspencergoog I'm not sure if adding to the defaults would eventually work for iOS. iOS and MacOs seem to have a different set of defaults. https://github.com/flutter/flutter/pull/138240/files#diff-f629b31e1aaf7209877c14f88326284538c1279b6bcf4859e3d4daebc889bef4R1276

@mossmana
Copy link
Contributor Author

mossmana commented Jan 2, 2024

I'm not sure what is going on, but every time I try to merge in the latest changes from master, there's a completely different unrelated to my changes test failure. I think I'm going to try opening up a fresh PR starting from the most recent base branch.

@mossmana mossmana closed this Jan 2, 2024
auto-submit bot pushed a commit that referenced this pull request Jan 3, 2024
#1670

Note: This PR replaces the the original PR (#138240) that got into a state where a rebase was not possible and made it difficult to determine what was causing unrelated test failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels. platform-android Android applications specifically platform-linux Building on or for Linux specifically platform-windows Building on or for Windows specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants