[CP] prevent tool crash when IntelliJValidatorOnMac encounters an installation with a missing CFBundleIdentifier
#138176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
| required UserMessages userMessages, | ||
| required PlistParser plistParser, | ||
| required String? homeDirPath, | ||
|
|
Contributor
There was a problem hiding this comment.
what's with this space?
Contributor
Author
There was a problem hiding this comment.
Great question 👻 . Fixed, but it already snuck its way into master
CaseyHillers
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 28, 2023
…nters an installation with a missing `CFBundleIdentifier` (flutter/flutter#138176)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 28, 2023
…nters an installation with a missing `CFBundleIdentifier` (flutter/flutter#138176)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 29, 2023
…nters an installation with a missing `CFBundleIdentifier` (flutter/flutter#138176)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 1, 2023
…nters an installation with a missing `CFBundleIdentifier` (flutter/flutter#138176)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 1, 2023
…nters an installation with a missing `CFBundleIdentifier` (flutter/flutter#138176)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 2, 2023
…nters an installation with a missing `CFBundleIdentifier` (flutter/flutter#138176)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 6, 2023
…nters an installation with a missing `CFBundleIdentifier` (flutter/flutter#138176)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 7, 2023
…nters an installation with a missing `CFBundleIdentifier` (flutter/flutter#138176)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 7, 2023
…nters an installation with a missing `CFBundleIdentifier` (flutter/flutter#138176)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks #138095 onto beta
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.