-
Notifications
You must be signed in to change notification settings - Fork 29.7k
prevent tool crash when IntelliJValidatorOnMac encounters an installation with a missing CFBundleIdentifier
#138095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 1 commit into
flutter:master
from
andrewkolos:catch-intellij-plist-parsing-error
Nov 9, 2023
Merged
prevent tool crash when IntelliJValidatorOnMac encounters an installation with a missing CFBundleIdentifier
#138095
auto-submit
merged 1 commit into
flutter:master
from
andrewkolos:catch-intellij-plist-parsing-error
Nov 9, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherfujino
approved these changes
Nov 8, 2023
Contributor
christopherfujino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
|
auto label is removed for flutter/flutter/138095, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
71341e6 to
57c2d25
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 9, 2023
…n installation with a missing `CFBundleIdentifier` (flutter/flutter#138095)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 9, 2023
…n installation with a missing `CFBundleIdentifier` (flutter/flutter#138095)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 9, 2023
flutter/flutter@4b4a1fe...f662150 2023-11-09 [email protected] Roll Packages from 94c7623 to b69f54e (1 revision) (flutter/flutter#138149) 2023-11-09 [email protected] prevent tool crash when `IntelliJValidatorOnMac` encounters an installation with a missing `CFBundleIdentifier` (flutter/flutter#138095) 2023-11-09 [email protected] Roll Flutter Engine from 233bd6263c62 to 8b490a9f1650 (1 revision) (flutter/flutter#138118) 2023-11-09 [email protected] Roll pub packages (flutter/flutter#138114) 2023-11-09 [email protected] Roll Flutter Engine from b3af5d64d3e6 to 233bd6263c62 (8 revisions) (flutter/flutter#138116) 2023-11-08 [email protected] Use specific version of mac_toolchain (flutter/flutter#138115) 2023-11-08 [email protected] [flutter_tools] disable flutter build AAR for plugins (flutter/flutter#137878) 2023-11-08 [email protected] Roll Flutter Engine from 21f055f7d8d0 to b3af5d64d3e6 (1 revision) (flutter/flutter#138113) 2023-11-08 [email protected] Roll Flutter Engine from 5306213d9d19 to 21f055f7d8d0 (3 revisions) (flutter/flutter#138111) 2023-11-08 [email protected] Remove physicalGeometry (flutter/flutter#138103) 2023-11-08 [email protected] [Android] Fix `FlutterTestRunner.java` deprecations (flutter/flutter#138093) 2023-11-08 [email protected] Remove fuchsia mac version (flutter/flutter#138101) 2023-11-08 [email protected] Roll Flutter Engine from 6dbcf8f13132 to 5306213d9d19 (4 revisions) (flutter/flutter#138108) 2023-11-08 [email protected] Marks Mac_android hot_mode_dev_cycle__benchmark to be flaky (flutter/flutter#138073) 2023-11-08 [email protected] Document additional cases (flutter/flutter#137957) 2023-11-08 [email protected] Roll Flutter Engine from b0310da3254d to 6dbcf8f13132 (2 revisions) (flutter/flutter#138100) 2023-11-08 [email protected] Add support for color and color blendmode in FadeInImage (flutter/flutter#137681) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
…n installation with a missing `CFBundleIdentifier` (flutter/flutter#138095)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
tool
Affects the "flutter" command-line tool. See also t: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #138029 (see my comment there for more info)
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.