Skip to content

Conversation

@andrewkolos
Copy link
Contributor

Fixes #138029 (see my comment there for more info)

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@andrewkolos andrewkolos added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 8, 2023
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkolos andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 8, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 8, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Nov 8, 2023

auto label is removed for flutter/flutter/138095, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@andrewkolos andrewkolos force-pushed the catch-intellij-plist-parsing-error branch from 71341e6 to 57c2d25 Compare November 9, 2023 00:14
@andrewkolos andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 9, 2023
@auto-submit auto-submit bot merged commit 94550c6 into flutter:master Nov 9, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 9, 2023
…n installation with a missing `CFBundleIdentifier` (flutter/flutter#138095)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 9, 2023
…n installation with a missing `CFBundleIdentifier` (flutter/flutter#138095)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 9, 2023
flutter/flutter@4b4a1fe...f662150

2023-11-09 [email protected] Roll Packages from 94c7623 to b69f54e (1 revision) (flutter/flutter#138149)
2023-11-09 [email protected] prevent tool crash when `IntelliJValidatorOnMac` encounters an installation with a missing `CFBundleIdentifier` (flutter/flutter#138095)
2023-11-09 [email protected] Roll Flutter Engine from 233bd6263c62 to 8b490a9f1650 (1 revision) (flutter/flutter#138118)
2023-11-09 [email protected] Roll pub packages (flutter/flutter#138114)
2023-11-09 [email protected] Roll Flutter Engine from b3af5d64d3e6 to 233bd6263c62 (8 revisions) (flutter/flutter#138116)
2023-11-08 [email protected] Use specific version of mac_toolchain (flutter/flutter#138115)
2023-11-08 [email protected] [flutter_tools] disable flutter build AAR for plugins (flutter/flutter#137878)
2023-11-08 [email protected] Roll Flutter Engine from 21f055f7d8d0 to b3af5d64d3e6 (1 revision) (flutter/flutter#138113)
2023-11-08 [email protected] Roll Flutter Engine from 5306213d9d19 to 21f055f7d8d0 (3 revisions) (flutter/flutter#138111)
2023-11-08 [email protected] Remove physicalGeometry (flutter/flutter#138103)
2023-11-08 [email protected] [Android] Fix `FlutterTestRunner.java` deprecations (flutter/flutter#138093)
2023-11-08 [email protected] Remove fuchsia mac version (flutter/flutter#138101)
2023-11-08 [email protected] Roll Flutter Engine from 6dbcf8f13132 to 5306213d9d19 (4 revisions) (flutter/flutter#138108)
2023-11-08 [email protected] Marks Mac_android hot_mode_dev_cycle__benchmark to be flaky (flutter/flutter#138073)
2023-11-08 [email protected] Document additional cases  (flutter/flutter#137957)
2023-11-08 [email protected] Roll Flutter Engine from b0310da3254d to 6dbcf8f13132 (2 revisions) (flutter/flutter#138100)
2023-11-08 [email protected] Add support for color and color blendmode in FadeInImage (flutter/flutter#137681)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot pushed a commit that referenced this pull request Nov 20, 2023
…nstallation with a missing `CFBundleIdentifier` (#138176)

Cherry-picks #138095 onto beta
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
…n installation with a missing `CFBundleIdentifier` (flutter/flutter#138095)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[flutter_tools] _TypeError in IntelliJValidatorOnMac.installed

2 participants