Skip to content

Fix intrinsic width of input decorator #138074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Nov 28, 2023
Merged

Fix intrinsic width of input decorator #138074

auto-submit merged 1 commit into from
Nov 28, 2023

Conversation

@neko-andrew
Copy link
Contributor

@neko-andrew neko-andrew commented Nov 8, 2023 •
edited
Loading

Fix min intrinsic width of input decorator by removing left or right padding when prefixIcon or suffixIcon are used.

Fixes #137937.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 8, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Nov 8, 2023
@neko-andrew
Copy link
Contributor Author

neko-andrew commented Nov 8, 2023 •
edited
Loading

I'm unsure how to run a flutter app with my local changes so I can't get a screen shot of the fix. Can someone help me figure out how to do this?

@neko-andrew
Copy link
Contributor Author

neko-andrew commented Nov 9, 2023

I would also like help on how I would write a test for this change.

@LongCatIsLooong
Copy link
Contributor

LongCatIsLooong commented Nov 14, 2023

I would also like help on how I would write a test for this change.

I think you could check the location of the left-most component and the right-most component and see if the horizontal distance they cover is the same as the width getMinIntrinsicWidth reported.

LongCatIsLooong
LongCatIsLooong reviewed Nov 14, 2023
View reviewed changes
@neko-andrew
Copy link
Contributor Author

neko-andrew commented Nov 16, 2023

I added a test which showed that I also had to fix the max intrinsic width.

@neko-andrew neko-andrew force-pushed the fix-input-decorator-instrinsic-width branch from 8054de2 to 2fe03a1 Compare November 16, 2023 07:43
Renzo-Olivares
Renzo-Olivares reviewed Nov 16, 2023
View reviewed changes
packages/flutter/lib/src/material/input_decorator.dart Outdated
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares Nov 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: consider making 0 -> 0.0 per style guidelines. Here and in other places in this PR.

Renzo-Olivares
Renzo-Olivares approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @neko-andrew, thanks for the contribution. This change LGTM just had a small nit. I also see similar logic to calculate the input width in _layout.

@LongCatIsLooong LongCatIsLooong added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Nov 16, 2023
@neko-andrew
Copy link
Contributor Author

neko-andrew commented Nov 17, 2023

Seems like "Google testing" failed. The details don't really provide any information. What does this mean?

@neko-andrew neko-andrew force-pushed the fix-input-decorator-instrinsic-width branch from 2fe03a1 to 33952a3 Compare November 17, 2023 06:07
@neko-andrew neko-andrew force-pushed the fix-input-decorator-instrinsic-width branch from 33952a3 to 79a80e1 Compare November 17, 2023 06:10
@neko-andrew
Copy link
Contributor Author

neko-andrew commented Nov 28, 2023

Can I get help with the failing "Google Testing"?

@LongCatIsLooong
Copy link
Contributor

LongCatIsLooong commented Nov 28, 2023 •
edited
Loading

The internal golden changes LGTM. Sorry for the delay!

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 28, 2023
@auto-submit auto-submit bot merged commit ad62645 into flutter:master Nov 28, 2023
@neko-andrew neko-andrew deleted the fix-input-decorator-instrinsic-width branch November 28, 2023 06:30
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 28, 2023
@engine-flutter-autoroll
ad62645 Fix intrinsic width of input decorator (flutter/flutter#138074)
707275f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 28, 2023
@engine-flutter-autoroll
ad62645 Fix intrinsic width of input decorator (flutter/flutter#138074)
eadff03
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 28, 2023
@engine-flutter-autoroll
ad62645 Fix intrinsic width of input decorator (flutter/flutter#138074)
633f87a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 28, 2023
@engine-flutter-autoroll
ad62645 Fix intrinsic width of input decorator (flutter/flutter#138074)
1072dc2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 28, 2023
@engine-flutter-autoroll
ad62645 Fix intrinsic width of input decorator (flutter/flutter#138074)
ff0416a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 28, 2023
@engine-flutter-autoroll
ad62645 Fix intrinsic width of input decorator (flutter/flutter#138074)
1565ca6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 28, 2023
@engine-flutter-autoroll
ad62645 Fix intrinsic width of input decorator (flutter/flutter#138074)
4f1d7f3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 29, 2023
@engine-flutter-autoroll
ad62645 Fix intrinsic width of input decorator (flutter/flutter#138074)
d6e0f9b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 29, 2023
@engine-flutter-autoroll
ad62645 Fix intrinsic width of input decorator (flutter/flutter#138074)
2387b8c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 29, 2023
@engine-flutter-autoroll
ad62645 Fix intrinsic width of input decorator (flutter/flutter#138074)
a2a5b37
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 29, 2023
@engine-flutter-autoroll
ad62645 Fix intrinsic width of input decorator (flutter/flutter#138074)
f4d69aa
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 29, 2023
@engine-flutter-autoroll
ad62645 Fix intrinsic width of input decorator (flutter/flutter#138074)
8ceded2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 29, 2023
@engine-flutter-autoroll
ad62645 Fix intrinsic width of input decorator (flutter/flutter#138074)
0c7a8f4
@HansMuller HansMuller mentioned this pull request Dec 1, 2023
Closed
@neko-andrew
Copy link
Contributor Author

neko-andrew commented Dec 22, 2023

What is the process of getting these changes into a hot fix?

caseycrogers pushed a commit to caseycrogers/flutter that referenced this pull request Dec 29, 2023
@neko-andrew @caseycrogers
Fix intrinsic width of input decorator (flutter#138074)
51eb55a 
Fix min intrinsic width of input decorator by removing left or right padding when `prefixIcon` or `suffixIcon` are used.

Fixes flutter#137937.
@neko-andrew neko-andrew mentioned this pull request Jan 12, 2024
Closed
neko-andrew added a commit to neko-andrew/flutter that referenced this pull request Jan 15, 2024
@neko-andrew
Fix intrinsic width of input decorator (flutter#138074)
c49fefc 
Fix min intrinsic width of input decorator by removing left or right padding when `prefixIcon` or `suffixIcon` are used.

Fixes flutter#137937.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
ad62645 Fix intrinsic width of input decorator (flutter/flutter#138074)
778d01a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TextField's intrinsic width isn't properly calculated when PrefixIcon or SuffixIcon are used

3 participants

@neko-andrew @LongCatIsLooong @Renzo-Olivares