Skip to content

Migrating the PubResultEvent to package:unified_analytics #138012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eliasyishak wants to merge 2 commits into from
Closed

Migrating the PubResultEvent to package:unified_analytics #138012

eliasyishak wants to merge 2 commits into from

Conversation

@eliasyishak
Copy link
Contributor

@eliasyishak eliasyishak commented Nov 7, 2023

Related to tracker issue:

There is only one other file that references PubResultEvent, as shown below

image

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels. labels Nov 7, 2023
@eliasyishak eliasyishak mentioned this pull request Nov 7, 2023
Closed
32 tasks
@eliasyishak
Copy link
Contributor Author

eliasyishak commented Nov 7, 2023

Closing this since the pub tool will be sending its own analytics in the future, will reopen if the migration is necessary for other reports though

@eliasyishak eliasyishak closed this Nov 7, 2023
@eliasyishak eliasyishak deleted the ga4-migrate-pub-result-event branch November 7, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@eliasyishak