Skip to content

[Android] Support Android 34 (take 2) #137967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 19 commits into from
Nov 9, 2023
Merged

[Android] Support Android 34 (take 2) #137967

auto-submit merged 19 commits into from
Nov 9, 2023

Conversation

@camsim99
Copy link
Contributor

@camsim99 camsim99 commented Nov 6, 2023 •
edited
Loading

Re-lands #137191.

The fix for the issue causing that PR to be reverted was tested in this PR but ultimately landed separately in #138093.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Nov 6, 2023
@camsim99
Copy link
Contributor Author

camsim99 commented Nov 7, 2023 •
edited
Loading

The reason that the first PR seemed to have caused integration test failures is due to these warnings:

[2023-11-07 10:28:15.561422] [STDOUT] run:stderr: /opt/s/w/ir/cache/gradle/caches/transforms-3/2febba88601fdfcd50f9b2931eeb9213/transformed/rules-1.2.0-api.jar(/androidx/test/rule/ActivityTestRule.class): warning: [classfile] MethodParameters attribute introduced in version 52.0 class files is ignored in version 51.0 class files
[2023-11-07 10:28:15.563314] [STDOUT] run:stderr: error: warnings found and -Werror specified
[2023-11-07 10:28:15.601735] [STDOUT] run:stderr: /opt/s/w/ir/x/w/recipe_cleanup/tmpfr_3x8zx/flutter sdk/packages/integration_test/android/src/main/java/dev/flutter/plugins/integration_test/FlutterTestRunner.java:23: warning: [rawtypes] found raw type: Class
[2023-11-07 10:28:15.601983] [STDOUT] run:stderr:   final Class testClass;
[2023-11-07 10:28:15.602130] [STDOUT] run:stderr:         ^
[2023-11-07 10:28:15.602277] [STDOUT] run:stderr:   missing type arguments for generic class Class<T>
[2023-11-07 10:28:15.602581] [STDOUT] run:stderr:   where T is a type-variable:
[2023-11-07 10:28:15.602765] [STDOUT] run:stderr:     T extends Object declared in class Class
[2023-11-07 10:28:15.604360] [STDOUT] run:stderr: /opt/s/w/ir/x/w/recipe_cleanup/tmpfr_3x8zx/flutter sdk/packages/integration_test/android/src/main/java/dev/flutter/plugins/integration_test/FlutterTestRunner.java:35: warning: [deprecation] newInstance() in Class has been deprecated
[2023-11-07 10:28:15.604502] [STDOUT] run:stderr:           Object instance = testClass.newInstance();
[2023-11-07 10:28:15.604594] [STDOUT] run:stderr:                                      ^
[2023-11-07 10:28:15.604674] [STDOUT] run:stderr:   where T is a type-variable:
[2023-11-07 10:28:15.604747] [STDOUT] run:stderr:     T extends Object declared in class Class
[2023-11-07 10:28:15.604911] [STDOUT] run:stderr: 1 error
[2023-11-07 10:28:15.605002] [STDOUT] run:stderr: 3 warnings

@camsim99 camsim99 mentioned this pull request Nov 8, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request Nov 8, 2023
@camsim99
[Android] Fix FlutterTestRunner.java deprecations (#138093)
3215c49 
Fixes deprecations causing unexpected standard error integration test failures: #138061, #138063, #138067, #138077.

Note that the issue this fixes was the same that was the cause for reverting #137191. I made this same fix in #137967 and changed `Mac_android run_release_test` to run in presubmit to see a successful run for proof that this fix works.
@camsim99
Copy link
Contributor Author

camsim99 commented Nov 9, 2023

The reason that the first PR seemed to have caused integration test failures is due to these warnings:

[2023-11-07 10:28:15.561422] [STDOUT] run:stderr: /opt/s/w/ir/cache/gradle/caches/transforms-3/2febba88601fdfcd50f9b2931eeb9213/transformed/rules-1.2.0-api.jar(/androidx/test/rule/ActivityTestRule.class): warning: [classfile] MethodParameters attribute introduced in version 52.0 class files is ignored in version 51.0 class files
[2023-11-07 10:28:15.563314] [STDOUT] run:stderr: error: warnings found and -Werror specified
[2023-11-07 10:28:15.601735] [STDOUT] run:stderr: /opt/s/w/ir/x/w/recipe_cleanup/tmpfr_3x8zx/flutter sdk/packages/integration_test/android/src/main/java/dev/flutter/plugins/integration_test/FlutterTestRunner.java:23: warning: [rawtypes] found raw type: Class
[2023-11-07 10:28:15.601983] [STDOUT] run:stderr:   final Class testClass;
[2023-11-07 10:28:15.602130] [STDOUT] run:stderr:         ^
[2023-11-07 10:28:15.602277] [STDOUT] run:stderr:   missing type arguments for generic class Class<T>
[2023-11-07 10:28:15.602581] [STDOUT] run:stderr:   where T is a type-variable:
[2023-11-07 10:28:15.602765] [STDOUT] run:stderr:     T extends Object declared in class Class
[2023-11-07 10:28:15.604360] [STDOUT] run:stderr: /opt/s/w/ir/x/w/recipe_cleanup/tmpfr_3x8zx/flutter sdk/packages/integration_test/android/src/main/java/dev/flutter/plugins/integration_test/FlutterTestRunner.java:35: warning: [deprecation] newInstance() in Class has been deprecated
[2023-11-07 10:28:15.604502] [STDOUT] run:stderr:           Object instance = testClass.newInstance();
[2023-11-07 10:28:15.604594] [STDOUT] run:stderr:                                      ^
[2023-11-07 10:28:15.604674] [STDOUT] run:stderr:   where T is a type-variable:
[2023-11-07 10:28:15.604747] [STDOUT] run:stderr:     T extends Object declared in class Class
[2023-11-07 10:28:15.604911] [STDOUT] run:stderr: 1 error
[2023-11-07 10:28:15.605002] [STDOUT] run:stderr: 3 warnings

The FlutterTestRunner.java errors were fixed in #138093, allowing the integration tests failing after the first PR landed to now pass.

@camsim99 camsim99 marked this pull request as ready for review November 9, 2023 20:39
@camsim99 camsim99 requested a review from a team November 9, 2023 20:40
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023
@engine-flutter-autoroll
c66bb0a [Android] Support Android 34 (take 2) (flutter/flutter#137967)
ef5b30f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023
@engine-flutter-autoroll
c66bb0a [Android] Support Android 34 (take 2) (flutter/flutter#137967)
ea7e0d0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023
@engine-flutter-autoroll
c66bb0a [Android] Support Android 34 (take 2) (flutter/flutter#137967)
973d8d7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023
@engine-flutter-autoroll
c66bb0a [Android] Support Android 34 (take 2) (flutter/flutter#137967)
ae7ade8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 11, 2023
@engine-flutter-autoroll
c66bb0a [Android] Support Android 34 (take 2) (flutter/flutter#137967)
2ae119a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 11, 2023
@engine-flutter-autoroll
c66bb0a [Android] Support Android 34 (take 2) (flutter/flutter#137967)
7e40038
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2023
@engine-flutter-autoroll
c66bb0a [Android] Support Android 34 (take 2) (flutter/flutter#137967)
dee3076
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2023
@engine-flutter-autoroll
c66bb0a [Android] Support Android 34 (take 2) (flutter/flutter#137967)
ea4d7e2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2023
@engine-flutter-autoroll
c66bb0a [Android] Support Android 34 (take 2) (flutter/flutter#137967)
5aeda07
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2023
@engine-flutter-autoroll
c66bb0a [Android] Support Android 34 (take 2) (flutter/flutter#137967)
f993e19
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2023
@engine-flutter-autoroll
c66bb0a [Android] Support Android 34 (take 2) (flutter/flutter#137967)
610531f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023
@engine-flutter-autoroll
c66bb0a [Android] Support Android 34 (take 2) (flutter/flutter#137967)
835df29
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023
@engine-flutter-autoroll
c66bb0a [Android] Support Android 34 (take 2) (flutter/flutter#137967)
9028dfb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023
@engine-flutter-autoroll
c66bb0a [Android] Support Android 34 (take 2) (flutter/flutter#137967)
229ede5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023
@engine-flutter-autoroll
c66bb0a [Android] Support Android 34 (take 2) (flutter/flutter#137967)
79b48b7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023
@engine-flutter-autoroll
c66bb0a [Android] Support Android 34 (take 2) (flutter/flutter#137967)
8aee2fe
@stuartmorgan-g stuartmorgan-g mentioned this pull request Jan 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
c66bb0a [Android] Support Android 34 (take 2) (flutter/flutter#137967)
343a72b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmackall gmackall gmackall approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camsim99 @gmackall @mossmana