Document additional cases #137957
Merged
Document additional cases #137957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
framework
goderbauer
reviewed
Nov 6, 2023
Comment on lines
1197
to
1199
| /// To release resources more eagerly, establish a [platform channel](https://flutter.dev/platform-channels/) | ||
| /// and use it call [runApp] with a widget such as [SizedBox.shrink] when | ||
| /// the framework should dispose of the active widget tree. |
Member
There was a problem hiding this comment.
Something is missing in this sentence, maybe a "to" between "it" and "call"?
Comment on lines
1308
to
1309
| /// This method is _not_ invoked at times where a developer might otherwise | ||
| /// expect it. |
Member
There was a problem hiding this comment.
This seems like an overly broad statement. Can we specify what these cases are where one might expect this to be called, but it isn't?
Member
There was a problem hiding this comment.
Maybe this just needs to verbally link to the next two sections to indicate that they talk about two common cases of this?
Contributor
Author
There was a problem hiding this comment.
Added another clause here, wdyt?
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 9, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 9, 2023
flutter/flutter@4b4a1fe...f662150 2023-11-09 [email protected] Roll Packages from 94c7623 to b69f54e (1 revision) (flutter/flutter#138149) 2023-11-09 [email protected] prevent tool crash when `IntelliJValidatorOnMac` encounters an installation with a missing `CFBundleIdentifier` (flutter/flutter#138095) 2023-11-09 [email protected] Roll Flutter Engine from 233bd6263c62 to 8b490a9f1650 (1 revision) (flutter/flutter#138118) 2023-11-09 [email protected] Roll pub packages (flutter/flutter#138114) 2023-11-09 [email protected] Roll Flutter Engine from b3af5d64d3e6 to 233bd6263c62 (8 revisions) (flutter/flutter#138116) 2023-11-08 [email protected] Use specific version of mac_toolchain (flutter/flutter#138115) 2023-11-08 [email protected] [flutter_tools] disable flutter build AAR for plugins (flutter/flutter#137878) 2023-11-08 [email protected] Roll Flutter Engine from 21f055f7d8d0 to b3af5d64d3e6 (1 revision) (flutter/flutter#138113) 2023-11-08 [email protected] Roll Flutter Engine from 5306213d9d19 to 21f055f7d8d0 (3 revisions) (flutter/flutter#138111) 2023-11-08 [email protected] Remove physicalGeometry (flutter/flutter#138103) 2023-11-08 [email protected] [Android] Fix `FlutterTestRunner.java` deprecations (flutter/flutter#138093) 2023-11-08 [email protected] Remove fuchsia mac version (flutter/flutter#138101) 2023-11-08 [email protected] Roll Flutter Engine from 6dbcf8f13132 to 5306213d9d19 (4 revisions) (flutter/flutter#138108) 2023-11-08 [email protected] Marks Mac_android hot_mode_dev_cycle__benchmark to be flaky (flutter/flutter#138073) 2023-11-08 [email protected] Document additional cases (flutter/flutter#137957) 2023-11-08 [email protected] Roll Flutter Engine from b0310da3254d to 6dbcf8f13132 (2 revisions) (flutter/flutter#138100) 2023-11-08 [email protected] Add support for color and color blendmode in FadeInImage (flutter/flutter#137681) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137924
Fixes #136885
The framework defaults to keeping the widget tree alive and ready to render regardless of application lifecycle events such as showing or hiding a view controller.
Add-to-app developers may be surprised by this, and tend to file bugs asking why
disposeisn't called when the view is dismissed (or why memory usage is higher than expected after dismissing Flutter UI).Adds documentation to explain the limitation and what to do instead.
/cc @zanderso @chinmaygarde @jonahwilliams @jason-simmons since we were discussing this in triage.