Fix sliver persistent header expand animation #137913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: flutter#137901 Added animation status check at showOnScreen method to prevent broken animation of expanding SliverAppBar when focusing EditableText
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
github-actions
bot
added
framework
Issue: flutter#137901 Added animation status check at showOnScreen method to prevent broken animation of expanding SliverAppBar when focusing EditableText
Added animation status check at showOnScreen method to prevent broken animation of expanding SliverAppBar when focusing EditableText
added 3 commits
November 8, 2023 11:08
Piinks
added
a: text input
Piinks
reviewed
Nov 10, 2023
Piinks
reviewed
Nov 10, 2023
Piinks
approved these changes
Nov 10, 2023
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
Hi @feduke-nukem, welcome. Thanks for contributing! This change LGTM.
Author
|
@Piinks Do you think it might be a good idea to consider changing the target branch? |
Contributor
|
What do you mean? |
Author
Is it supposed to be merged into the "master" ? Maybe I missed some part of the docs about choosing the correct target branch at new pull request. |
Contributor
Yup! That is correct. We're just waiting on a second review here for this to land. I've asked for someone to take a look :) |
Author
|
Hi @Piinks. Are there any updates? |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 18, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 18, 2023
flutter/flutter@53a57ad...6cf9ab0 2023-11-18 [email protected] Roll Flutter Engine from 53c4fde7732b to d7af5fb60b4c (2 revisions) (flutter/flutter#138668) 2023-11-18 [email protected] Update release.yml (flutter/flutter#138561) 2023-11-18 [email protected] Roll Flutter Engine from 384f75061257 to 53c4fde7732b (2 revisions) (flutter/flutter#138660) 2023-11-18 [email protected] Roll Flutter Engine from 5f40c9f49f88 to 384f75061257 (2 revisions) (flutter/flutter#138658) 2023-11-18 [email protected] Roll Flutter Engine from 66f764a16610 to 5f40c9f49f88 (1 revision) (flutter/flutter#138655) 2023-11-18 [email protected] Roll Flutter Engine from 1d2ee544c5e5 to 66f764a16610 (1 revision) (flutter/flutter#138652) 2023-11-18 [email protected] Roll Flutter Engine from c38272b5e036 to 1d2ee544c5e5 (3 revisions) (flutter/flutter#138650) 2023-11-17 [email protected] Roll Flutter Engine from e010f17eeb10 to c38272b5e036 (4 revisions) (flutter/flutter#138647) 2023-11-17 [email protected] Update links and surrounding text for new `main-api` docs (flutter/flutter#138602) 2023-11-17 [email protected] Roll Flutter Engine from 141a01c5c70b to e010f17eeb10 (2 revisions) (flutter/flutter#138643) 2023-11-17 [email protected] Roll Flutter Engine from 90c3ada3682c to 141a01c5c70b (16 revisions) (flutter/flutter#138637) 2023-11-17 [email protected] Roll Flutter Engine from 5064aeff00de to 90c3ada3682c (9 revisions) (flutter/flutter#138599) 2023-11-17 [email protected] Fix NoSplash not being disposed (flutter/flutter#138542) 2023-11-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Introduce `AnimationStyle`" (flutter/flutter#138628) 2023-11-17 [email protected] Enable `flutter screenshot` outside Flutter project directory (flutter/flutter#138160) 2023-11-17 [email protected] Roll Flutter Engine from aae07e989b0a to 5064aeff00de (2 revisions) (flutter/flutter#138585) 2023-11-16 [email protected] Improves output file path logic in Android analyze (flutter/flutter#136981) 2023-11-16 [email protected] Turn off leak tracker in master to make found leaks not blocking. (flutter/flutter#138567) 2023-11-16 [email protected] Roll Flutter Engine from 094a3383a406 to aae07e989b0a (2 revisions) (flutter/flutter#138574) 2023-11-16 [email protected] Enable the silent flag for invalid string exceptions when building a TextSpan (flutter/flutter#138564) 2023-11-16 [email protected] Roll Flutter Engine from 22baa83db63b to 094a3383a406 (13 revisions) (flutter/flutter#138568) 2023-11-16 [email protected] #60704: Pass cert for TLS localhost connection (flutter/flutter#106635) 2023-11-16 [email protected] Bump cupertino_icons to 1.0.6 (flutter/flutter#136962) 2023-11-16 [email protected] Fix sliver persistent header expand animation (flutter/flutter#137913) 2023-11-16 [email protected] Reduce animations further when --no-cli-animations is set. (flutter/flutter#133598) 2023-11-16 [email protected] Roll Flutter Engine from 0c57a50810e8 to 22baa83db63b (4 revisions) (flutter/flutter#138560) 2023-11-16 [email protected] Introduce `AnimationStyle` (flutter/flutter#137945) 2023-11-16 [email protected] Just use string interpolation for ws url for tests (flutter/flutter#138235) 2023-11-16 [email protected] Adding new packages to the first-party package issue template (flutter/flutter#138540) 2023-11-16 [email protected] Roll Packages from 0cd2378 to 07b4b29 (3 revisions) (flutter/flutter#138549) 2023-11-16 [email protected] Roll Flutter Engine from 2e9f0df868b3 to 0c57a50810e8 (1 revision) (flutter/flutter#138546) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added animation status check at showOnScreen method to prevent broken animation of expanding SliverAppBar when focusing EditableText
close #137901
Pre-launch Checklist
///).