[benchmarks] disable partial repaint for multiple backdrop blur iOS macrobenchmarks. #137902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This will allow flutter/engine#47688 to improve a benchmark |
Member
|
Presumably, partial repaint has performance benefits in the rest of the benchmarks such that we'd still notice a drop in performance on introducing a bug even with it disabled on this one benchmark. If so, this sgtm. |
zanderso
approved these changes
Nov 6, 2023
Contributor
Author
🤔 Let me double check that |
Contributor
Author
|
I've updated this PR so that partial repaint is only disabled for the backdrop blur case I want to measure. |
jonahwilliams
changed the title
zanderso
reviewed
Nov 6, 2023
| } | ||
| Future<void> Function()? plistReset; | ||
| if (disablePartialRepaint) { | ||
| _disablePartialRepaint(testDirectory); |
Member
There was a problem hiding this comment.
If this throws, _resetManifest() won't be run.
Member
There was a problem hiding this comment.
Maybe it won't matter in this case because you can't have disablePartialRepaint and forceOpenGLES both true at the same time, but it'd be nice to find a better pattern to follow here for when the third thing comes along...
Contributor
Author
There was a problem hiding this comment.
I think the reset commands should always be safe to run. Let me re-arrange this a bit.
Contributor
Author
There was a problem hiding this comment.
okay re-arrangement concluded. We should always reset if we throw now.
added 2 commits
November 6, 2023 10:30
…williams/flutter into disable_partial_repaint_microbench
zanderso
approved these changes
Nov 6, 2023
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 7, 2023
…ur iOS macrobenchmarks. (flutter/flutter#137902)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 7, 2023
…ur iOS macrobenchmarks. (flutter/flutter#137902)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 7, 2023
…ur iOS macrobenchmarks. (flutter/flutter#137902)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 7, 2023
flutter/flutter@f5a9835...5a6a322 2023-11-07 [email protected] Roll Packages from 49eac1f to be18d28 (3 revisions) (flutter/flutter#137999) 2023-11-07 [email protected] Roll Flutter Engine from b1f2581f05e3 to b91400976b4a (2 revisions) (flutter/flutter#138000) 2023-11-07 [email protected] Roll Flutter Engine from 633065f75b1c to b1f2581f05e3 (1 revision) (flutter/flutter#137997) 2023-11-07 [email protected] Roll Flutter Engine from 99149d59cb3d to 633065f75b1c (1 revision) (flutter/flutter#137996) 2023-11-07 [email protected] Roll Flutter Engine from 7f4d56a7f4f7 to 99149d59cb3d (1 revision) (flutter/flutter#137987) 2023-11-07 [email protected] Roll Flutter Engine from f9f822359f2b to 7f4d56a7f4f7 (1 revision) (flutter/flutter#137983) 2023-11-07 [email protected] Roll Flutter Engine from b1a5d772792f to f9f822359f2b (1 revision) (flutter/flutter#137980) 2023-11-07 [email protected] Roll Flutter Engine from 461d815b48a0 to b1a5d772792f (13 revisions) (flutter/flutter#137979) 2023-11-07 [email protected] Roll Flutter Engine from bdfa8aa8f81f to 461d815b48a0 (1 revision) (flutter/flutter#137944) 2023-11-06 [email protected] SemanticsHandle should dispatch creation and disposal events. (flutter/flutter#137960) 2023-11-06 [email protected] ScrollActivity should dispatch creation and disposal events. (flutter/flutter#137961) 2023-11-06 [email protected] Cover text_selection tests with leak tracking. (flutter/flutter#137009) 2023-11-06 [email protected] Roll pub packages (flutter/flutter#137862) 2023-11-06 [email protected] Migration for `HotEvent` for Flutter hot runner (flutter/flutter#137717) 2023-11-06 [email protected] [benchmarks] disable partial repaint for multiple backdrop blur iOS macrobenchmarks. (flutter/flutter#137902) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
…ur iOS macrobenchmarks. (flutter/flutter#137902)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial repaint is too effective, and we'd like to be able to measure performance without carefully structuring the benchmarks. For example, right now partial repaint is culling any blurs in the multibackdrop case, which we should be using to track #132735