Hide EditableString implementation details #1379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Previously, EditableString had many public members because it needed to implement the KeyboardClient interface. However, that's confusing because these methods cannot be called directly. Now EditableString holds a private implementation of the KeyboardClient, which hides the implementation details. Fixes flutter#208 Fixes flutter#209
abarth
force-pushed
the
protect_editable_string
branch
from
156be6c to
f0ea0ea
Compare
abarth
added a commit
that referenced
this pull request
Jan 26, 2016
Hide EditableString implementation details
Contributor
There was a problem hiding this comment.
I don't know if this is intended but depending on TextRange and text this can lead to RangeError (for instance with TextRange.empty, with TextRange(start: 3, end: 5) and text="aa")
Contributor
Author
There was a problem hiding this comment.
That is an error condition. I guess we could return null or truncate, but it seems reasonable to have the same error handling as substring.
TahaTesser
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Aug 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, EditableString had many public members because it needed to
implement the KeyboardClient interface. However, that's confusing
because these methods cannot be called directly.
Now EditableString holds a private implementation of the KeyboardClient,
which hides the implementation details.
Fixes #208
Fixes #209