[flutter_tools] disable flutter build AAR for plugins #137878

christopherfujino · 2023-11-03T23:47:29Z

Per discord discussion, building an AAR out of a plugin project has not worked for years, so let's just disable the functionality. Context: #137564

gmackall

Looks like we have a test that tests that you can do this, so that test will probably need to be disabled

00:57 +611: test/commands.shard/permeable/build_aar_test.dart: flag parsing parses flags                                                                                                               
Error: AARs can only be built from modules.

christopherfujino · 2023-11-07T19:11:38Z

Looks like we have a test that tests that you can do this, so that test will probably need to be disabled

00:57 +611: test/commands.shard/permeable/build_aar_test.dart: flag parsing parses flags                                                                                                               
Error: AARs can only be built from modules.

Thanks, let me investigate further what the test is actually testing :)

christopherfujino · 2023-11-07T19:51:00Z

Looks like we have a test that tests that you can do this, so that test will probably need to be disabled
00:57 +611: test/commands.shard/permeable/build_aar_test.dart: flag parsing parses flags                                                                                                               
Error: AARs can only be built from modules.
Thanks, let me investigate further what the test is actually testing :)

Ahh, it was just verifying that if we build aar from a plugin, we send the right analytics event.

gmackall

Looks like these two tests are also failing

flutter/packages/flutter_tools/test/commands.shard/permeable/build_aar_test.dart

Line 118 in 034479a

testUsingContext('defaults', () async {

flutter/packages/flutter_tools/test/commands.shard/permeable/build_aar_test.dart

Line 148 in 034479a

testUsingContext('parses flags', () async {

Presumably because they aren't passing in --template=module to createProject - though its odd that they were passing, because at a first glance they also don't seem to be requesting a plugin template either?

christopherfujino · 2023-11-07T22:05:27Z

Looks like these two tests are also failing

flutter/packages/flutter_tools/test/commands.shard/permeable/build_aar_test.dart

Line 118 in 034479a

testUsingContext('defaults', () async {

flutter/packages/flutter_tools/test/commands.shard/permeable/build_aar_test.dart

Line 148 in 034479a

testUsingContext('parses flags', () async {

Presumably because they aren't passing in --template=module to createProject - though its odd that they were passing, because at a first glance they also don't seem to be requesting a plugin template either?

might be defaulting to an app template?

gmackall · 2023-11-07T22:42:32Z

Looks like these two tests are also failing

flutter/packages/flutter_tools/test/commands.shard/permeable/build_aar_test.dart

Line 118 in 034479a

testUsingContext('defaults', () async {

flutter/packages/flutter_tools/test/commands.shard/permeable/build_aar_test.dart

Line 148 in 034479a

testUsingContext('parses flags', () async {

Presumably because they aren't passing in --template=module to createProject - though its odd that they were passing, because at a first glance they also don't seem to be requesting a plugin template either?

might be defaulting to an app template?

But if they were defaulting to an app template, wouldn't they be failing before this change anyways?

christopherfujino · 2023-11-07T22:54:03Z

Looks like these two tests are also failing

flutter/packages/flutter_tools/test/commands.shard/permeable/build_aar_test.dart

Line 118 in 034479a

testUsingContext('defaults', () async {

flutter/packages/flutter_tools/test/commands.shard/permeable/build_aar_test.dart

Line 148 in 034479a

testUsingContext('parses flags', () async {

Presumably because they aren't passing in --template=module to createProject - though its odd that they were passing, because at a first glance they also don't seem to be requesting a plugin template either?

might be defaulting to an app template?

But if they were defaulting to an app template, wouldn't they be failing before this change anyways?

the tool exit that is failing is a new one I added

christopherfujino · 2023-11-07T23:49:39Z

@gmackall i think this is (finally!) ready for review :)

christopherfujino · 2023-11-08T00:12:15Z

Looks like these two tests are also failing

flutter/packages/flutter_tools/test/commands.shard/permeable/build_aar_test.dart

Line 118 in 034479a

testUsingContext('defaults', () async {

flutter/packages/flutter_tools/test/commands.shard/permeable/build_aar_test.dart

Line 148 in 034479a

testUsingContext('parses flags', () async {

Presumably because they aren't passing in --template=module to createProject - though its odd that they were passing, because at a first glance they also don't seem to be requesting a plugin template either?

might be defaulting to an app template?

But if they were defaulting to an app template, wouldn't they be failing before this change anyways?

these tests are using a FakeAndroidBuilder, so they're not really running a gradle build.

gmackall

LGTM

gmackall · 2023-11-08T22:12:33Z

Clicking update branch to hope it gets google testing unstuck

…r/flutter#137878)

flutter/flutter@4b4a1fe...f662150 2023-11-09 [email protected] Roll Packages from 94c7623 to b69f54e (1 revision) (flutter/flutter#138149) 2023-11-09 [email protected] prevent tool crash when `IntelliJValidatorOnMac` encounters an installation with a missing `CFBundleIdentifier` (flutter/flutter#138095) 2023-11-09 [email protected] Roll Flutter Engine from 233bd6263c62 to 8b490a9f1650 (1 revision) (flutter/flutter#138118) 2023-11-09 [email protected] Roll pub packages (flutter/flutter#138114) 2023-11-09 [email protected] Roll Flutter Engine from b3af5d64d3e6 to 233bd6263c62 (8 revisions) (flutter/flutter#138116) 2023-11-08 [email protected] Use specific version of mac_toolchain (flutter/flutter#138115) 2023-11-08 [email protected] [flutter_tools] disable flutter build AAR for plugins (flutter/flutter#137878) 2023-11-08 [email protected] Roll Flutter Engine from 21f055f7d8d0 to b3af5d64d3e6 (1 revision) (flutter/flutter#138113) 2023-11-08 [email protected] Roll Flutter Engine from 5306213d9d19 to 21f055f7d8d0 (3 revisions) (flutter/flutter#138111) 2023-11-08 [email protected] Remove physicalGeometry (flutter/flutter#138103) 2023-11-08 [email protected] [Android] Fix `FlutterTestRunner.java` deprecations (flutter/flutter#138093) 2023-11-08 [email protected] Remove fuchsia mac version (flutter/flutter#138101) 2023-11-08 [email protected] Roll Flutter Engine from 6dbcf8f13132 to 5306213d9d19 (4 revisions) (flutter/flutter#138108) 2023-11-08 [email protected] Marks Mac_android hot_mode_dev_cycle__benchmark to be flaky (flutter/flutter#138073) 2023-11-08 [email protected] Document additional cases (flutter/flutter#137957) 2023-11-08 [email protected] Roll Flutter Engine from b0310da3254d to 6dbcf8f13132 (2 revisions) (flutter/flutter#138100) 2023-11-08 [email protected] Add support for color and color blendmode in FadeInImage (flutter/flutter#137681) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Per discord discussion, building an AAR out of a plugin project has not worked for years, so let's just disable the functionality. Context: flutter#137564

…r#137878)" This reverts commit d2bd444.

…r/flutter#137878)

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 3, 2023

christopherfujino added 2 commits November 6, 2023 15:48

wip

bda9049

fix test

918a62b

christopherfujino force-pushed the disable-flutter-build-aar-plugins branch from 1f2f769 to 918a62b Compare November 7, 2023 00:27

update another tool exit message

221c604

christopherfujino requested a review from reidbaker November 7, 2023 00:32

christopherfujino marked this pull request as ready for review November 7, 2023 00:32

gmackall reviewed Nov 7, 2023

View reviewed changes

delete stale test

034479a

gmackall reviewed Nov 7, 2023

View reviewed changes

fix two more tests

387a9be

christopherfujino mentioned this pull request Nov 7, 2023

Windows tool_integration_tests_1_6 flakes on android_plugin_example_app_build_test #98085

Closed

1 task

gmackall approved these changes Nov 8, 2023

View reviewed changes

christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 8, 2023

reidbaker approved these changes Nov 8, 2023

View reviewed changes

Merge branch 'master' into disable-flutter-build-aar-plugins

44c1686

auto-submit bot merged commit a408c6d into flutter:master Nov 8, 2023

engine-flutter-autoroll mentioned this pull request Nov 9, 2023

Roll Flutter from 4b4a1feb46d1 to 94550c625701 (16 revisions) flutter/packages#5360

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 9, 2023

a408c6d [flutter_tools] disable flutter build AAR for plugins (flutte…

b4a6246

…r/flutter#137878)

engine-flutter-autoroll mentioned this pull request Nov 9, 2023

Roll Flutter from 4b4a1feb46d1 to f66215027e14 (17 revisions) flutter/packages#5361

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 9, 2023

a408c6d [flutter_tools] disable flutter build AAR for plugins (flutte…

b451d7e

…r/flutter#137878)

camsim99 mentioned this pull request Nov 9, 2023

flutter build aar fails with type plugin #137564

Closed

2 tasks

christopherfujino deleted the disable-flutter-build-aar-plugins branch November 9, 2023 20:57

eliasyishak added a commit to eliasyishak/flutter that referenced this pull request Jan 5, 2024

Revert "[flutter_tools] disable flutter build AAR for plugins (flutte…

d00992e

…r#137878)" This reverts commit d2bd444.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024

a408c6d [flutter_tools] disable flutter build AAR for plugins (flutte…

5cfd1cb

…r/flutter#137878)

danagbemava-nc mentioned this pull request Aug 27, 2024

Error message "AARs can only be built from modules." on flutter build aar #154101

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[flutter_tools] disable flutter build AAR for plugins #137878

[flutter_tools] disable flutter build AAR for plugins #137878

Uh oh!

christopherfujino commented Nov 3, 2023 •

edited

Loading

Uh oh!

gmackall left a comment

Uh oh!

christopherfujino commented Nov 7, 2023

Uh oh!

christopherfujino commented Nov 7, 2023

Uh oh!

gmackall left a comment

Uh oh!

christopherfujino commented Nov 7, 2023

Uh oh!

gmackall commented Nov 7, 2023

Uh oh!

christopherfujino commented Nov 7, 2023

Uh oh!

christopherfujino commented Nov 7, 2023

Uh oh!

christopherfujino commented Nov 8, 2023

Uh oh!

gmackall left a comment

Uh oh!

gmackall commented Nov 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[flutter_tools] disable flutter build AAR for plugins #137878

[flutter_tools] disable flutter build AAR for plugins #137878

Uh oh!

Conversation

christopherfujino commented Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gmackall left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino commented Nov 7, 2023

Uh oh!

christopherfujino commented Nov 7, 2023

Uh oh!

gmackall left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino commented Nov 7, 2023

Uh oh!

gmackall commented Nov 7, 2023

Uh oh!

christopherfujino commented Nov 7, 2023

Uh oh!

christopherfujino commented Nov 7, 2023

Uh oh!

christopherfujino commented Nov 8, 2023

Uh oh!

gmackall left a comment

Choose a reason for hiding this comment

Uh oh!

gmackall commented Nov 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

christopherfujino commented Nov 3, 2023 •

edited

Loading