Skip to content

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented Nov 3, 2023

notGCed leaks are not enabled for the entire library yet, because the leaks are flaky.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Nov 3, 2023
@github-actions github-actions bot added the f: scrolling Viewports, list views, slivers, etc. label Nov 3, 2023
@polina-c
Copy link
Contributor Author

  Expected: leak free
    Actual: <Instance of 'Leaks'>
     Which: contains leaks:
            # The text is generated by leak_tracker.
            # For leak troubleshooting tips open:
            # https://github.com/dart-lang/leak_tracker/blob/main/doc/TROUBLESHOOT.md
            notGCed:
              total: 2
              objects:
                RestorationBucket:
                  test: RenderViewportBase.showOnScreen reports the correct targetRect
                  identityHashCode: 598445918
                  context:
                    path: >
                      References that retain the object from garbage collection.
                      package:flutter/src/widgets/binding.dart/_instance
                      package:flutter_test/src/binding.dart/AutomatedTestWidgetsFlutterBinding:_defaultBinaryMessenger@301240726
                      package:flutter_test/src/test_default_binary_messenger.dart/TestDefaultBinaryMessenger:_inboundHandlers@285043826
                      dart.collection/_Map:[InstanceRef id: objects/13, kind: String, identityHashCode: 0, classRef: [ClassRef id: classes/93, name: _OneByteString, library: [LibraryRef id: libraries/@0150898, name: dart.core, uri: dart:core]]]
                      dart.core/_Closure (in setMethodCallHandler):_context@0150898
                      @Context:1
                      dart.core/_Closure (in _methodHandler):_context@0150898
                      @Context:0
                      package:flutter_test/src/restoration.dart/TestRestorationManager:_rootBucket@314347053
                      package:flutter/src/services/restoration.dart/RestorationBucket
                TestRestorationManager:
                  test: RenderViewportBase.showOnScreen reports the correct targetRect
                  identityHashCode: 59186402
                  context:
                    path: >
                      References that retain the object from garbage collection.
                      package:flutter/src/widgets/binding.dart/_instance
                      package:flutter_test/src/binding.dart/AutomatedTestWidgetsFlutterBinding:_defaultBinaryMessenger@301240726
                      package:flutter_test/src/test_default_binary_messenger.dart/TestDefaultBinaryMessenger:_inboundHandlers@285043826
                      dart.collection/_Map:[InstanceRef id: objects/27, kind: String, identityHashCode: 0, classRef: [ClassRef id: classes/93, name: _OneByteString, library: [LibraryRef id: libraries/@0150898, name: dart.core, uri: dart:core]]]
                      dart.core/_Closure (in setMethodCallHandler):_context@0150898
                      @Context:1
                      dart.core/_Closure (in _methodHandler):_context@0150898
                      @Context:0
                      package:flutter_test/src/restoration.dart/TestRestorationManager

@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Nov 14, 2023
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems labels Nov 15, 2023
@polina-c polina-c changed the title notgced Fix some notGCed leaks and mark others. Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant