Skip to content

Bumping version tag of provisioning profile cipd package. (#137710) #137782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Nov 7, 2023
Merged

Bumping version tag of provisioning profile cipd package. (#137710) #137782

auto-submit merged 2 commits into from
Nov 7, 2023

Conversation

@yusuf-goog
Copy link
Contributor

@yusuf-goog yusuf-goog commented Nov 2, 2023 •
edited
Loading

Bug:#137166

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@yusuf-goog
Bumping version tag of provisioning profile cipd package. (flutter#13…
9e396bb 
…7710)

Bug:flutter#137166

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 2, 2023

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@yusuf-goog yusuf-goog mentioned this pull request Nov 2, 2023
Closed
@CaseyHillers
Copy link
Contributor

CaseyHillers commented Nov 2, 2023

@yusuf-goog please attach a CP request (https://github.com/flutter/flutter/issues/new?assignees=&labels=cp%3A+review&projects=&template=7_cherry_pick.yml&title=%5BCP%5D+%3Ctitle%3E)

godofredoc
godofredoc reviewed Nov 2, 2023
View reviewed changes
.ci.yaml
dependencies: >-
[
{"dependency": "apple_signing", "version": "version:2022_to_2023"}
{"dependency": "apple_signing", "version": "version:to_2024"}
Copy link
Contributor

@godofredoc godofredoc Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this tag correct?

Copy link
Contributor Author

@yusuf-goog yusuf-goog Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, thats whats checked in currently

@yusuf-goog
Copy link
Contributor Author

yusuf-goog commented Nov 2, 2023

@yusuf-goog please attach a CP request (https://github.com/flutter/flutter/issues/new?assignees=&labels=cp%3A+review&projects=&template=7_cherry_pick.yml&title=%5BCP%5D+%3Ctitle%3E)

#137783

@XilaiZhang XilaiZhang added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 2, 2023
@zanderso
Copy link
Member

zanderso commented Nov 3, 2023

Looks like Mac tool_integration_tests_4_4 failed, but the result isn't being communicated from LUCI.

@XilaiZhang XilaiZhang added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Nov 7, 2023
@XilaiZhang
Copy link
Contributor

XilaiZhang commented Nov 7, 2023

Can someone attach an approval to this pull request for it to be merged? Thank you! maybe @CaseyHillers?

XilaiZhang
XilaiZhang approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@XilaiZhang XilaiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will stamp a LGTM here to unblock the release

@XilaiZhang XilaiZhang added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Nov 7, 2023
@auto-submit auto-submit bot merged commit 092a710 into flutter:flutter-3.16-candidate.0 Nov 7, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
092a710c6 Bumping version tag of provisioning profile cipd package. (…
a0a347d 
…#137710) (flutter/flutter#137782)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

@itsjustkevin itsjustkevin Awaiting requested review from itsjustkevin

2 more reviewers

@godofredoc godofredoc godofredoc left review comments

@XilaiZhang XilaiZhang XilaiZhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yusuf-goog @CaseyHillers @zanderso @XilaiZhang @godofredoc