-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Migration for HotEvent for Flutter hot runner
#137717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration for HotEvent for Flutter hot runner
#137717
Conversation
Co-authored-by: Christopher Fujino <[email protected]>
christopherfujino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
auto label is removed for flutter/flutter/137717, due to - The status or check suite Mac plugin_test has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
auto label is removed for flutter/flutter/137717, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
auto label is removed for flutter/flutter/137717, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter/flutter@f5a9835...5a6a322 2023-11-07 [email protected] Roll Packages from 49eac1f to be18d28 (3 revisions) (flutter/flutter#137999) 2023-11-07 [email protected] Roll Flutter Engine from b1f2581f05e3 to b91400976b4a (2 revisions) (flutter/flutter#138000) 2023-11-07 [email protected] Roll Flutter Engine from 633065f75b1c to b1f2581f05e3 (1 revision) (flutter/flutter#137997) 2023-11-07 [email protected] Roll Flutter Engine from 99149d59cb3d to 633065f75b1c (1 revision) (flutter/flutter#137996) 2023-11-07 [email protected] Roll Flutter Engine from 7f4d56a7f4f7 to 99149d59cb3d (1 revision) (flutter/flutter#137987) 2023-11-07 [email protected] Roll Flutter Engine from f9f822359f2b to 7f4d56a7f4f7 (1 revision) (flutter/flutter#137983) 2023-11-07 [email protected] Roll Flutter Engine from b1a5d772792f to f9f822359f2b (1 revision) (flutter/flutter#137980) 2023-11-07 [email protected] Roll Flutter Engine from 461d815b48a0 to b1a5d772792f (13 revisions) (flutter/flutter#137979) 2023-11-07 [email protected] Roll Flutter Engine from bdfa8aa8f81f to 461d815b48a0 (1 revision) (flutter/flutter#137944) 2023-11-06 [email protected] SemanticsHandle should dispatch creation and disposal events. (flutter/flutter#137960) 2023-11-06 [email protected] ScrollActivity should dispatch creation and disposal events. (flutter/flutter#137961) 2023-11-06 [email protected] Cover text_selection tests with leak tracking. (flutter/flutter#137009) 2023-11-06 [email protected] Roll pub packages (flutter/flutter#137862) 2023-11-06 [email protected] Migration for `HotEvent` for Flutter hot runner (flutter/flutter#137717) 2023-11-06 [email protected] [benchmarks] disable partial repaint for multiple backdrop blur iOS macrobenchmarks. (flutter/flutter#137902) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Related to tracker issue:
package:unified_analyticsimplementation in flutter tool #128251For this migration, the
HotEventwas being referenced in 2 additional files outside oflib/src/reporting/events.dart, shown below in the screenshotPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.