Change cast in json parsing #137708

iinozemtsev · 2023-11-01T16:36:29Z

jsonDecode decodes lists as List<Object?>, so the cast to List<Object> fails at runtime in sound null safety mode.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2023-11-01T16:36:32Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

chingjun

LGTM, thanks for fixing this!

auto-submit · 2023-11-02T15:13:39Z

auto label is removed for flutter/flutter/137708, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

christopherfujino

LGTM. this will need a unit test in this file: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/general.shard/proxied_devices/file_transfer_test.dart

iinozemtsev · 2023-11-03T09:02:51Z

LGTM. this will need a unit test

Done, please take a look. Made sure that the test fails without the change:

00:00 +14 -1: BlockHashes json conversion works normally [E]

  type 'List<dynamic>' is not a subtype of type 'List<Object>' in type cast

  package:flutter_tools/src/proxied_devices/file_transfer.dart 54:25  BlockHashes.fromJson
  test/general.shard/proxied_devices/file_transfer_test.dart 209:26   main.<fn>.<fn>
  test/src/common.dart 183:18                                         test.<fn>
  package:test_api/src/backend/declarer.dart 215:19                   Declarer.test.<fn>.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/declarer.dart 213:7                    Declarer.test.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/invoker.dart 258:9                     Invoker._waitForOutstandingCallbacks.<fn>


00:00 +14 -1: Some tests failed.

christopherfujino

Nice, thanks for this fix!

auto-submit · 2023-11-03T17:38:46Z

auto label is removed for flutter/flutter/137708, due to - The status or check suite Windows tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

jsonDecode decodes lists as `List<Object?>`, so the cast to `List<Object>` fails at runtime in sound null safety mode.

iinozemtsev · 2023-11-06T13:27:44Z

Could you please re-add autosubmit label? The checks are passing now

Roll Flutter from 29b2516 to f5a9835 (101 revisions) flutter/flutter@29b2516...f5a9835 2023-11-06 [email protected] Check sample links for malformed links (flutter/flutter#137807) 2023-11-06 [email protected] Change cast in json parsing (flutter/flutter#137708) 2023-11-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Update BottomNavigationBar tests for M3" (flutter/flutter#137948) 2023-11-06 [email protected] Roll Packages from cccf5d2 to 49eac1f (2 revisions) (flutter/flutter#137943) 2023-11-06 [email protected] Update BottomNavigationBar tests for M3 (flutter/flutter#136624) 2023-11-06 [email protected] Roll Flutter Engine from 4f6ed31bd8bd to bdfa8aa8f81f (1 revision) (flutter/flutter#137941) 2023-11-06 [email protected] Roll Flutter Engine from b9b3269b0b2c to 4f6ed31bd8bd (2 revisions) (flutter/flutter#137935) 2023-11-06 [email protected] Provide a helpful error message when `ColorScheme.brightness` doesn't match `ThemeData.brightness` (flutter/flutter#137611) 2023-11-06 [email protected] Roll Flutter Engine from 555ffa17b55c to b9b3269b0b2c (1 revision) (flutter/flutter#137933) 2023-11-06 [email protected] Fix tool exit message shown when user provides a non-list to "assets" for a deferred component (flutter/flutter#137837) 2023-11-06 [email protected] Roll Flutter Engine from 0d8c7ceacc01 to 555ffa17b55c (1 revision) (flutter/flutter#137921) 2023-11-06 [email protected] Roll Flutter Engine from 11d66db97d3f to 0d8c7ceacc01 (1 revision) (flutter/flutter#137920) 2023-11-05 [email protected] Roll Flutter Engine from a7592e42464c to 11d66db97d3f (1 revision) (flutter/flutter#137914) 2023-11-05 [email protected] Roll Flutter Engine from 1c6bd97e2288 to a7592e42464c (1 revision) (flutter/flutter#137912) 2023-11-05 [email protected] Roll Flutter Engine from daf18fe46b72 to 1c6bd97e2288 (1 revision) (flutter/flutter#137908) 2023-11-04 [email protected] Roll Flutter Engine from a45e679828e6 to daf18fe46b72 (1 revision) (flutter/flutter#137904) 2023-11-04 [email protected] Roll Flutter Engine from fb2a9c20141e to a45e679828e6 (1 revision) (flutter/flutter#137903) 2023-11-04 [email protected] Roll Flutter Engine from 576833873c15 to fb2a9c20141e (1 revision) (flutter/flutter#137900) 2023-11-04 [email protected] Roll Flutter Engine from 25f5e285f874 to 576833873c15 (1 revision) (flutter/flutter#137898) 2023-11-04 [email protected] Roll Flutter Engine from 7282a5d94ab6 to 25f5e285f874 (2 revisions) (flutter/flutter#137892) 2023-11-04 [email protected] Roll Flutter Engine from b66a87626300 to 7282a5d94ab6 (2 revisions) (flutter/flutter#137887) 2023-11-04 [email protected] HeroController should dispatch creation and disposal events. (flutter/flutter#137835) 2023-11-04 [email protected] Roll Flutter Engine from ec20731de6ff to b66a87626300 (1 revision) (flutter/flutter#137877) 2023-11-03 [email protected] InheritedElement.removeDependent() (flutter/flutter#129210) 2023-11-03 [email protected] Remove unused generic type from BottomSheet (flutter/flutter#137791) 2023-11-03 [email protected] Roll Flutter Engine from 035740c1f90e to ec20731de6ff (2 revisions) (flutter/flutter#137872) 2023-11-03 [email protected] Pin dart-lang/native dependencies (flutter/flutter#137601) 2023-11-03 [email protected] Send caret rect to embedder on selection update (flutter/flutter#137863) 2023-11-03 [email protected] Roll Flutter Engine from 677040f10f65 to 035740c1f90e (4 revisions) (flutter/flutter#137871) 2023-11-03 [email protected] Tooltip docs: Recommend setting preferBelow to false in theme (flutter/flutter#135879) 2023-11-03 [email protected] Roll Flutter Engine from f363a6e5e093 to 677040f10f65 (2 revisions) (flutter/flutter#137861) 2023-11-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Android] Support Android 34" (flutter/flutter#137865) 2023-11-03 [email protected] InkFeature should dispatch creation and disposal events. (flutter/flutter#137793) 2023-11-03 [email protected] AppLifecycleListener should dispatch creation and disposal events. (flutter/flutter#137840) 2023-11-03 [email protected] Roll Flutter Engine from d5ccb5b1b706 to f363a6e5e093 (2 revisions) (flutter/flutter#137858) 2023-11-03 [email protected] Roll Flutter Engine from 72262a238090 to d5ccb5b1b706 (3 revisions) (flutter/flutter#137857) 2023-11-03 [email protected] Updated the nested navigation NavigationBar example (flutter/flutter#137788) 2023-11-03 [email protected] Roll Flutter Engine from 0415a4f5e2a2 to 72262a238090 (2 revisions) (flutter/flutter#137853) 2023-11-03 [email protected] Roll Flutter Engine from 8531c5935356 to 0415a4f5e2a2 (1 revision) (flutter/flutter#137847) 2023-11-03 [email protected] Roll flutter gallery version forward. (flutter/flutter#137846) 2023-11-03 [email protected] Roll Flutter Engine from 43653c5a3ec8 to 8531c5935356 (1 revision) (flutter/flutter#137845) 2023-11-03 [email protected] Roll Packages from 33c2b4e to cccf5d2 (6 revisions) (flutter/flutter#137841) 2023-11-03 [email protected] [web] dispatch corresponding keyup events in text editing integrations (flutter/flutter#136874) 2023-11-03 [email protected] [leak-tracking] Add more leak tracking in test/painting #3 (flutter/flutter#136170) 2023-11-03 [email protected] Upgrade leak_tracker and remove some deps in allow list. (flutter/flutter#137806) 2023-11-03 [email protected] Roll Flutter Engine from fc7c3f70c076 to 43653c5a3ec8 (1 revision) (flutter/flutter#137827) ...

Roll Flutter from 29b25165cab8 to f5a983535131 (101 revisions) flutter/flutter@29b2516...f5a9835 2023-11-06 [email protected] Check sample links for malformed links (flutter/flutter#137807) 2023-11-06 [email protected] Change cast in json parsing (flutter/flutter#137708) 2023-11-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Update BottomNavigationBar tests for M3" (flutter/flutter#137948) 2023-11-06 [email protected] Roll Packages from cccf5d24d703 to 49eac1fec6c7 (2 revisions) (flutter/flutter#137943) 2023-11-06 [email protected] Update BottomNavigationBar tests for M3 (flutter/flutter#136624) 2023-11-06 [email protected] Roll Flutter Engine from 4f6ed31bd8bd to bdfa8aa8f81f (1 revision) (flutter/flutter#137941) 2023-11-06 [email protected] Roll Flutter Engine from b9b3269b0b2c to 4f6ed31bd8bd (2 revisions) (flutter/flutter#137935) 2023-11-06 [email protected] Provide a helpful error message when `ColorScheme.brightness` doesn't match `ThemeData.brightness` (flutter/flutter#137611) 2023-11-06 [email protected] Roll Flutter Engine from 555ffa17b55c to b9b3269b0b2c (1 revision) (flutter/flutter#137933) 2023-11-06 [email protected] Fix tool exit message shown when user provides a non-list to "assets" for a deferred component (flutter/flutter#137837) 2023-11-06 [email protected] Roll Flutter Engine from 0d8c7ceacc01 to 555ffa17b55c (1 revision) (flutter/flutter#137921) 2023-11-06 [email protected] Roll Flutter Engine from 11d66db97d3f to 0d8c7ceacc01 (1 revision) (flutter/flutter#137920) 2023-11-05 [email protected] Roll Flutter Engine from a7592e42464c to 11d66db97d3f (1 revision) (flutter/flutter#137914) 2023-11-05 [email protected] Roll Flutter Engine from 1c6bd97e2288 to a7592e42464c (1 revision) (flutter/flutter#137912) 2023-11-05 [email protected] Roll Flutter Engine from daf18fe46b72 to 1c6bd97e2288 (1 revision) (flutter/flutter#137908) 2023-11-04 [email protected] Roll Flutter Engine from a45e679828e6 to daf18fe46b72 (1 revision) (flutter/flutter#137904) 2023-11-04 [email protected] Roll Flutter Engine from fb2a9c20141e to a45e679828e6 (1 revision) (flutter/flutter#137903) 2023-11-04 [email protected] Roll Flutter Engine from 576833873c15 to fb2a9c20141e (1 revision) (flutter/flutter#137900) 2023-11-04 [email protected] Roll Flutter Engine from 25f5e285f874 to 576833873c15 (1 revision) (flutter/flutter#137898) 2023-11-04 [email protected] Roll Flutter Engine from 7282a5d94ab6 to 25f5e285f874 (2 revisions) (flutter/flutter#137892) 2023-11-04 [email protected] Roll Flutter Engine from b66a87626300 to 7282a5d94ab6 (2 revisions) (flutter/flutter#137887) 2023-11-04 [email protected] HeroController should dispatch creation and disposal events. (flutter/flutter#137835) 2023-11-04 [email protected] Roll Flutter Engine from ec20731de6ff to b66a87626300 (1 revision) (flutter/flutter#137877) 2023-11-03 [email protected] InheritedElement.removeDependent() (flutter/flutter#129210) 2023-11-03 [email protected] Remove unused generic type from BottomSheet (flutter/flutter#137791) 2023-11-03 [email protected] Roll Flutter Engine from 035740c1f90e to ec20731de6ff (2 revisions) (flutter/flutter#137872) 2023-11-03 [email protected] Pin dart-lang/native dependencies (flutter/flutter#137601) 2023-11-03 [email protected] Send caret rect to embedder on selection update (flutter/flutter#137863) 2023-11-03 [email protected] Roll Flutter Engine from 677040f10f65 to 035740c1f90e (4 revisions) (flutter/flutter#137871) 2023-11-03 [email protected] Tooltip docs: Recommend setting preferBelow to false in theme (flutter/flutter#135879) 2023-11-03 [email protected] Roll Flutter Engine from f363a6e5e093 to 677040f10f65 (2 revisions) (flutter/flutter#137861) 2023-11-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Android] Support Android 34" (flutter/flutter#137865) 2023-11-03 [email protected] InkFeature should dispatch creation and disposal events. (flutter/flutter#137793) 2023-11-03 [email protected] AppLifecycleListener should dispatch creation and disposal events. (flutter/flutter#137840) 2023-11-03 [email protected] Roll Flutter Engine from d5ccb5b1b706 to f363a6e5e093 (2 revisions) (flutter/flutter#137858) 2023-11-03 [email protected] Roll Flutter Engine from 72262a238090 to d5ccb5b1b706 (3 revisions) (flutter/flutter#137857) 2023-11-03 [email protected] Updated the nested navigation NavigationBar example (flutter/flutter#137788) 2023-11-03 [email protected] Roll Flutter Engine from 0415a4f5e2a2 to 72262a238090 (2 revisions) (flutter/flutter#137853) 2023-11-03 [email protected] Roll Flutter Engine from 8531c5935356 to 0415a4f5e2a2 (1 revision) (flutter/flutter#137847) 2023-11-03 [email protected] Roll flutter gallery version forward. (flutter/flutter#137846) 2023-11-03 [email protected] Roll Flutter Engine from 43653c5a3ec8 to 8531c5935356 (1 revision) (flutter/flutter#137845) 2023-11-03 [email protected] Roll Packages from 33c2b4e53ad7 to cccf5d24d703 (6 revisions) (flutter/flutter#137841) 2023-11-03 [email protected] [web] dispatch corresponding keyup events in text editing integrations (flutter/flutter#136874) 2023-11-03 [email protected] [leak-tracking] Add more leak tracking in test/painting #3 (flutter/flutter#136170) 2023-11-03 [email protected] Upgrade leak_tracker and remove some deps in allow list. (flutter/flutter#137806) 2023-11-03 [email protected] Roll Flutter Engine from fc7c3f70c076 to 43653c5a3ec8 (1 revision) (flutter/flutter#137827) ...

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 1, 2023

chingjun approved these changes Nov 1, 2023

View reviewed changes

chingjun added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 2, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 2, 2023

chingjun requested a review from christopherfujino November 2, 2023 16:00

christopherfujino approved these changes Nov 2, 2023

View reviewed changes

iinozemtsev force-pushed the proxied_json branch from 68da031 to 41a799d Compare November 3, 2023 09:01

iinozemtsev force-pushed the proxied_json branch from 41a799d to 369de61 Compare November 3, 2023 09:44

christopherfujino approved these changes Nov 3, 2023

View reviewed changes

christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 3, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 3, 2023

Change cast in json parsing

07e0b5f

jsonDecode decodes lists as `List<Object?>`, so the cast to `List<Object>` fails at runtime in sound null safety mode.

iinozemtsev force-pushed the proxied_json branch from 369de61 to 07e0b5f Compare November 6, 2023 10:41

chingjun added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 6, 2023

auto-submit bot merged commit defa4bc into flutter:master Nov 6, 2023

engine-flutter-autoroll mentioned this pull request Nov 6, 2023

Roll Flutter from 29b25165cab8 to defa4bce0a0d (100 revisions) flutter/packages#5340

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023

defa4bc Change cast in json parsing (flutter/flutter#137708)

285028b

engine-flutter-autoroll mentioned this pull request Nov 6, 2023

Roll Flutter from 29b25165cab8 to f5a983535131 (101 revisions) flutter/packages#5341

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023

defa4bc Change cast in json parsing (flutter/flutter#137708)

da9b3d9

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024

defa4bc Change cast in json parsing (flutter/flutter#137708)

18b51b5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Change cast in json parsing #137708

Change cast in json parsing #137708

Uh oh!

iinozemtsev commented Nov 1, 2023

Uh oh!

flutter-dashboard bot commented Nov 1, 2023

Uh oh!

chingjun left a comment

Uh oh!

auto-submit bot commented Nov 2, 2023

Uh oh!

christopherfujino left a comment

Uh oh!

iinozemtsev commented Nov 3, 2023

Uh oh!

christopherfujino left a comment

Uh oh!

auto-submit bot commented Nov 3, 2023

Uh oh!

iinozemtsev commented Nov 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Change cast in json parsing #137708

Change cast in json parsing #137708

Uh oh!

Conversation

iinozemtsev commented Nov 1, 2023

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Nov 1, 2023

Uh oh!

chingjun left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Nov 2, 2023

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

iinozemtsev commented Nov 3, 2023

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Nov 3, 2023

Uh oh!

iinozemtsev commented Nov 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants