Skip to content

Add no-shuffle to reorderable_list_test.dart #137698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zanderso merged 1 commit into from
Nov 1, 2023
Merged

Add no-shuffle to reorderable_list_test.dart #137698

zanderso merged 1 commit into from
Nov 1, 2023

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Nov 1, 2023

For #137696

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Nov 1, 2023
jonahwilliams
jonahwilliams approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso merged commit 2630047 into master Nov 1, 2023
@zanderso zanderso deleted the zanderso-patch-2 branch November 1, 2023 15:47
dnfield added a commit that referenced this pull request Nov 1, 2023
@dnfield
Revert "Add no-shuffle to reorderable_list_test.dart (#137698)"
a474390 
This reverts commit 2630047.
@dnfield dnfield mentioned this pull request Nov 1, 2023
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
a98062d 
…#137698)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
ae5feef 
…#137698)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
808c60a 
…#137698)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
d7858ee 
…#137698)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
3adf701 
…#137698)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
20dfbe4 
…#137698)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
72ac7a9 
…#137698)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
80d016e 
…#137698)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
c40170e 
…#137698)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
fa68661 
…#137698)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
a799376 
…#137698)
dnfield added a commit that referenced this pull request Nov 3, 2023
@dnfield
Revert "Add no-shuffle to reorderable_list_test.dart (#137698)"
53ff755 
This reverts commit 2630047.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
451021e 
…#137698)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
cf43960 
…#137698)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
625d3b8 
…#137698)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
78755ef 
…#137698)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
5934763 
…#137698)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
39a9ef2 
…#137698)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
d652356 
…#137698)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
0263fb4 
…#137698)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
c7ee3f3 
…#137698)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
7df1ab2 
…#137698)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
4dbcf22 
…#137698)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
a03428e 
…#137698)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
9907b07 
…#137698)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
ebdf703 
…#137698)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
48e72e4 
…#137698)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
4dce83a 
…#137698)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
0857754 
…#137698)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
30c5ca7 
…#137698)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
af29b99 
…#137698)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
4fdee97 
…#137698)
goderbauer pushed a commit that referenced this pull request Nov 7, 2023
@dnfield
Revert "Add no-shuffle to reorderable_list_test.dart" (#137715)
e724689 
Reverts #137698

Not needed after #137697

Must not land until after that one
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
2630047 Add no-shuffle to reorderable_list_test.dart (flutter/flutter…
ea3605d 
…#137698)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer Awaiting requested review from goderbauer

@dnfield dnfield Awaiting requested review from dnfield

@chunhtai chunhtai Awaiting requested review from chunhtai

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zanderso @jonahwilliams