Fix chips `onDeleted` callback don't show the delete button when disabled #137685

TahaTesser · 2023-11-01T11:10:48Z

fixes Chips with onDeleted callback should show the delete button in the disabled state

Code sample

expand to view the code sample

import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Example(),
    );
  }
}

class Example extends StatefulWidget {
  const Example({super.key});

  @override
  State<Example> createState() => _ExampleState();
}

class _ExampleState extends State<Example> {

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.spaceEvenly,
          children: <Widget>[
            RawChip(
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('RawChip'),
              onSelected: null,
              isEnabled: false,
              onDeleted: () {},
            ),
            InputChip(
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('InputChip'),
              isEnabled: false,
              onPressed: null,
              onDeleted: () {},
            ),
            FilterChip(
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('FilterChip'),
              onSelected: null,
              onDeleted: () {},
            ),
          ],
        ),
      ),
    );
  }
}

Before	After

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2023-11-02T09:02:24Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #137685 at sha 820f38fe8bfbbf37a15653354eb91a709f43e1ef

HansMuller

LGTM - there are quite a few golden file changes; please check to see that they're all valid.

flutter-dashboard · 2023-11-03T09:42:17Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #137685 at sha af3b0d48b544abb1fca652f1d731433c18080514

flutter-dashboard · 2023-11-06T14:17:20Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #137685 at sha bd5dcd729ca29dfe89e99cbadb234ba1a0a019af

TahaTesser · 2023-11-07T17:41:53Z

Blocked by #138009

Piinks · 2023-11-13T21:22:10Z

I don't know that this is blocked by #138009, @TahaTesser can you share more context? I think that issue can be fixed before or after this one lands.

TahaTesser · 2023-11-14T08:49:18Z

I don't know that this is blocked by #138009, @TahaTesser can you share more context? I think that issue can be fixed before or after this one lands.

Chip with a delete button isn't rendered properly when disabled in the canvaskit renderer after #136918
Unfortunately, this PR is also testing Chip with a delete button in the disabled state.

We will need to be able to test the chip in canvaskit renderer

TahaTesser · 2023-11-17T17:17:47Z

Waiting for flutter/engine#48142 to roll into framework

flutter-dashboard · 2023-11-20T11:33:44Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #137685 at sha a7172302ff26a24c6b12a60a93e58fab9e1f9d79

flutter-dashboard · 2023-11-20T13:21:34Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #137685 at sha a1c8c285fd6d87a640fd8353f53181e74488ddb1

flutter-dashboard · 2023-11-20T14:57:35Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #137685 at sha 43294057af865ad06a60ae645c45b81808d065f2

TahaTesser · 2023-11-20T15:50:20Z

Rebased to get engine fix flutter/engine#48142

Pushed an empty to get updated golden files and approved the golden files.

Piinks

It looks like there is a merge conflict here. I checked the Google testing failure, and it looks unrelated, but a rebase with the merge being resolved would help confirming that. :)

TahaTesser · 2023-11-22T12:03:30Z

It looks like there is a merge conflict here.

It's actually a conflict from my own PR #138287 😂

I checked the Google testing failure, and it looks unrelated

It was failing before the conflict. Let me resolve the conflict and try again.

…bled

TahaTesser · 2023-11-29T20:40:59Z

@Piinks
After multiple tries, this is finally green. Is it safe to merge?

TahaTesser · 2023-11-29T20:55:12Z

Pushed an empty to make sure all is good.

Piinks

I checked the goldens, and they should be good to go. I'll keep an eye on when this lands though just in case there is an issue. :)

…hen disabled (flutter/flutter#137685)

flutter/flutter@5e5b529...918e336 2023-11-30 [email protected] Move Impeller tests on Pixel 7 Pro from staging to prod (flutter/flutter#139280) 2023-11-30 [email protected] Introduce multi-touch drag strategies for `DragGestureRecognizer` (flutter/flutter#136708) 2023-11-30 [email protected] Use the correct recipe on fuchsia_precache. (flutter/flutter#139279) 2023-11-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Migration for the `sendTiming` events for `package:unified_analytics`" (flutter/flutter#139278) 2023-11-30 [email protected] Migrate fuchsia_precache to shard tests. (flutter/flutter#139202) 2023-11-29 [email protected] Fix chips `onDeleted` callback don't show the delete button when disabled (flutter/flutter#137685) 2023-11-29 [email protected] Roll Flutter Engine from 9a7e49d75411 to 35939ca8534f (5 revisions) (flutter/flutter#139259) 2023-11-29 [email protected] Refactor to use Apple system fonts (flutter/flutter#137275) 2023-11-29 [email protected] Dynamic view sizing (flutter/flutter#138648) 2023-11-29 [email protected] Roll dependencies (flutter/flutter#139203) 2023-11-29 [email protected] add sourceTimeStamp to ScaleUpdateDetails (flutter/flutter#135936) 2023-11-29 [email protected] Roll Flutter Engine from 222beb28a8eb to 9a7e49d75411 (1 revision) (flutter/flutter#139250) 2023-11-29 [email protected] Remove deprecated `PlatformMenuBar.body` (flutter/flutter#138509) 2023-11-29 [email protected] Migration for the `sendTiming` events for `package:unified_analytics` (flutter/flutter#138896) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@OverRide

…bled (flutter#137685) fixes [Chips with `onDeleted` callback should show the delete button in the `disabled` state](flutter#136638) ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @OverRide Widget build(BuildContext context) { return const MaterialApp( debugShowCheckedModeBanner: false, home: Example(), ); } } class Example extends StatefulWidget { const Example({super.key}); @OverRide State<Example> createState() => _ExampleState(); } class _ExampleState extends State<Example> { @OverRide Widget build(BuildContext context) { return Scaffold( body: Center( child: Column( mainAxisAlignment: MainAxisAlignment.spaceEvenly, children: <Widget>[ RawChip( avatar: const Icon(Icons.favorite_rounded), label: const Text('RawChip'), onSelected: null, isEnabled: false, onDeleted: () {}, ), InputChip( avatar: const Icon(Icons.favorite_rounded), label: const Text('InputChip'), isEnabled: false, onPressed: null, onDeleted: () {}, ), FilterChip( avatar: const Icon(Icons.favorite_rounded), label: const Text('FilterChip'), onSelected: null, onDeleted: () {}, ), ], ), ), ); } } ``` </details> | Before | After | | --------------- | --------------- | | <img src="https://github.com/flutter/flutter/assets/48603081/8bd458de-cfd2-44f0-a0dd-a8298938c61f" /> | <img src="https://github.com/flutter/flutter/assets/48603081/afca0684-b061-416b-b029-5316588c6888" /> |

…hen disabled (flutter/flutter#137685)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Nov 1, 2023

TahaTesser force-pushed the disabled_chip_delete_button branch from 85811c4 to 820f38f Compare November 2, 2023 08:04

TahaTesser marked this pull request as ready for review November 2, 2023 08:58

TahaTesser requested a review from HansMuller November 2, 2023 08:58

flutter-dashboard bot added the will affect goldens Changes to golden files label Nov 2, 2023

HansMuller approved these changes Nov 2, 2023

View reviewed changes

TahaTesser force-pushed the disabled_chip_delete_button branch from 820f38f to af3b0d4 Compare November 3, 2023 09:11

TahaTesser force-pushed the disabled_chip_delete_button branch 2 times, most recently from feb1929 to bd5dcd7 Compare November 6, 2023 13:44

TahaTesser mentioned this pull request Nov 7, 2023

Regression in golden testing a disabled chip with delete button in CanvasKit #138009

Closed

2 tasks

TahaTesser added blocked Issue is blocked by another issue and removed blocked Issue is blocked by another issue labels Nov 10, 2023

TahaTesser force-pushed the disabled_chip_delete_button branch from bd5dcd7 to a717230 Compare November 20, 2023 10:39

TahaTesser force-pushed the disabled_chip_delete_button branch from a717230 to a1c8c28 Compare November 20, 2023 12:51

TahaTesser force-pushed the disabled_chip_delete_button branch 2 times, most recently from d65dbcc to a8a2a5b Compare November 21, 2023 09:05

Piinks reviewed Nov 21, 2023

View reviewed changes

TahaTesser force-pushed the disabled_chip_delete_button branch 3 times, most recently from 8af5539 to 57188f2 Compare November 28, 2023 14:07

TahaTesser added 2 commits November 29, 2023 17:11

Fix chips onDeleted callback don't show the delete button when disa…

46b7a3e

…bled

Kick tests

0960e97

TahaTesser force-pushed the disabled_chip_delete_button branch from 57188f2 to 0960e97 Compare November 29, 2023 15:12

Kick tests

288f6f9

Piinks approved these changes Nov 29, 2023

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 29, 2023

auto-submit bot merged commit 4648f54 into flutter:master Nov 29, 2023

TahaTesser deleted the disabled_chip_delete_button branch November 30, 2023 08:26

engine-flutter-autoroll mentioned this pull request Nov 30, 2023

Roll Flutter from 5e5b5292f739 to 918e336014e1 (14 revisions) flutter/packages#5526

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 30, 2023

4648f54 Fix chips onDeleted callback don't show the delete button w…

19e6781

…hen disabled (flutter/flutter#137685)

HansMuller mentioned this pull request Dec 1, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024

4648f54 Fix chips onDeleted callback don't show the delete button w…

c8fcb38

…hen disabled (flutter/flutter#137685)

Fix chips onDeleted callback don't show the delete button when disabled #137685

Fix chips onDeleted callback don't show the delete button when disabled #137685

Uh oh!

Conversation

TahaTesser commented Nov 1, 2023

Code sample

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Nov 2, 2023

Uh oh!

HansMuller left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented Nov 3, 2023

Uh oh!

flutter-dashboard bot commented Nov 6, 2023

Uh oh!

TahaTesser commented Nov 7, 2023

Uh oh!

Piinks commented Nov 13, 2023

Uh oh!

TahaTesser commented Nov 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TahaTesser commented Nov 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-dashboard bot commented Nov 20, 2023

Uh oh!

flutter-dashboard bot commented Nov 20, 2023

Uh oh!

flutter-dashboard bot commented Nov 20, 2023

Uh oh!

TahaTesser commented Nov 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

TahaTesser commented Nov 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TahaTesser commented Nov 29, 2023

Uh oh!

TahaTesser commented Nov 29, 2023

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix chips `onDeleted` callback don't show the delete button when disabled #137685

Fix chips `onDeleted` callback don't show the delete button when disabled #137685

HansMuller left a comment •

edited

Loading

TahaTesser commented Nov 14, 2023 •

edited

Loading

TahaTesser commented Nov 17, 2023 •

edited

Loading

TahaTesser commented Nov 20, 2023 •

edited

Loading

TahaTesser commented Nov 22, 2023 •

edited

Loading