Skip to content

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented Oct 31, 2023

Redoing #137069, after making changes in leak_tracker dependency structure.
Contributes to: #135856

This time circular dependency leak_tracker <-> flutter_test is removed.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Oct 31, 2023
@polina-c polina-c changed the title - Add dependency on leak_tracker and leak_tracker_testing to flutter_test. Oct 31, 2023
@polina-c polina-c marked this pull request as ready for review October 31, 2023 21:49
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 31, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 31, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 31, 2023

auto label is removed for flutter/flutter/137646, due to - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 31, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 31, 2023

auto label is removed for flutter/flutter/137646, due to - The status or check suite Linux_android hot_mode_dev_cycle_linux__benchmark has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 31, 2023
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 1, 2023
@polina-c polina-c merged commit d50f1fa into flutter:master Nov 1, 2023
@polina-c polina-c deleted the re-add-dep branch November 1, 2023 02:19
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 1, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 1, 2023
Roll Flutter from e12d1a7 to 29b2516 (34 revisions)

flutter/flutter@e12d1a7...29b2516

2023-11-01 [email protected] Roll Flutter Engine from 5ef5e6da9075 to 8ffc705a55d5 (2 revisions) (flutter/flutter#137664)
2023-11-01 [email protected] Roll Flutter Engine from a0ac6b432cdf to 5ef5e6da9075 (1 revision) (flutter/flutter#137657)
2023-11-01 [email protected] Roll Flutter Engine from db06c2e10459 to a0ac6b432cdf (8 revisions) (flutter/flutter#137656)
2023-11-01 [email protected] Add dependency on leak_tracker and leak_tracker_testing to flutter_test. (flutter/flutter#137646)
2023-11-01 [email protected] Roll Flutter Engine from 406b7d71ca37 to db06c2e10459 (5 revisions) (flutter/flutter#137651)
2023-11-01 [email protected] Roll pub packages (flutter/flutter#137650)
2023-10-31 [email protected] Manual roll Flutter Engine from 39be0fc34503 to 406b7d71ca37 (8 revisions) (flutter/flutter#137649)
2023-10-31 [email protected] PerformanceModeRequestHandle should dispatch creation and disposal events. (flutter/flutter#137642)
2023-10-31 [email protected] Fix minor typo in doc of window.dart (flutter/flutter#137483)
2023-10-31 [email protected] fix. typos (flutter/flutter#137178)
2023-10-31 [email protected] Document the scale argument to NetworkImage (flutter/flutter#137456)
2023-10-31 [email protected] Revert "Roll Flutter Engine from 39be0fc34503 to ec3e988099be (2 revisions)" (flutter/flutter#137647)
2023-10-31 [email protected] Move dependency on leak_tracker from dependencies to dev_dependencies in flutter_test. (flutter/flutter#137633)
2023-10-31 [email protected] Roll Flutter Engine from 39be0fc34503 to ec3e988099be (2 revisions) (flutter/flutter#137637)
2023-10-31 [email protected] Roll Flutter Engine from 4da3e5b12540 to 39be0fc34503 (4 revisions) (flutter/flutter#137635)
2023-10-31 [email protected] Update `ColorScheme.light`, `ColorScheme.dark`, `ColorScheme.highContrastLight`, & `ColorScheme.highContrastDark`  constructors docs for Material 3 (flutter/flutter#137149)
2023-10-31 [email protected] Roll Flutter Engine from 47465eb4fbe6 to 4da3e5b12540 (2 revisions) (flutter/flutter#137632)
2023-10-31 [email protected] Fix. typos (flutter/flutter#137465)
2023-10-31 [email protected] Roll Flutter Engine from 9de8146d21bf to 47465eb4fbe6 (1 revision) (flutter/flutter#137626)
2023-10-31 [email protected] Roll Flutter Engine from 6b9b806151ed to 9de8146d21bf (1 revision) (flutter/flutter#137624)
2023-10-31 [email protected] Roll Packages from 2af6954 to c9fec61 (12 revisions) (flutter/flutter#137623)
2023-10-31 [email protected] Fix divide-by-zero crash in animation_bench benchmark (flutter/flutter#137539)
2023-10-31 [email protected] Roll Flutter Engine from 11a569d97a26 to 6b9b806151ed (1 revision) (flutter/flutter#137617)
2023-10-31 [email protected] Fix formatting (flutter/flutter#137613)
2023-10-31 [email protected] Roll Flutter Engine from 5ca5cbb6efdb to 11a569d97a26 (1 revision) (flutter/flutter#137612)
2023-10-31 [email protected] Roll Flutter Engine from b4de734eb78e to 5ca5cbb6efdb (1 revision) (flutter/flutter#137610)
2023-10-31 [email protected] Roll Flutter Engine from 17eff7ab6299 to b4de734eb78e (1 revision) (flutter/flutter#137594)
2023-10-31 [email protected] Roll Flutter Engine from 44309c9f385c to 17eff7ab6299 (2 revisions) (flutter/flutter#137587)
2023-10-31 [email protected] Roll Flutter Engine from 64b0e07e2259 to 44309c9f385c (1 revision) (flutter/flutter#137584)
2023-10-30 [email protected] Roll Flutter Engine from 4f87c20b3c34 to 64b0e07e2259 (4 revisions) (flutter/flutter#137582)
2023-10-30 [email protected] Manual roll Flutter Engine from 84dcb4fb9301 to 4f87c20b3c34 (24 revisions) (flutter/flutter#137570)
2023-10-30 [email protected] [web] cache the base URL as root index.html (flutter/flutter#136594)
2023-10-30 [email protected] [flutter_tools] ensure processUtils reports exit code in ProcessExceptions (flutter/flutter#136672)
2023-10-30 [email protected] [flutter_tool] change print when selecting developer identity for code signing (flutter/flutter#136978)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants