-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Unified analytics events migration for BuildEvent
#137562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified analytics events migration for BuildEvent
#137562
Conversation
packages/flutter_tools/pubspec.yaml
Outdated
| http_multi_server: 3.2.1 | ||
| convert: 3.1.1 | ||
| async: 2.11.0 | ||
| unified_analytics: 5.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christopherfujino @andrewkolos this version update will likely take some time to make it into google3 (git -> gerrit -> google3).. so i'm expecting Google testing to fail for a day or 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have the option to manually roll it? Not necessarily for this change, but to lift the constraint that EACH PR you land in dart-lang/tools, the corresponding tool PR must wait for rolls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am able to run git -> gerrit by manually opening up a CL pretty easily. This job only runs twice a week so being able to manually do it is ideal.
But for the google3 roll, this job runs daily and I don't know how to do those manually yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, daily is not too bad. Why don't we plan to roll manually to gerrit (btw, where is the gerrit repo?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do plan on rolling gerrit manually, and the changes are made in the dart-lang/sdk repo but it goes through Gerrit when you want to contribute to the sdk, here is the CL for making the version bump
Their contributing guide also explains how to get your CLs submitted to Gerrit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, if that's the Dart SDK, then that's probably only for the analyzer and dart-dev, right? The copybara script pulls from dart-lang/tools, right (I'm actually asking, I don't really know)? We don't need to manually update the dart sdk unless that's blocking the copybara github -> internal google roll.
Related to tracker issue:
package:unified_analyticsimplementation in flutter tool #128251Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.