Skip to content

Instrumented PipelineOwner for leak tracking #137494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 2 commits into from
Nov 2, 2023
Merged

Instrumented PipelineOwner for leak tracking #137494

polina-c merged 2 commits into from
Nov 2, 2023

Conversation

@droidbg
Copy link
Contributor

@droidbg droidbg commented Oct 29, 2023

Description

Adds PipelineOwner creation and disposal dispatching for memory leak tracking as part of #137311

Tests

  • Updates object_test.dart to test PipelineOwner object creation and disposal dispatching.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 29, 2023
@droidbg droidbg marked this pull request as ready for review November 2, 2023 03:57
@droidbg droidbg changed the title [WIP] Instrumented PipelineOwner for leak tracking Instrumented PipelineOwner for leak tracking Nov 2, 2023
@droidbg
Copy link
Contributor Author

droidbg commented Nov 2, 2023

cc: @polina-c

@polina-c
Copy link
Contributor

polina-c commented Nov 2, 2023

Thank you!

@polina-c polina-c merged commit e2d5e8f into flutter:master Nov 2, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
724af91 
…#137494)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
1ec263b 
…#137494)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
2b144b2 
…#137494)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
c5ec84b 
…#137494)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
22036bf 
…#137494)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
f069bf2 
…#137494)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
984a0f2 
…#137494)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
0af0131 
…#137494)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
733726f 
…#137494)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
49cc6f2 
…#137494)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
183051a 
…#137494)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
42023f9 
…#137494)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
a0e30da 
…#137494)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
344a5e5 
…#137494)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
aefebd9 
…#137494)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
bcd789a 
…#137494)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
5edadad 
…#137494)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
8982d14 
…#137494)
@HansMuller HansMuller mentioned this pull request Nov 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
989d7b2 
…#137494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
0ec397d 
…#137494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
3a7d7fd 
…#137494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
aeffcbb 
…#137494)
@droidbg droidbg deleted the PipelineOwner branch November 5, 2023 13:51
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
9f2ef3a 
…#137494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
9d584b4 
…#137494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
a4dfb83 
…#137494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
5b7db78 
…#137494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
43a85d6 
…#137494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
50374c8 
…#137494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
cf4c91a 
…#137494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
9ba7ff5 
…#137494)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
e2d5e8f Instrumented PipelineOwner for leak tracking (flutter/flutter…
03b7335 
…#137494)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polina-c polina-c polina-c approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@droidbg @polina-c