Skip to content

Fix. typos #137479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Nov 1, 2023
Merged

Fix. typos #137479

auto-submit merged 4 commits into from
Nov 1, 2023

Conversation

@droidbg
Copy link
Contributor

@droidbg droidbg commented Oct 28, 2023

Description

This PR fixes typos in

  • editable_text_show_on_screen_test.dart
  • form_test.dart
  • framework.dart

Pre-launch Checklist

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Oct 28, 2023
goderbauer
goderbauer reviewed Oct 30, 2023
View reviewed changes
packages/flutter/test/widgets/form_test.dart Outdated
Copy link
Member

@goderbauer goderbauer Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this spelling was just a stylistic choice to highlight that it was referring to the pump method. This shouldn't be "fixed".

Copy link
Contributor Author

@droidbg droidbg Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay but in same file line 44, same line is there without ' :

      formKey.currentState!.save();
      // Pumping is unnecessary because callback happens regardless of frames.
      expect(fieldValue, equals(testValue));

Copy link
Member

@goderbauer goderbauer Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, we could also fix it to be consistent with that line:

Suggested change
// pumping is unnecessary because callback happens regardless of frames
// Pumping is unnecessary because callback happens regardless of frames.

Copy link
Contributor Author

@droidbg droidbg Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, done with the changes 😀

goderbauer
goderbauer approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 1, 2023
cbracken
cbracken approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ltgm!

@auto-submit auto-submit bot merged commit 01b8854 into flutter:master Nov 1, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
c507ec4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
da109f5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
5ff87da
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
1ba395c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
d4c67c8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
9db7f31
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
695a6fc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
e20125c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
f35a62a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
864db33
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
926ce34
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
d00d83e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
20a71e3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
ea172f1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
5ce40b8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
1dc7feb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
e69d5dc
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
5334d12
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
4f53cc8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
0f181ad
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
a9efda2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
f93ea5c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
28d1a70
@droidbg droidbg deleted the typo_fix_28_2 branch November 5, 2023 13:51
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
24dc030
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
c917e46
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
d6074a6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
5623dfb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
3fcb167
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
7c5a085
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
40d226f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
90b1616
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
01b8854 Fix. typos (flutter/flutter#137479)
c9b7745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken cbracken approved these changes

@loic-sharma loic-sharma loic-sharma approved these changes

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@droidbg @cbracken @loic-sharma @goderbauer