Instrument RestorationBucket, _RouteEntry and DisposableBuildContext for leak tracking. #137477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
a: text input
Contributor
Author
|
cc @polina-c |
polina-c
added
the
a: leak tracking
polina-c
approved these changes
Oct 28, 2023
Contributor
|
Thank you! |
Contributor
Author
|
@polina-c, thanks a lot for the review! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 29, 2023
…Context for leak tracking. (flutter/flutter#137477)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 29, 2023
…Context for leak tracking. (flutter/flutter#137477)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 30, 2023
…Context for leak tracking. (flutter/flutter#137477)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 30, 2023
…Context for leak tracking. (flutter/flutter#137477)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 30, 2023
flutter/flutter@a4ec627...e12d1a7 2023-10-29 [email protected] Reland `coverableLineCache` optimisation (#136851) (flutter/flutter#137385) 2023-10-28 [email protected] Instrument RestorationBucket, _RouteEntry and DisposableBuildContext for leak tracking. (flutter/flutter#137477) 2023-10-28 [email protected] BannerPainter should dispatch creation and disposal events. (flutter/flutter#137472) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
…Context for leak tracking. (flutter/flutter#137477)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RestorationBucket,_RouteEntry,DisposableBuildContextcreation and disposal dispatching for memory leak tracking as part of Clean up memory leaks in Flutter Framework, phase 2. #137311;Tests
restoration_bucker_test.dartto testRestorationBucketobject creation and disposal dispatching;disposable_build_context_test.dartto testDisposableBuildContextobject creation and disposal dispatching;Unfortunately, it is not possible to test memory events of the
_RouteEntryas it is private.Pre-launch Checklist
///).