Fix. typos #137465
Merged
Fix. typos #137465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
framework
goderbauer
reviewed
Oct 30, 2023
Member
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
LGTM after comment is resolved
| /// * Vietnamese: `| 13 | Tháng 7 | 2012 |` | ||
| /// | ||
| /// Can be used with [showCupertinoModalPopup] to display the picker modally at | ||
| /// Can be used with [showCupertinoModalPopup] to display the picker modal at |
Member
There was a problem hiding this comment.
"modally" was not a typo here. It means "in a modal way". Can you undo this change?
Contributor
Author
There was a problem hiding this comment.
Thanks for the review, I have changed it back to modally .
goderbauer
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 31, 2023
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Oct 31, 2023
## Description This PR fixes typos in - `date_picker.dart` - `date_picker_theme.dart` - `dropdown.dart`
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 1, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 1, 2023
Roll Flutter from e12d1a7 to 29b2516 (34 revisions) flutter/flutter@e12d1a7...29b2516 2023-11-01 [email protected] Roll Flutter Engine from 5ef5e6da9075 to 8ffc705a55d5 (2 revisions) (flutter/flutter#137664) 2023-11-01 [email protected] Roll Flutter Engine from a0ac6b432cdf to 5ef5e6da9075 (1 revision) (flutter/flutter#137657) 2023-11-01 [email protected] Roll Flutter Engine from db06c2e10459 to a0ac6b432cdf (8 revisions) (flutter/flutter#137656) 2023-11-01 [email protected] Add dependency on leak_tracker and leak_tracker_testing to flutter_test. (flutter/flutter#137646) 2023-11-01 [email protected] Roll Flutter Engine from 406b7d71ca37 to db06c2e10459 (5 revisions) (flutter/flutter#137651) 2023-11-01 [email protected] Roll pub packages (flutter/flutter#137650) 2023-10-31 [email protected] Manual roll Flutter Engine from 39be0fc34503 to 406b7d71ca37 (8 revisions) (flutter/flutter#137649) 2023-10-31 [email protected] PerformanceModeRequestHandle should dispatch creation and disposal events. (flutter/flutter#137642) 2023-10-31 [email protected] Fix minor typo in doc of window.dart (flutter/flutter#137483) 2023-10-31 [email protected] fix. typos (flutter/flutter#137178) 2023-10-31 [email protected] Document the scale argument to NetworkImage (flutter/flutter#137456) 2023-10-31 [email protected] Revert "Roll Flutter Engine from 39be0fc34503 to ec3e988099be (2 revisions)" (flutter/flutter#137647) 2023-10-31 [email protected] Move dependency on leak_tracker from dependencies to dev_dependencies in flutter_test. (flutter/flutter#137633) 2023-10-31 [email protected] Roll Flutter Engine from 39be0fc34503 to ec3e988099be (2 revisions) (flutter/flutter#137637) 2023-10-31 [email protected] Roll Flutter Engine from 4da3e5b12540 to 39be0fc34503 (4 revisions) (flutter/flutter#137635) 2023-10-31 [email protected] Update `ColorScheme.light`, `ColorScheme.dark`, `ColorScheme.highContrastLight`, & `ColorScheme.highContrastDark` constructors docs for Material 3 (flutter/flutter#137149) 2023-10-31 [email protected] Roll Flutter Engine from 47465eb4fbe6 to 4da3e5b12540 (2 revisions) (flutter/flutter#137632) 2023-10-31 [email protected] Fix. typos (flutter/flutter#137465) 2023-10-31 [email protected] Roll Flutter Engine from 9de8146d21bf to 47465eb4fbe6 (1 revision) (flutter/flutter#137626) 2023-10-31 [email protected] Roll Flutter Engine from 6b9b806151ed to 9de8146d21bf (1 revision) (flutter/flutter#137624) 2023-10-31 [email protected] Roll Packages from 2af6954 to c9fec61 (12 revisions) (flutter/flutter#137623) 2023-10-31 [email protected] Fix divide-by-zero crash in animation_bench benchmark (flutter/flutter#137539) 2023-10-31 [email protected] Roll Flutter Engine from 11a569d97a26 to 6b9b806151ed (1 revision) (flutter/flutter#137617) 2023-10-31 [email protected] Fix formatting (flutter/flutter#137613) 2023-10-31 [email protected] Roll Flutter Engine from 5ca5cbb6efdb to 11a569d97a26 (1 revision) (flutter/flutter#137612) 2023-10-31 [email protected] Roll Flutter Engine from b4de734eb78e to 5ca5cbb6efdb (1 revision) (flutter/flutter#137610) 2023-10-31 [email protected] Roll Flutter Engine from 17eff7ab6299 to b4de734eb78e (1 revision) (flutter/flutter#137594) 2023-10-31 [email protected] Roll Flutter Engine from 44309c9f385c to 17eff7ab6299 (2 revisions) (flutter/flutter#137587) 2023-10-31 [email protected] Roll Flutter Engine from 64b0e07e2259 to 44309c9f385c (1 revision) (flutter/flutter#137584) 2023-10-30 [email protected] Roll Flutter Engine from 4f87c20b3c34 to 64b0e07e2259 (4 revisions) (flutter/flutter#137582) 2023-10-30 [email protected] Manual roll Flutter Engine from 84dcb4fb9301 to 4f87c20b3c34 (24 revisions) (flutter/flutter#137570) 2023-10-30 [email protected] [web] cache the base URL as root index.html (flutter/flutter#136594) 2023-10-30 [email protected] [flutter_tools] ensure processUtils reports exit code in ProcessExceptions (flutter/flutter#136672) 2023-10-30 [email protected] [flutter_tool] change print when selecting developer identity for code signing (flutter/flutter#136978) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes typos in
date_picker.dartdate_picker_theme.dartdropdown.dartPre-launch Checklist
///).