Skip to content

added SegmentedButton.stylefrom to SegmentedButton #137430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AcarFurkan wants to merge 13 commits into from
Closed

added SegmentedButton.stylefrom to SegmentedButton #137430

AcarFurkan wants to merge 13 commits into from

Conversation

@AcarFurkan
Copy link
Contributor

@AcarFurkan AcarFurkan commented Oct 27, 2023

SegmentedButtom.styleFrom has been added to the segment button, so there is no longer any need to the button style from the beginning.

#129215 I opened this problem myself, but I was rejected because I handled too many items in a PR. For now, I wrote a structure that only handles MaterialStates instead of users.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Oct 27, 2023
@AcarFurkan
Copy link
Contributor Author

AcarFurkan commented Oct 28, 2023

hi, @TahaTesser do you know what should i do right now?

@TahaTesser
Copy link
Member

TahaTesser commented Oct 30, 2023 •
edited
Loading

hi, @TahaTesser do you know what should i do right now?

Hi, thanks for the contribution.

First you to need to fix the code format. Flutter source code doesn't use dart format tool.
Instead, Flutter source code is formatted manually.

In this PR you have more lines changed than necessary due to dart format. You probably have auto format enabled in your IDE. Please revert the format changes. Only changes that are necessary to fix the issue should be part of your PR.

Please read the style guide, especially these sections
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#formatting
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#prefer-a-maximum-line-length-of-80-characters

Secondly, link the Flutter issue this fixes in your description

Third, this requires tests in order to land.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels. engine flutter/engine related. See also e: labels. a: animation Animation APIs a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: routes Navigator, Router, and related APIs. labels Oct 30, 2023
@AcarFurkan AcarFurkan closed this by deleting the head repository Oct 30, 2023
@AcarFurkan
Copy link
Contributor Author

AcarFurkan commented Oct 30, 2023

l changed my computer, l will fix this error thank you so much

@AcarFurkan AcarFurkan mentioned this pull request Oct 30, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AcarFurkan @TahaTesser