Reland coverableLineCache optimisation (#136851)
#137385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up coverage" This reverts commit 8df6218.
github-actions
bot
added
the
tool
liamappelbe
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/137385, due to - The status or check suite Mac_arm64 run_debug_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
CaseyHillers
approved these changes
Oct 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 30, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 30, 2023
flutter/flutter@a4ec627...e12d1a7 2023-10-29 [email protected] Reland `coverableLineCache` optimisation (#136851) (flutter/flutter#137385) 2023-10-28 [email protected] Instrument RestorationBucket, _RouteEntry and DisposableBuildContext for leak tracking. (flutter/flutter#137477) 2023-10-28 [email protected] BannerPainter should dispatch creation and disposal events. (flutter/flutter#137472) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Oct 31, 2023
…7385) Relands flutter#136851, which was rolled back in flutter#137121 package:coverage has been rolled, so the breakages should be fixed. Also, in this reland I've changed the `coverableLineCache` parameter to be optional, which is safer.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands #136851, which was rolled back in #137121
package:coverage has been rolled, so the breakages should be fixed. Also, in this reland I've changed the
coverableLineCacheparameter to be optional, which is safer.