Skip to content

Make it possible to disable tapping to dismiss a tooltip. #137375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 7 commits into from
Nov 9, 2023
Merged

Make it possible to disable tapping to dismiss a tooltip. #137375

auto-submit merged 7 commits into from
Nov 9, 2023

Conversation

@hannah-hyj
Copy link
Member

@hannah-hyj hannah-hyj commented Oct 26, 2023 •
edited
Loading

issue: #137438

Use case: I want to add action button is tooltip and thus want to disable tap to dismiss a tooltip.

image

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Oct 26, 2023
@hannah-hyj hannah-hyj requested a review from chunhtai October 27, 2023 18:20
@hannah-hyj hannah-hyj marked this pull request as ready for review October 27, 2023 18:20
@hannah-hyj hannah-hyj marked this pull request as draft October 27, 2023 18:20
@hannah-hyj hannah-hyj marked this pull request as ready for review October 27, 2023 18:33
chunhtai
chunhtai reviewed Nov 1, 2023
View reviewed changes
packages/flutter/lib/src/material/tooltip.dart Outdated
/// The length of the delay time before dismissing tooltips by tap.
///
/// Defaults to 0 milliseconds (tooltips are dismissed immediately).
final Duration? tapToDismissDelayDuration;
Copy link
Contributor

@chunhtai chunhtai Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a weird api, is the goal to be able to have other gesture recognizer on the tool tip to fire? what if the gesture take longer than the duration to fire? for example if someone add a long press gesture recognizer in tooltip.

Should we just have a flag to turn off tap dismissal?

Copy link
Member Author

@hannah-hyj hannah-hyj Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense, I changed it to a flag for tap dismissal

@hannah-hyj hannah-hyj changed the title Make it possible to customize the Delay Duration before tap to dismiss a tooltip. Make it possible to disable tapping to dismiss a tooltip. Nov 2, 2023
@hannah-hyj hannah-hyj requested a review from chunhtai November 2, 2023 19:59
chunhtai
chunhtai approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannah-hyj hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 9, 2023
@auto-submit auto-submit bot merged commit c4b11d8 into flutter:master Nov 9, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023
@engine-flutter-autoroll
c4b11d8 Make it possible to disable tapping to dismiss a tooltip. (fl…
1d99ccd 
…utter/flutter#137375)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023
@engine-flutter-autoroll
c4b11d8 Make it possible to disable tapping to dismiss a tooltip. (fl…
1d6fc98 
…utter/flutter#137375)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023
@engine-flutter-autoroll
c4b11d8 Make it possible to disable tapping to dismiss a tooltip. (fl…
de440d2 
…utter/flutter#137375)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023
@engine-flutter-autoroll
c4b11d8 Make it possible to disable tapping to dismiss a tooltip. (fl…
1e8cba2 
…utter/flutter#137375)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023
@engine-flutter-autoroll
c4b11d8 Make it possible to disable tapping to dismiss a tooltip. (fl…
a9d0112 
…utter/flutter#137375)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023
@engine-flutter-autoroll
c4b11d8 Make it possible to disable tapping to dismiss a tooltip. (fl…
2bb50a8 
…utter/flutter#137375)
@HansMuller HansMuller mentioned this pull request Nov 10, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 11, 2023
@engine-flutter-autoroll
c4b11d8 Make it possible to disable tapping to dismiss a tooltip. (fl…
8788676 
…utter/flutter#137375)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 11, 2023
@engine-flutter-autoroll
c4b11d8 Make it possible to disable tapping to dismiss a tooltip. (fl…
6378154 
…utter/flutter#137375)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2023
@engine-flutter-autoroll
c4b11d8 Make it possible to disable tapping to dismiss a tooltip. (fl…
a8c11fb 
…utter/flutter#137375)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2023
@engine-flutter-autoroll
c4b11d8 Make it possible to disable tapping to dismiss a tooltip. (fl…
bc1d4f6 
…utter/flutter#137375)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2023
@engine-flutter-autoroll
c4b11d8 Make it possible to disable tapping to dismiss a tooltip. (fl…
81d24ae 
…utter/flutter#137375)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2023
@engine-flutter-autoroll
c4b11d8 Make it possible to disable tapping to dismiss a tooltip. (fl…
6f510ec 
…utter/flutter#137375)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2023
@engine-flutter-autoroll
c4b11d8 Make it possible to disable tapping to dismiss a tooltip. (fl…
e9b6682 
…utter/flutter#137375)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023
@engine-flutter-autoroll
c4b11d8 Make it possible to disable tapping to dismiss a tooltip. (fl…
3b17224 
…utter/flutter#137375)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023
@engine-flutter-autoroll
c4b11d8 Make it possible to disable tapping to dismiss a tooltip. (fl…
6686856 
…utter/flutter#137375)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023
@engine-flutter-autoroll
c4b11d8 Make it possible to disable tapping to dismiss a tooltip. (fl…
79c8ac6 
…utter/flutter#137375)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023
@engine-flutter-autoroll
c4b11d8 Make it possible to disable tapping to dismiss a tooltip. (fl…
93aafeb 
…utter/flutter#137375)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023
@engine-flutter-autoroll
c4b11d8 Make it possible to disable tapping to dismiss a tooltip. (fl…
636531b 
…utter/flutter#137375)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
c4b11d8 Make it possible to disable tapping to dismiss a tooltip. (fl…
5976a57 
…utter/flutter#137375)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hannah-hyj @chunhtai