Skip to content

Attempt a less invasive way to disable fading. - #13733

Merged
Hixie merged 1 commit into
flutter:masterfrom
Hixie:fade-perf
Dec 21, 2017
Merged

Hixie merged 1 commit into
flutter:masterfrom
Hixie:fade-perf

Conversation

@Hixie

@Hixie Hixie commented Dec 21, 2017

Copy link
Copy Markdown
Contributor

Hopefully this will fix the performance regression in #13680 but with an easier way to flip the switch.

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include a link to the issue so people can follow it if they want to know when this gets removed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

Hopefully this will fix the performance regression in flutter#13680 but with an easier way to flip the switch.
@Hixie

Hixie commented Dec 21, 2017

Copy link
Copy Markdown
Contributor Author

will land on green.

@xster

xster commented Dec 21, 2017

Copy link
Copy Markdown
Contributor

LG

@Hixie
Hixie merged commit 4e16b9d into flutter:master Dec 21, 2017
@Hixie
Hixie deleted the fade-perf branch December 21, 2017 23:02
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
Hopefully this will fix the performance regression in flutter#13680 but with an easier way to flip the switch.
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants