Skip to content

Conversation

@goderbauer
Copy link
Member

The private _ libraries should not be advertised as importable. Moving them to the src directory.

I noticed this while browsing our dart docs. This should remove the underscore entries.

image

Replaces #137197.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin labels Oct 25, 2023
@goderbauer goderbauer requested a review from dnfield October 25, 2023 19:16
@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 25, 2023
@auto-submit auto-submit bot merged commit 1c90ed8 into flutter:master Oct 25, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 26, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 26, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 26, 2023
flutter/flutter@5dd2a4e...c555599

2023-10-26 [email protected] Roll Packages from f751ffb to fea24c5 (4 revisions) (flutter/flutter#137339)
2023-10-26 [email protected] Roll Flutter Engine from 23649a0529e5 to 61ae5ef94e9c (1 revision) (flutter/flutter#137337)
2023-10-26 [email protected] Run test with older version of Xcode (flutter/flutter#137293)
2023-10-26 [email protected] Roll Flutter Engine from f8525b9fdddf to 23649a0529e5 (1 revision) (flutter/flutter#137333)
2023-10-26 [email protected] Add ProcessTextService (flutter/flutter#137145)
2023-10-26 [email protected] Roll Flutter Engine from b6bea17e39d3 to f8525b9fdddf (1 revision) (flutter/flutter#137330)
2023-10-26 [email protected] Roll Flutter Engine from ec29ea930f58 to b6bea17e39d3 (1 revision) (flutter/flutter#137329)
2023-10-26 [email protected] Roll Flutter Engine from 2a01fae53ded to ec29ea930f58 (1 revision) (flutter/flutter#137326)
2023-10-26 [email protected] Roll Flutter Engine from 10a91eb44c5b to 2a01fae53ded (1 revision) (flutter/flutter#137320)
2023-10-26 [email protected] Roll Flutter Engine from f844ab933364 to 10a91eb44c5b (1 revision) (flutter/flutter#137317)
2023-10-26 [email protected] Roll Flutter Engine from 6428ed576841 to f844ab933364 (1 revision) (flutter/flutter#137314)
2023-10-26 [email protected] Roll Flutter Engine from 6e09ee14e244 to 6428ed576841 (38 revisions) (flutter/flutter#137310)
2023-10-26 [email protected] fix:: trigger onTapOutside only if has focus (flutter/flutter#136291)
2023-10-25 [email protected] Fix structure of pkg:integration_test (flutter/flutter#137283)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@goderbauer goderbauer deleted the foosdf branch March 8, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants