Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #137275 at sha e13d74482b3e6bdc6360fdfb5da03f6b5b9986f6

Golden tests failed as expected for titles and the pickers, as those where most impacted.

CC @goderbauer

Would love to test this, any ETA when this goes to master branch?

Would love to test this, any ETA when this goes to master branch?

Apologies, we are still getting some internal work done before merging this. I'm hoping to be able to merge it after the Thanksgiving holiday. The engine side is merged into master however, and can be tested by setting your font family to "CupertinoSystemDisplay" or "CupertinoSystemText" in your theme or elsewhere right now.

CupertinoSystemDisplay

Thanks for that. Looks MUCH better 👍

@MitchellGoodwin
I see this got merged into master branch, that is awesome thank you!

Question for you, it looks like not all the font weights are working, for example the type FontWeight.w400 and FontWeight.w700 are working well, but not 500, 600, 800, etc.. Am I doing it wrong?

EDIT: using variable font weights also has no effect outside of 400 and 700

@MitchellGoodwin I see this got merged into master branch, that is awesome thank you!

Question for you, it looks like not all the font weights are working, for example the type FontWeight.w400 and FontWeight.w700 are working well, but not 500, 600, 800, etc.. Am I doing it wrong?

EDIT: using variable font weights also has no effect outside of 400 and 700

I'm playing around with it, and I'm getting the large font to change font weight as expected with the test code I'm running. The Text font looks like it might be off from native though. Could you maybe post the code you are running and a screenshot of what you are seeing?

Sure, my code is pretty simple (shortened to take out the colors for brevity sake):

                                      Text.rich(
                                          TextSpan(
                                              text:widget.map["title"].toString(),
                                              style: TextStyle(
                                                fontSize: 17,
                                                letterSpacing: -0.3,
                                                fontWeight: FontWeight.w400, //Tried cycling here from 100-900
                                                // fontVariations: [
                                                //   FontVariation(
                                                //       'wght', 500)
                                                // ],
                                              ),
                                      )
                                    ),

Testing from FontWeight.w100 up to FontWeight.w900 only renders two weights as follows:

FontWeight 100-500 (blue text)

FontWeight 600-900 (blue text)

To me its rendering the same way browsers render CSS fonts when the font family doesn't actually have the in-between weights loaded, ie. lumping 600-800 with the 700 weight and <=500 with the 400 weight.

EDIT, just to be sure, this is the version I'm on. Im pretty sure the font updates to the new default one, as it looks much better.

Flutter 3.17.0-19.0.pre.23 • channel master • https://github.com/flutter/flutter.git
Framework • revision 88710972da (23 minutes ago) • 2023-11-30 11:25:50 -0800
Engine • revision 35939ca853
Tools • Dart 3.3.0 (build 3.3.0-170.0.dev) • DevTools 2.30.0-dev.4

Ok, I'm seeing the same now. Looking into it, that should be working.