Skip to content

[Android] Support Android 34 #137191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 6 commits into from
Nov 2, 2023
Merged

[Android] Support Android 34 #137191

auto-submit merged 6 commits into from
Nov 2, 2023

Conversation

@camsim99
Copy link
Contributor

@camsim99 camsim99 commented Oct 24, 2023 •
edited
Loading

Adds support for Android 34 in the following ways:

  • Bumps integration tests compile SDK versions 33 --> 34
  • Bumps template compile SDK version 33 --> 34
  • Also changes deprecated compileSdkVersion to compileSdk

Part of #134220

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 24, 2023
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Oct 25, 2023
@camsim99 camsim99 changed the title wip: Bump to 34? [Android] Support Android 34 Oct 25, 2023
@camsim99 camsim99 marked this pull request as ready for review October 26, 2023 17:51
@camsim99 camsim99 requested a review from a team October 26, 2023 17:51
gmackall
gmackall approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Do you know if we have an issue to do the same thing for blahVersion -> blah for min and target sdks?

@camsim99
Copy link
Contributor Author

camsim99 commented Oct 31, 2023

This LGTM! Do you know if we have an issue to do the same thing for blahVersion -> blah for min and target sdks?

I don't see that in the docs. I think it's just compileSdkVersion that was deprecated!

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 31, 2023
@gmackall
Copy link
Member

gmackall commented Oct 31, 2023

This LGTM! Do you know if we have an issue to do the same thing for blahVersion -> blah for min and target sdks?

I don't see that in the docs. I think it's just compileSdkVersion that was deprecated!

Those docs also don't indicate that compileSdkVersion was deprecated, though.
https://developer.android.com/reference/tools/gradle-api/7.0/com/android/build/api/dsl/BaseFlavor#minsdkversion indicates it is deprecated, though I can't tell if this documentation is referring to the general case. Do you have a link to documentation indicating that compileSdkVersion is deprecated? I would be curious to see if there is a source that indicates the deprecation of only compileSdkVersion.

@gmackall
Copy link
Member

gmackall commented Oct 31, 2023

Also, for any of them that we decide are deprecated, we should probably update https://docs.flutter.dev/deployment/android#reviewing-the-gradle-build-configuration to reflect

@camsim99
Copy link
Contributor Author

camsim99 commented Oct 31, 2023 •
edited
Loading

Ah good intuition! I couldn't find the right docs for min but I see it now (as you linked): https://developer.android.com/reference/tools/gradle-api/7.0/com/android/build/api/dsl/BaseFlavor#minSdkVersion(kotlin.Int)

Here's target: https://developer.android.com/reference/tools/gradle-api/7.1/com/android/build/api/dsl/ApplicationBaseFlavor#targetsdkversion

compileSdkVersion is here: https://developer.android.com/reference/tools/gradle-api/7.0/com/android/build/api/dsl/CommonExtension#compilesdkversion

I can file a bug to update that website + those two (min, target) as well

@reidbaker
Copy link
Contributor

reidbaker commented Nov 1, 2023

I was worried this change might break older clients but it looks like minSdk as a property has been available since 4.1 https://developer.android.com/reference/tools/gradle-api/4.1/com/android/build/api/dsl/BaseFlavor#minsdk and that is as old as the dev site hosts api versions.

@auto-submit
Copy link
Contributor

auto-submit bot commented Nov 1, 2023

auto label is removed for flutter/flutter/137191, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 1, 2023
@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 2, 2023
@auto-submit auto-submit bot merged commit 675fec8 into flutter:master Nov 2, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
675fec8 [Android] Support Android 34 (flutter/flutter#137191)
37f9612
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
675fec8 [Android] Support Android 34 (flutter/flutter#137191)
64e7c9e
@camsim99 camsim99 added the revert Autorevert PR (with "Reason for revert:" comment) label Nov 3, 2023
@auto-submit auto-submit bot mentioned this pull request Nov 3, 2023
Merged
8 tasks
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Nov 3, 2023
auto-submit bot pushed a commit that referenced this pull request Nov 3, 2023
Revert "[Android] Support Android 34 (#137191)"
67f7145 
This reverts commit 675fec8.
auto-submit bot added a commit that referenced this pull request Nov 3, 2023
@auto-submit
Reverts "[Android] Support Android 34" (#137865)
c4ce947 
Reverts #137191
Initiated by: camsim99
This change reverts the following previous change:
Original Description:
Adds support for Android 34 in the following ways:

- Bumps integration tests compile SDK versions 33 --> 34
- Bumps template compile SDK version 33 --> 34
- Also changes deprecated `compileSdkVersion` to `compileSdk`

Part of #134220
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
675fec8 [Android] Support Android 34 (flutter/flutter#137191)
9a5e361
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
675fec8 [Android] Support Android 34 (flutter/flutter#137191)
29be198
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
675fec8 [Android] Support Android 34 (flutter/flutter#137191)
fea803a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
675fec8 [Android] Support Android 34 (flutter/flutter#137191)
8732041
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2023
@engine-flutter-autoroll
675fec8 [Android] Support Android 34 (flutter/flutter#137191)
ca3efdf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2023
@engine-flutter-autoroll
675fec8 [Android] Support Android 34 (flutter/flutter#137191)
6e6aaaf
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
675fec8 [Android] Support Android 34 (flutter/flutter#137191)
f8853bf
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
675fec8 [Android] Support Android 34 (flutter/flutter#137191)
0b9596d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
675fec8 [Android] Support Android 34 (flutter/flutter#137191)
58e4f0e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
675fec8 [Android] Support Android 34 (flutter/flutter#137191)
730296b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
675fec8 [Android] Support Android 34 (flutter/flutter#137191)
4849f5f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
675fec8 [Android] Support Android 34 (flutter/flutter#137191)
75e598f
This was referenced Nov 6, 2023
Merged
Merged
auto-submit bot pushed a commit that referenced this pull request Nov 8, 2023
@camsim99
[Android] Fix FlutterTestRunner.java deprecations (#138093)
3215c49 
Fixes deprecations causing unexpected standard error integration test failures: #138061, #138063, #138067, #138077.

Note that the issue this fixes was the same that was the cause for reverting #137191. I made this same fix in #137967 and changed `Mac_android run_release_test` to run in presubmit to see a successful run for proof that this fix works.
auto-submit bot pushed a commit that referenced this pull request Nov 9, 2023
@camsim99
[Android] Support Android 34 (take 2) (#137967)
c66bb0a 
Re-lands #137191.

The fix for the issue causing that PR to be reverted was tested in this PR but ultimately landed separately in #138093.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
675fec8 [Android] Support Android 34 (flutter/flutter#137191)
f834778
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

@gmackall gmackall gmackall approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camsim99 @gmackall @reidbaker