Skip to content

Conversation

@polina-c
Copy link
Contributor

No description provided.

@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Oct 24, 2023
@polina-c polina-c marked this pull request as ready for review October 24, 2023 22:09
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 24, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 24, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 24, 2023

auto label is removed for flutter/flutter/137190, due to - The status or check suite Linux module_host_with_custom_build_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 24, 2023
@polina-c polina-c changed the title Gradle Fix Gradle. Oct 24, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 24, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 24, 2023

auto label is removed for flutter/flutter/137190, due to - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

@polina-c polina-c changed the title Fix Gradle. Fix Gradle lockfiles. Oct 24, 2023
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 24, 2023
@auto-submit auto-submit bot merged commit ccbe221 into flutter:master Oct 24, 2023
QuncCccccc added a commit that referenced this pull request Oct 25, 2023
QuncCccccc added a commit that referenced this pull request Oct 25, 2023
@zanderso
Copy link
Member

If/when this needs to be re-landed, please include an explanation in the PR description or a link to a GitHub issue. Thanks!


/// Callers can lookup localized strings with an instance of StockStrings returned
/// by `StockStrings.of(context)`.
/// Callers can lookup localized strings with an instance of StockStrings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this file look unrelated to updating the lock files. Should it go in a separate PR?

}
break;
}
switch (locale.countryCode) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation here still doesn't look right.

Locale('en'),
Locale('en', 'US'),
Locale('es'),
Locale('es')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the style guide asks to keep the trailing comma here, but double check me on that.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2023
@polina-c polina-c deleted the gradle branch October 25, 2023 16:11
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 25, 2023
Roll Flutter from 5e8b5f4 to 5dd2a4e (59 revisions)

flutter/flutter@5e8b5f4...5dd2a4e

2023-10-25 [email protected] Ensure Xcode project is setup to start debugger (flutter/flutter#136977)
2023-10-25 [email protected] Marks Windows build_tests_6_6 to be unflaky (flutter/flutter#137216)
2023-10-25 [email protected] Remove gem and docker files. (flutter/flutter#137200)
2023-10-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[gallery] Reland roll gallery to  ecfb9e5352bd12032301b12b30d5853d83d89bda" (flutter/flutter#137264)
2023-10-25 [email protected] [gallery] Reland roll gallery to  ecfb9e5352bd12032301b12b30d5853d83d89bda (flutter/flutter#137199)
2023-10-25 [email protected] Roll Packages from 2faf992 to f751ffb (11 revisions) (flutter/flutter#137254)
2023-10-25 [email protected] Marks Windows build_tests_3_6 to be unflaky (flutter/flutter#137214)
2023-10-25 [email protected] Marks Windows build_tests_5_6 to be unflaky (flutter/flutter#137215)
2023-10-25 [email protected] Marks Windows build_tests_2_6 to be unflaky (flutter/flutter#137213)
2023-10-25 [email protected] Revert "Update `OutlinedButton` tests for Material 3 (#136809)" (flutter/flutter#137242)
2023-10-25 [email protected] Update `OutlinedButton` tests for Material 3 (flutter/flutter#136809)
2023-10-25 [email protected] Let `OverflowBox` be shrink-wrappable (flutter/flutter#129095)
2023-10-25 [email protected] Add dependency on leak_tracker to flutter_test. (flutter/flutter#137069)
2023-10-25 [email protected] fix SliverReorderableLists item wrong offset (flutter/flutter#136828)
2023-10-25 [email protected] Remove `bringup: true` from realm_checker and remove the redundant tool test. (flutter/flutter#137186)
2023-10-25 [email protected] Revert "Fix Gradle lockfiles." (flutter/flutter#137198)
2023-10-24 [email protected] Fix Gradle lockfiles. (flutter/flutter#137190)
2023-10-24 [email protected] Fix Typos (flutter/flutter#137173)
2023-10-24 [email protected] Roll Flutter Engine from d6a48e9963df to 6e09ee14e244 (1 revision) (flutter/flutter#137185)
2023-10-24 [email protected] Roll Flutter Engine from 602b5131ee4d to d6a48e9963df (6 revisions) (flutter/flutter#137180)
2023-10-24 [email protected] TextField - allow to customize cursor color in error state (flutter/flutter#136121)
2023-10-24 [email protected] [macOS] Refactor macOS build/codesize analysis (flutter/flutter#137164)
2023-10-24 [email protected] Roll Flutter Engine from dc00de7dacf4 to 602b5131ee4d (1 revision) (flutter/flutter#137174)
2023-10-24 [email protected] Check the realm file in its own shard. (flutter/flutter#137160)
2023-10-24 [email protected] Roll Flutter Engine from 1890bd7dc412 to dc00de7dacf4 (1 revision) (flutter/flutter#137172)
2023-10-24 [email protected] Roll Flutter Engine from ca7ef01c99c6 to 1890bd7dc412 (2 revisions) (flutter/flutter#137158)
2023-10-24 [email protected] Migrate mac builds to ruby dep. (flutter/flutter#136929)
2023-10-24 [email protected] Roll Packages from 4bf5114 to 2faf992 (7 revisions) (flutter/flutter#137154)
2023-10-24 [email protected] Roll Flutter Engine from 7224835bb65f to ca7ef01c99c6 (1 revision) (flutter/flutter#137153)
2023-10-24 [email protected] fix some typos (flutter/flutter#137144)
2023-10-24 [email protected] Roll Flutter Engine from 8f7488e0b4b5 to 7224835bb65f (1 revision) (flutter/flutter#137150)
2023-10-24 [email protected] Roll Flutter Engine from d58895093d0a to 8f7488e0b4b5 (3 revisions) (flutter/flutter#137135)
2023-10-24 [email protected] Roll Flutter Engine from 2a8471f188cd to d58895093d0a (4 revisions) (flutter/flutter#137130)
2023-10-24 [email protected] Roll Flutter Engine from 71600d89aa3f to 2a8471f188cd (2 revisions) (flutter/flutter#137129)
2023-10-24 [email protected] Roll Flutter Engine from 3dd197dcf9e5 to 71600d89aa3f (1 revision) (flutter/flutter#137127)
2023-10-24 [email protected] Roll Flutter Engine from bdbd1058858b to 3dd197dcf9e5 (2 revisions) (flutter/flutter#137125)
2023-10-24 [email protected] Roll Flutter Engine from 0ef5caa91c40 to bdbd1058858b (1 revision) (flutter/flutter#137119)
2023-10-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use `coverage.collect`'s `coverableLineCache` param to speed up coverage" (flutter/flutter#137121)
2023-10-24 [email protected] Roll Flutter Engine from dd6a6531e816 to 0ef5caa91c40 (1 revision) (flutter/flutter#137114)
2023-10-24 [email protected] Roll Flutter Engine from 0bd703132cc1 to dd6a6531e816 (2 revisions) (flutter/flutter#137111)
2023-10-23 [email protected] Roll Flutter Engine from abeab897a29c to 0bd703132cc1 (3 revisions) (flutter/flutter#137107)
2023-10-23 [email protected] Upgrade packages in flutter and flutter_test. (flutter/flutter#137106)
2023-10-23 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.2.0 to 2.3.1 (flutter/flutter#137103)
2023-10-23 [email protected] Dartdoc warnings (flutter/flutter#137077)
2023-10-23 [email protected] Roll Flutter Engine from e89f0421bcab to abeab897a29c (5 revisions) (flutter/flutter#137100)
2023-10-23 [email protected] Cover last test/material tests with leak tracking. (flutter/flutter#137004)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants