Skip to content

fix. typos #137178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 6 commits into from
Oct 31, 2023
Merged

fix. typos #137178

auto-submit merged 6 commits into from
Oct 31, 2023

Conversation

@droidbg
Copy link
Contributor

@droidbg droidbg commented Oct 24, 2023

Description

This PR fixes typos in

  • checkbox.dart
  • chip_test.dart
  • color_scheme.dart
  • color_scheme_test.dart
  • curves.dart

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs f: material design flutter/packages/flutter/material repository. f: cupertino flutter/packages/flutter/cupertino repository labels Oct 24, 2023
@droidbg droidbg changed the title fix. typos in comments fix. typos Oct 25, 2023
Piinks
Piinks reviewed Oct 26, 2023
View reviewed changes
@droidbg
Copy link
Contributor Author

droidbg commented Oct 27, 2023

@Piinks done with the changes.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Oct 27, 2023

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #137178 at sha 794aebe582d2e886e7c362b7d6c701143e72403b

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Oct 27, 2023
@Piinks Piinks mentioned this pull request Oct 27, 2023
Closed
Piinks
Piinks approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

goderbauer
goderbauer approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added autosubmit Merge PR when tree becomes green via auto submit App and removed will affect goldens Changes to golden files labels Oct 31, 2023
cbracken
cbracken approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtn

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 31, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 31, 2023

auto label is removed for flutter/flutter/137178, due to - The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 31, 2023
@auto-submit auto-submit bot merged commit e7726ea into flutter:master Oct 31, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 1, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 1, 2023
@engine-flutter-autoroll
e7726ea fix. typos (flutter/flutter#137178)
174b068
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 1, 2023
@engine-flutter-autoroll
Roll Flutter from e12d1a7 to 29b2516 (34 revisions) (#5290)
6ad40b9 
Roll Flutter from e12d1a7 to 29b2516 (34 revisions)

flutter/flutter@e12d1a7...29b2516

2023-11-01 [email protected] Roll Flutter Engine from 5ef5e6da9075 to 8ffc705a55d5 (2 revisions) (flutter/flutter#137664)
2023-11-01 [email protected] Roll Flutter Engine from a0ac6b432cdf to 5ef5e6da9075 (1 revision) (flutter/flutter#137657)
2023-11-01 [email protected] Roll Flutter Engine from db06c2e10459 to a0ac6b432cdf (8 revisions) (flutter/flutter#137656)
2023-11-01 [email protected] Add dependency on leak_tracker and leak_tracker_testing to flutter_test. (flutter/flutter#137646)
2023-11-01 [email protected] Roll Flutter Engine from 406b7d71ca37 to db06c2e10459 (5 revisions) (flutter/flutter#137651)
2023-11-01 [email protected] Roll pub packages (flutter/flutter#137650)
2023-10-31 [email protected] Manual roll Flutter Engine from 39be0fc34503 to 406b7d71ca37 (8 revisions) (flutter/flutter#137649)
2023-10-31 [email protected] PerformanceModeRequestHandle should dispatch creation and disposal events. (flutter/flutter#137642)
2023-10-31 [email protected] Fix minor typo in doc of window.dart (flutter/flutter#137483)
2023-10-31 [email protected] fix. typos (flutter/flutter#137178)
2023-10-31 [email protected] Document the scale argument to NetworkImage (flutter/flutter#137456)
2023-10-31 [email protected] Revert "Roll Flutter Engine from 39be0fc34503 to ec3e988099be (2 revisions)" (flutter/flutter#137647)
2023-10-31 [email protected] Move dependency on leak_tracker from dependencies to dev_dependencies in flutter_test. (flutter/flutter#137633)
2023-10-31 [email protected] Roll Flutter Engine from 39be0fc34503 to ec3e988099be (2 revisions) (flutter/flutter#137637)
2023-10-31 [email protected] Roll Flutter Engine from 4da3e5b12540 to 39be0fc34503 (4 revisions) (flutter/flutter#137635)
2023-10-31 [email protected] Update `ColorScheme.light`, `ColorScheme.dark`, `ColorScheme.highContrastLight`, & `ColorScheme.highContrastDark`  constructors docs for Material 3 (flutter/flutter#137149)
2023-10-31 [email protected] Roll Flutter Engine from 47465eb4fbe6 to 4da3e5b12540 (2 revisions) (flutter/flutter#137632)
2023-10-31 [email protected] Fix. typos (flutter/flutter#137465)
2023-10-31 [email protected] Roll Flutter Engine from 9de8146d21bf to 47465eb4fbe6 (1 revision) (flutter/flutter#137626)
2023-10-31 [email protected] Roll Flutter Engine from 6b9b806151ed to 9de8146d21bf (1 revision) (flutter/flutter#137624)
2023-10-31 [email protected] Roll Packages from 2af6954 to c9fec61 (12 revisions) (flutter/flutter#137623)
2023-10-31 [email protected] Fix divide-by-zero crash in animation_bench benchmark (flutter/flutter#137539)
2023-10-31 [email protected] Roll Flutter Engine from 11a569d97a26 to 6b9b806151ed (1 revision) (flutter/flutter#137617)
2023-10-31 [email protected] Fix formatting (flutter/flutter#137613)
2023-10-31 [email protected] Roll Flutter Engine from 5ca5cbb6efdb to 11a569d97a26 (1 revision) (flutter/flutter#137612)
2023-10-31 [email protected] Roll Flutter Engine from b4de734eb78e to 5ca5cbb6efdb (1 revision) (flutter/flutter#137610)
2023-10-31 [email protected] Roll Flutter Engine from 17eff7ab6299 to b4de734eb78e (1 revision) (flutter/flutter#137594)
2023-10-31 [email protected] Roll Flutter Engine from 44309c9f385c to 17eff7ab6299 (2 revisions) (flutter/flutter#137587)
2023-10-31 [email protected] Roll Flutter Engine from 64b0e07e2259 to 44309c9f385c (1 revision) (flutter/flutter#137584)
2023-10-30 [email protected] Roll Flutter Engine from 4f87c20b3c34 to 64b0e07e2259 (4 revisions) (flutter/flutter#137582)
2023-10-30 [email protected] Manual roll Flutter Engine from 84dcb4fb9301 to 4f87c20b3c34 (24 revisions) (flutter/flutter#137570)
2023-10-30 [email protected] [web] cache the base URL as root index.html (flutter/flutter#136594)
2023-10-30 [email protected] [flutter_tools] ensure processUtils reports exit code in ProcessExceptions (flutter/flutter#136672)
2023-10-30 [email protected] [flutter_tool] change print when selecting developer identity for code signing (flutter/flutter#136978)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
@droidbg droidbg deleted the update_comments branch November 13, 2023 01:43
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
e7726ea fix. typos (flutter/flutter#137178)
5becdc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken cbracken approved these changes

@goderbauer goderbauer goderbauer approved these changes

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

a: animation Animation APIs autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@droidbg @cbracken @goderbauer @Piinks