Skip to content

Added support for vscode and vscode-insiders installed via Flatpak - #137123

Merged
auto-submit[bot] merged 5 commits into
flutter:masterfrom
KristijanZic:vscode-flatpak
Dec 4, 2023
Merged

Added support for vscode and vscode-insiders installed via Flatpak#137123
auto-submit[bot] merged 5 commits into
flutter:masterfrom
KristijanZic:vscode-flatpak

Conversation

@KristijanZic

@KristijanZic KristijanZic commented Oct 24, 2023

Copy link
Copy Markdown
Contributor

Closes #137122

Before
VS Code and VS Code Insiders installed via Flatpak aren't detected

After

[✓] VS Code (version 1.82.2)
    • VS Code at /var/lib/flatpak/app/com.visualstudio.code/x86_64/stable/active/files/extra/vscode
    • Flutter extension version 3.74.0

[✓] VS Code (version 1.84.0-insider)
    • VS Code at /var/lib/flatpak/app/com.visualstudio.code.insiders/x86_64/beta/active/files/extra/vscode-insiders
    • Flutter extension version 3.75.20231002

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 24, 2023
christopherfujino
christopherfujino approved these changes Nov 9, 2023
View reviewed changes

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andrewkolos
andrewkolos approved these changes Nov 9, 2023
View reviewed changes

@andrewkolos andrewkolos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkolos andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 9, 2023
@auto-submit

auto-submit Bot commented Nov 10, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter/137123, due to Pull request flutter/flutter/137123 is not in a mergeable state.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 10, 2023
@christopherfujino

christopherfujino commented Nov 16, 2023

Copy link
Copy Markdown
Contributor

@KristijanZic looks like you will have to resolve the merge conflict before we can merge this PR

@navaronbracke navaronbracke mentioned this pull request Nov 26, 2023
Closed
2 tasks done
@christopherfujino

christopherfujino commented Dec 1, 2023

Copy link
Copy Markdown
Contributor

@KristijanZic friendly ping

@KristijanZic

KristijanZic commented Dec 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@KristijanZic friendly ping

On it! I'm just timing it so that it says "flutter" on 16 PR GitHub badge on my profile xD
I just need a few hours, it'll be done today :)

@christopherfujino

christopherfujino commented Dec 1, 2023

Copy link
Copy Markdown
Contributor

@KristijanZic friendly ping

On it! I'm just timing it so that it says "flutter" on 16 PR GitHub badge on my profile xD I just need a few hours, it'll be done today :)

For context I'm not trying to rush you. As long as it's on your radar that's fine. In our weekly PR review we comment on PRs that haven't had activity in a while so we can identify stale ones and close them.

@christopherfujino

christopherfujino commented Dec 1, 2023

Copy link
Copy Markdown
Contributor

Also closed PRs can always be re-opened. So this is all low-stakes, we're just trying to do periodic garbage collection :)

@KristijanZic

KristijanZic commented Dec 2, 2023

Copy link
Copy Markdown
Contributor Author

@christopherfujino done :)
But Google testing is failing for no obvious reason again :/

@CaseyHillers CaseyHillers mentioned this pull request Dec 4, 2023
Closed
1 task done
@christopherfujino christopherfujino added autosubmit Merge PR when tree becomes green via auto submit App and removed tool Affects the "flutter" command-line tool. See also t: labels. labels Dec 4, 2023
@auto-submit
auto-submit Bot merged commit 77503bd into flutter:master Dec 4, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
2209bbc 
…atpak (flutter/flutter#137123)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
40cd53a 
…atpak (flutter/flutter#137123)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
5e5eb80 
…atpak (flutter/flutter#137123)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
60b187c 
…atpak (flutter/flutter#137123)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
1221294 
…atpak (flutter/flutter#137123)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
1d040a2 
…atpak (flutter/flutter#137123)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
9a5f7d4 
…atpak (flutter/flutter#137123)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
d03b84a 
…atpak (flutter/flutter#137123)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
9c75674 
…atpak (flutter/flutter#137123)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
ccccf03 
…atpak (flutter/flutter#137123)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
4bef127 
…atpak (flutter/flutter#137123)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
4c8de7d 
…atpak (flutter/flutter#137123)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
806068f 
…atpak (flutter/flutter#137123)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
dcdcc9d 
…atpak (flutter/flutter#137123)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
b2f8753 
…atpak (flutter/flutter#137123)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
5269104 
…atpak (flutter/flutter#137123)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
57ed164 
…atpak (flutter/flutter#137123)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
85f85be 
…atpak (flutter/flutter#137123)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
e6b900a 
…atpak (flutter/flutter#137123)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
cb71cf3 
…atpak (flutter/flutter#137123)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
920c481 
…atpak (flutter/flutter#137123)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
a9171d3 
…atpak (flutter/flutter#137123)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
d22b04e 
…atpak (flutter/flutter#137123)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
d9d7ba8 
…atpak (flutter/flutter#137123)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
01e1d8c 
…atpak (flutter/flutter#137123)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
77503bd Added support for vscode and vscode-insiders installed via Fl…
707c05b 
…atpak (flutter/flutter#137123)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkolos andrewkolos andrewkolos approved these changes
+1 more reviewer
@christopherfujino christopherfujino christopherfujino approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

VS Code installed via Flatpak is not detected by flutter tool

3 participants

@KristijanZic @christopherfujino @andrewkolos