Skip to content

Added vscode-insiders path installed via snap #137117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Dec 1, 2023
Merged

Added vscode-insiders path installed via snap #137117

auto-submit merged 2 commits into from
Dec 1, 2023

Conversation

@KristijanZic
Copy link
Contributor

@KristijanZic KristijanZic commented Oct 24, 2023

Closes #137116

Before
VS Code Insiders installed via Snap isn't detected.

After

[✓] VS Code (version 1.84.0-insider)
    • VS Code at /snap/code-insiders/current/usr/share/code-insiders
    • Flutter extension version 3.75.20231002

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 24, 2023
@KristijanZic KristijanZic changed the title Adding vscode-insiders path installed though snap Added vscode-insiders path installed via snap Oct 24, 2023
@eliasyishak
Copy link
Contributor

eliasyishak commented Nov 2, 2023

@DanTup does this look good to you from the VS Code side?

DanTup
DanTup approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@DanTup DanTup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I did wonder why the path is so different to the stable one, though I see that's being updated in #136997 so they'll match :-)

@christopherfujino christopherfujino self-requested a review November 10, 2023 23:18
@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 10, 2023
christopherfujino
christopherfujino approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 10, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Nov 10, 2023

auto label is removed for flutter/flutter/137117, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@navaronbracke navaronbracke mentioned this pull request Nov 26, 2023
Closed
2 tasks
@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 1, 2023
@auto-submit auto-submit bot merged commit cf71a55 into flutter:master Dec 1, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 2, 2023
@engine-flutter-autoroll
cf71a55 Added vscode-insiders path installed via snap (flutter/flutte…
87b1c8f 
…r#137117)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 2, 2023
@engine-flutter-autoroll
cf71a55 Added vscode-insiders path installed via snap (flutter/flutte…
a904bb6 
…r#137117)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 2, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 2, 2023
@engine-flutter-autoroll
cf71a55 Added vscode-insiders path installed via snap (flutter/flutte…
cfe523e 
…r#137117)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 2, 2023
@engine-flutter-autoroll
Roll Flutter from 918e336 to d861ce4 (29 revisions) (#5542)
5d9874f 
flutter/flutter@918e336...d861ce4

2023-12-02 [email protected] Roll Flutter Engine from f0122c32c5cc to cfabe42bc0c6 (1 revision) (flutter/flutter#139423)
2023-12-02 [email protected] Roll Flutter Engine from f23c33f3831c to f0122c32c5cc (1 revision) (flutter/flutter#139422)
2023-12-02 [email protected] Roll Flutter Engine from d441f087052c to f23c33f3831c (2 revisions) (flutter/flutter#139421)
2023-12-02 [email protected] Roll Flutter Engine from 27d37db84b8e to d441f087052c (1 revision) (flutter/flutter#139419)
2023-12-02 [email protected] Roll Flutter Engine from 5a9f33e3a41e to 27d37db84b8e (1 revision) (flutter/flutter#139418)
2023-12-02 [email protected] Roll Flutter Engine from 9f8502c4e255 to 5a9f33e3a41e (1 revision) (flutter/flutter#139416)
2023-12-02 [email protected] Roll Flutter Engine from 43a1598713bb to 9f8502c4e255 (1 revision) (flutter/flutter#139414)
2023-12-02 [email protected] Roll Flutter Engine from 039439c1ffe8 to 43a1598713bb (1 revision) (flutter/flutter#139412)
2023-12-02 [email protected] Roll Flutter Engine from 4d19fedb7617 to 039439c1ffe8 (1 revision) (flutter/flutter#139410)
2023-12-02 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Retry on transient Skia failure." (flutter/flutter#139407)
2023-12-01 [email protected] Roll Flutter Engine from 162ad29a576f to 4d19fedb7617 (1 revision) (flutter/flutter#139397)
2023-12-01 [email protected] [l10n] Update Material shareButtonLabel (flutter/flutter#138899)
2023-12-01 [email protected] Retry on transient Skia failure. (flutter/flutter#139182)
2023-12-01 [email protected] Roll Flutter Engine from 820cb686d17d to 162ad29a576f (1 revision) (flutter/flutter#139394)
2023-12-01 [email protected] Roll Flutter Engine from 00316e4b7680 to 820cb686d17d (2 revisions) (flutter/flutter#139390)
2023-12-01 [email protected] Roll Flutter Engine from 95995c48d591 to 00316e4b7680 (1 revision) (flutter/flutter#139389)
2023-12-01 [email protected] Roll Flutter Engine from 69f0e5550702 to 95995c48d591 (6 revisions) (flutter/flutter#139388)
2023-12-01 [email protected] Added vscode-insiders path installed via snap (flutter/flutter#137117)
2023-12-01 [email protected] Typo fix in dartdoc in tool test (flutter/flutter#139386)
2023-12-01 [email protected] Roll Flutter Engine from 51ef7642750f to 69f0e5550702 (1 revision) (flutter/flutter#139348)
2023-12-01 [email protected] Roll Flutter Engine from 894360cca1ec to 51ef7642750f (1 revision) (flutter/flutter#139346)
2023-12-01 [email protected] Roll Flutter Engine from c26e6ced11df to 894360cca1ec (1 revision) (flutter/flutter#139345)
2023-12-01 [email protected] Roll Flutter Engine from 74d2df52514a to c26e6ced11df (26 revisions) (flutter/flutter#139342)
2023-12-01 [email protected] Roll Flutter Engine from 35939ca8534f to 74d2df52514a (1 revision) (flutter/flutter#139264)
2023-11-30 [email protected] Add `undoStackModifier` to `UndoHistory` (flutter/flutter#138674)
2023-11-30 [email protected] Migrate docs_test to shard. (flutter/flutter#139282)
2023-11-30 [email protected] Write Tests for API Examples of `cupertino_text_field.0`, `data_table.0`, `icon_button.2` & `ink_well.0` (flutter/flutter#139258)
2023-11-30 [email protected] Refactor prepare_package.dart (flutter/flutter#139277)
2023-11-30 [email protected] Roll Packages from e4aaba8 to bc72d15 (4 revisions) (flutter/flutter#139307)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
caseycrogers pushed a commit to caseycrogers/flutter that referenced this pull request Dec 29, 2023
@KristijanZic @caseycrogers
Added vscode-insiders path installed via snap (flutter#137117)
a05671a 
Closes  flutter#137116

<b>Before</b>
VS Code Insiders installed via Snap isn't detected.

<b>After</b>
```sh
[�] VS Code (version 1.84.0-insider)
    � VS Code at /snap/code-insiders/current/usr/share/code-insiders
    � Flutter extension version 3.75.20231002
```
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
cf71a55 Added vscode-insiders path installed via snap (flutter/flutte…
4fa43bb 
…r#137117)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DanTup DanTup DanTup approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

VS Code Insiders installed via Snap is not detected by flutter tool

4 participants

@KristijanZic @eliasyishak @DanTup @christopherfujino