Skip to content

CustomPainterSemantics doc typo #137081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Oct 23, 2023
Merged

CustomPainterSemantics doc typo #137081

auto-submit merged 1 commit into from
Oct 23, 2023

Conversation

@EnduringBeta
Copy link
Contributor

@EnduringBeta EnduringBeta commented Oct 23, 2023 •
edited
Loading

Just a documentation typo, I think.

#137080

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 23, 2023
goderbauer
goderbauer approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 23, 2023
@auto-submit auto-submit bot merged commit 57a20ef into flutter:master Oct 23, 2023
@EnduringBeta EnduringBeta deleted the patch-1 branch October 23, 2023 20:54
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 24, 2023
@engine-flutter-autoroll
57a20ef CustomPainterSemantics doc typo (flutter/flutter#137081)
e396eb5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 24, 2023
@engine-flutter-autoroll
57a20ef CustomPainterSemantics doc typo (flutter/flutter#137081)
ee7f98c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 24, 2023
@engine-flutter-autoroll
57a20ef CustomPainterSemantics doc typo (flutter/flutter#137081)
a1d3e48
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2023
@engine-flutter-autoroll
57a20ef CustomPainterSemantics doc typo (flutter/flutter#137081)
81dfa8a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2023
@engine-flutter-autoroll
57a20ef CustomPainterSemantics doc typo (flutter/flutter#137081)
9f22cb0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2023
@engine-flutter-autoroll
57a20ef CustomPainterSemantics doc typo (flutter/flutter#137081)
26457ce
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2023
@engine-flutter-autoroll
57a20ef CustomPainterSemantics doc typo (flutter/flutter#137081)
c2f1ffb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EnduringBeta @goderbauer @jonahwilliams