Cover text_selection tests with leak tracking. [prod-leak-fix] #137009

ksokolovskyi · 2023-10-21T11:42:06Z

Description

This PR changes testWidgets by testWidgetsWithLeakTracking in number of flutter/test/widgets tests according to the Clean up notDisposed leaks in Flutter Framework, phase 1. dart-lang/leak_tracker#134.
Fixes leak in RenderEditable.

Tests

Updates widgets/text_selection_test.dart to use testWidgetsWithLeakTracking;
Updates widgets/text_selection_toolbar_layout_delegate_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

…nderEditable

ksokolovskyi · 2023-10-21T12:13:56Z

cc @polina-c

polina-c · 2023-10-23T21:29:41Z

packages/flutter/lib/src/rendering/editable.dart

    _selectionPainter.dispose();
    _caretPainter.dispose();
    _textPainter.dispose();
+    _internalShowCursor?.dispose();


There is set showCursor(ValueNotifier<bool> value) {. It makes things little more complicated. Should the setter dispose previous value?
Instead of creating new member _internalShowCursor, should we create flag _disposeShowCursor and update it every time _showCursor is assigned?

@polina-c, thanks for the review.
I see what you mean, but we need to care only about the first internal ValueNotifier, which gets created on RenderEditable creation if showCursor is not passed. All next showCursor ValueNotifiers will be set using a setter, and their disposal is not our responsibility.
Am I missing something?)

True, however, if setter is invoked, should we dispose the previous value right away and null out all references to it, without waiting for disposal of the entire class?

@polina-c great thought!
Will do it that way, thanks :)

…7385) Relands flutter#136851, which was rolled back in flutter#137121 package:coverage has been rolled, so the breakages should be fixed. Also, in this reland I've changed the `coverableLineCache` parameter to be optional, which is safer.

…e signing (flutter#136978) Fixes flutter#136984

…tions (flutter#136672) Help to debug situations like: flutter#135982

Fixes flutter#136593 Caching of the base url was introduced in flutter#53666 but resources can contain multiple `index.html` files, and currently hash of the **latest** asset will be assigned to the base url, which is not necessarily the root index.html

…sions) (flutter#137570) Manual roll requested by [email protected] flutter/engine@84dcb4f...4f87c20 2023-10-30 [email protected] Roll Dart SDK from 5a666e8d8259 to 85e149f894df (6 revisions) (flutter/engine#47470) 2023-10-30 [email protected] [deps] Stop moving NDK folder inside Android SDK (flutter/engine#47454) 2023-10-30 [email protected] Revert "[Impeller] remove image upload workarounds." (flutter/engine#47402) 2023-10-30 [email protected] Roll Skia from 89250a0bd6bb to 817fca468240 (3 revisions) (flutter/engine#47465) 2023-10-30 [email protected] Roll Skia from 006424658682 to 89250a0bd6bb (3 revisions) (flutter/engine#47463) 2023-10-30 [email protected] Migrate inja, sqlite, libtess2 to //flutter/third_party. (flutter/engine#47408) 2023-10-30 [email protected] Revert "Roll Dart SDK from 5a666e8d8259 to 38e8459ca2aa (4 revisions)" (flutter/engine#47459) 2023-10-30 [email protected] Roll Skia from 09818d8c9d3c to 006424658682 (1 revision) (flutter/engine#47458) 2023-10-30 [email protected] Roll Skia from 6e9cd1b79105 to 09818d8c9d3c (1 revision) (flutter/engine#47456) 2023-10-30 [email protected] Remove call to SkTypeface::MakeDefault (flutter/engine#47344) 2023-10-30 [email protected] Roll Fuchsia Linux SDK from LbIVijDVwcB56_wgv... to zf2xLsbeoVrbnEDiH... (flutter/engine#47452) 2023-10-30 [email protected] Roll Skia from c732ec7f5d74 to 6e9cd1b79105 (2 revisions) (flutter/engine#47451) 2023-10-30 [email protected] Roll Skia from e45946f89a8b to c732ec7f5d74 (2 revisions) (flutter/engine#47448) 2023-10-30 [email protected] Roll Fuchsia Mac SDK from OJfJYAvhpAkE-kvbY... to jCjz-imbNBDjiRVa1... (flutter/engine#47447) 2023-10-30 [email protected] Roll Skia from 7545d1468268 to e45946f89a8b (1 revision) (flutter/engine#47446) 2023-10-29 [email protected] Roll Skia from e224e1dc5e2c to 7545d1468268 (1 revision) (flutter/engine#47444) 2023-10-29 [email protected] Roll Fuchsia Linux SDK from v-9_Di17lm_C_mrpZ... to LbIVijDVwcB56_wgv... (flutter/engine#47443) 2023-10-29 [email protected] Roll Fuchsia Mac SDK from s0pbwY5MGxyq0tNrT... to OJfJYAvhpAkE-kvbY... (flutter/engine#47439) 2023-10-29 [email protected] Roll Skia from d29cc3fe182f to e224e1dc5e2c (1 revision) (flutter/engine#47438) 2023-10-29 [email protected] Roll Fuchsia Linux SDK from nreLekedxzmcdb3ww... to v-9_Di17lm_C_mrpZ... (flutter/engine#47436) 2023-10-29 [email protected] Roll Fuchsia Mac SDK from qiHQ7aarDQb_1Rq3G... to s0pbwY5MGxyq0tNrT... (flutter/engine#47431) 2023-10-28 [email protected] Roll Fuchsia Linux SDK from ESkamdoXWIwkdWdP-... to nreLekedxzmcdb3ww... (flutter/engine#47429) 2023-10-28 [email protected] Roll Fuchsia Mac SDK from 9YSl2rN0sj5YpYNdQ... to qiHQ7aarDQb_1Rq3G... (flutter/engine#47428) 2023-10-28 [email protected] Roll Dart SDK from 5a666e8d8259 to 38e8459ca2aa (4 revisions) (flutter/engine#47426) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from ESkamdoXWIwk to zf2xLsbeoVrb fuchsia/sdk/core/mac-amd64 from 9YSl2rN0sj5Y to jCjz-imbNBDj If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#137582) flutter/engine@4f87c20...64b0e07 2023-10-30 [email protected] Roll Fuchsia Mac SDK from jCjz-imbNBDjiRVa1... to sBjtpAHoetjF77qxg... (flutter/engine#47482) 2023-10-30 [email protected] Roll Dart SDK from 85e149f894df to c8f75afabaf1 (1 revision) (flutter/engine#47479) 2023-10-30 [email protected] Update package:equatable pin (flutter/engine#47475) 2023-10-30 [email protected] [Impeller] Switch from `glBlitFramebuffer` to implicit MSAA resolution. (flutter/engine#47282) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from jCjz-imbNBDj to sBjtpAHoetjF If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#137584) flutter/engine@64b0e07...44309c9 2023-10-30 [email protected] Roll Fuchsia Linux SDK from zf2xLsbeoVrbnEDiH... to 0D7msIyC3p_BdEY03... (flutter/engine#47490) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from zf2xLsbeoVrb to 0D7msIyC3p_B If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#137587) flutter/engine@44309c9...17eff7a 2023-10-31 [email protected] Roll Dart SDK from c8f75afabaf1 to 9cc76cb23b8c (1 revision) (flutter/engine#47498) 2023-10-30 [email protected] [macOS] Wrap external texture tests in autorelease pool (flutter/engine#47492) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#137594) flutter/engine@17eff7a...b4de734 2023-10-31 [email protected] Roll Dart SDK from 9cc76cb23b8c to 2a80a8adf898 (1 revision) (flutter/engine#47501) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#137610) flutter/engine@b4de734...5ca5cbb 2023-10-31 [email protected] Roll Fuchsia Mac SDK from sBjtpAHoetjF77qxg... to rg_Ici1tgAVF93cn9... (flutter/engine#47502) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from sBjtpAHoetjF to rg_Ici1tgAVF If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#137612) flutter/engine@5ca5cbb...11a569d 2023-10-31 [email protected] Roll Fuchsia Linux SDK from 0D7msIyC3p_BdEY03... to LCfhx_lTRJI51G0zc... (flutter/engine#47503) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 0D7msIyC3p_B to LCfhx_lTRJI5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Badly formatted code causes distraction when reading, and costs people energy when understanding code.

…lutter#137617) flutter/engine@11a569d...6b9b806 2023-10-31 [email protected] Roll Dart SDK from 2a80a8adf898 to 776fad25647a (1 revision) (flutter/engine#47505) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

If the benchmark runs out of time before it closes the drawer it is animating, it tries to divide by zero when computing the time per frame. Don't report time per frame for activities with zero frames. This likely only happens for the close frame action, but guards are added to all time per frame computations in this benchmark.

flutter/packages@2af6954...c9fec61 2023-10-31 [email protected] [image_picker] Prevent multiple active calls on iOS (flutter/packages#5272) 2023-10-30 [email protected] [in_app_purchase_android] Add missing response code to BillingResponse enum (flutter/packages#5120) 2023-10-30 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.4 to 2.22.5 (flutter/packages#5263) 2023-10-30 [email protected] Bump play-service-maps dependency from version 18.1.0 to 18.2.0 (flutter/packages#5243) 2023-10-30 [email protected] Roll Flutter from a4ec627 to e12d1a7 (3 revisions) (flutter/packages#5267) 2023-10-30 [email protected] [camerax] Loosen restrictions of fallback strategies for choosing resolutions (flutter/packages#5239) 2023-10-30 [email protected] [pigeon] Don't wrap non-nullable primitives in Obj-C (flutter/packages#5214) 2023-10-30 [email protected] [flutter_lints] Replace "flutter pub add --dev" with "dev:" (flutter/packages#5260) 2023-10-28 [email protected] Roll Flutter from 5907c97 to a4ec627 (18 revisions) (flutter/packages#5255) 2023-10-27 [email protected] [go_router] Fixes deep-link with no path on cold start (flutter/packages#5113) 2023-10-27 [email protected] [two_dimensional_scrollables] Fix pinned row painting when one axis is reversed (flutter/packages#5187) 2023-10-27 [email protected] Roll Flutter from c555599 to 5907c97 (45 revisions) (flutter/packages#5252) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#137624) flutter/engine@6b9b806...9de8146 2023-10-31 [email protected] Roll Skia from 817fca468240 to 40223641388b (19 revisions) (flutter/engine#47507) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#137626) flutter/engine@9de8146...47465eb 2023-10-31 [email protected] Roll Skia from 40223641388b to 065f0d2302ca (2 revisions) (flutter/engine#47509) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

## Description This PR fixes typos in - `date_picker.dart` - `date_picker_theme.dart` - `dropdown.dart`

…lutter#137632) flutter/engine@47465eb...4da3e5b 2023-10-31 [email protected] Bump goldctl (flutter/engine#47391) 2023-10-31 [email protected] Roll Skia from 065f0d2302ca to b3360479118f (4 revisions) (flutter/engine#47510) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…rastLight`, & `ColorScheme.highContrastDark` constructors docs for Material 3 (flutter#137149) fixes [Clarify ColorScheme fromSwatch/fromSeed usage](flutter#132584) "This explains how to use `ColorScheme.fromSeed` as a substitute for each `ColorScheme` constructor." | `ColorScheme.light` (left) to `ColorScheme.fromSeed` (right) | | --------------- | | ![light](https://github.com/flutter/flutter/assets/48603081/e056e723-5640-4b05-8feb-ca6b517c8682) | | `ColorScheme.dark` (left) to `ColorScheme.fromSeed` (right) | | --------------- | | ![dark](https://github.com/flutter/flutter/assets/48603081/5ff32611-bfb6-49ee-a34e-f935f580e84e) | | `ColorScheme.highContrastLight` (left) to `ColorScheme.fromSeed` (right) | | --------------- | | ![highContrastLight](https://github.com/flutter/flutter/assets/48603081/4b47f2e3-ea8e-4148-85cc-69690e9082c7) | | `ColorScheme.highContrastDark` (left) to `ColorScheme.fromSeed` (right) | | --------------- | | ![highContrastDark](https://github.com/flutter/flutter/assets/48603081/3dbd7ec4-c78e-4228-a8ed-673832681563) |

…lutter#137635) flutter/engine@4da3e5b...39be0fc 2023-10-31 [email protected] [Impeller] OpenGLES MSAA Render Buffers (i.e. for stencils) (flutter/engine#47495) 2023-10-31 [email protected] [Impeller] Migrate unit tests to named Rect factories (flutter/engine#47430) 2023-10-31 [email protected] [Typo fixed] in DEPS (flutter/engine#47440) 2023-10-31 [email protected] [Impeller] Restore GLES GPU query times. (flutter/engine#47511) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

polina-c · 2023-11-03T15:25:13Z

packages/flutter/lib/src/rendering/editable.dart

      _showHideCursor();
      _showCursor.addListener(_showHideCursor);
    }
+    _internalShowCursor?.dispose();


The only goal of this field is to dispose cursor.
So, the name _internalShowCursor does not describe the meaning.
Also, as it is separate from _showCursor it is not very clear when the field should be disposed.

So, I still suggest to have a flag like _disposeShowCursor, and then it is clear that current value of _showCursor should be disposed if it is not needed any more.

How does it sound?

@polina-c, thanks for the review!
I totally agree with you, _disposeShowCursor is self-explanatory.

ksokolovskyi · 2023-11-07T13:12:03Z

@polina-c, thanks a lot for the review!

…er#137009)

flutter/flutter@f5a9835...5a6a322 2023-11-07 [email protected] Roll Packages from 49eac1f to be18d28 (3 revisions) (flutter/flutter#137999) 2023-11-07 [email protected] Roll Flutter Engine from b1f2581f05e3 to b91400976b4a (2 revisions) (flutter/flutter#138000) 2023-11-07 [email protected] Roll Flutter Engine from 633065f75b1c to b1f2581f05e3 (1 revision) (flutter/flutter#137997) 2023-11-07 [email protected] Roll Flutter Engine from 99149d59cb3d to 633065f75b1c (1 revision) (flutter/flutter#137996) 2023-11-07 [email protected] Roll Flutter Engine from 7f4d56a7f4f7 to 99149d59cb3d (1 revision) (flutter/flutter#137987) 2023-11-07 [email protected] Roll Flutter Engine from f9f822359f2b to 7f4d56a7f4f7 (1 revision) (flutter/flutter#137983) 2023-11-07 [email protected] Roll Flutter Engine from b1a5d772792f to f9f822359f2b (1 revision) (flutter/flutter#137980) 2023-11-07 [email protected] Roll Flutter Engine from 461d815b48a0 to b1a5d772792f (13 revisions) (flutter/flutter#137979) 2023-11-07 [email protected] Roll Flutter Engine from bdfa8aa8f81f to 461d815b48a0 (1 revision) (flutter/flutter#137944) 2023-11-06 [email protected] SemanticsHandle should dispatch creation and disposal events. (flutter/flutter#137960) 2023-11-06 [email protected] ScrollActivity should dispatch creation and disposal events. (flutter/flutter#137961) 2023-11-06 [email protected] Cover text_selection tests with leak tracking. (flutter/flutter#137009) 2023-11-06 [email protected] Roll pub packages (flutter/flutter#137862) 2023-11-06 [email protected] Migration for `HotEvent` for Flutter hot runner (flutter/flutter#137717) 2023-11-06 [email protected] [benchmarks] disable partial repaint for multiple backdrop blur iOS macrobenchmarks. (flutter/flutter#137902) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…er#137009)

Update text_selection_test.dart with leak tracking and fix leak in Re…

6d8fcb5

…nderEditable

github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Oct 21, 2023

Merge branch 'master' into text-selection-leak-tracking

05aeff6

polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Oct 23, 2023

polina-c reviewed Oct 23, 2023

View reviewed changes

ksokolovskyi added 2 commits October 25, 2023 18:44

Fix

0a68e1f

Merge branch 'master' into text-selection-leak-tracking

ac5e8f3

ksokolovskyi requested a review from polina-c October 25, 2023 16:50

ksokolovskyi and others added 20 commits October 26, 2023 16:14

Merge branch 'master' into text-selection-leak-tracking

e3f638a

Removed leakTrackingTestConfig

6e8a0e6

Merge branch 'master' into text-selection-leak-tracking

1348ec2

Merge branch 'master' into text-selection-leak-tracking

5f08582

Merge branch 'master' into text-selection-leak-tracking

03c606b

[flutter_tool] change print when selecting developer identity for cod…

3b3c14d

…e signing (flutter#136978) Fixes flutter#136984

[flutter_tools] ensure processUtils reports exit code in ProcessExcep…

748fce2

…tions (flutter#136672) Help to debug situations like: flutter#135982

Fix formatting (flutter#137613)

4d47708

Badly formatted code causes distraction when reading, and costs people energy when understanding code.

engine-flutter-autoroll and others added 8 commits October 31, 2023 22:20

Fix. typos (flutter#137465)

1c05cf8

## Description This PR fixes typos in - `date_picker.dart` - `date_picker_theme.dart` - `dropdown.dart`

Merge branch 'master' into text-selection-leak-tracking

914670d

Merge branch 'master' into text-selection-leak-tracking

6cfffaa

polina-c reviewed Nov 3, 2023

View reviewed changes

Fix

51eb3f3

ksokolovskyi requested a review from polina-c November 3, 2023 17:31

Merge branch 'master' into text-selection-leak-tracking

06d339e

polina-c approved these changes Nov 6, 2023

View reviewed changes

polina-c merged commit 2d9a075 into flutter:master Nov 6, 2023

engine-flutter-autoroll mentioned this pull request Nov 7, 2023

Roll Flutter from f5a983535131 to 1b63c299463a (12 revisions) flutter/packages#5343

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 7, 2023

2d9a075 Cover text_selection tests with leak tracking. (flutter/flutt…

1e92ca8

…er#137009)

engine-flutter-autoroll mentioned this pull request Nov 7, 2023

Roll Flutter from f5a983535131 to c1d11b1d5b25 (13 revisions) flutter/packages#5344

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 7, 2023

2d9a075 Cover text_selection tests with leak tracking. (flutter/flutt…

ce3574d

…er#137009)

engine-flutter-autoroll mentioned this pull request Nov 7, 2023

Roll Flutter from f5a983535131 to 5a6a3224fe15 (15 revisions) flutter/packages#5345

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 7, 2023

2d9a075 Cover text_selection tests with leak tracking. (flutter/flutt…

019df87

…er#137009)

HansMuller mentioned this pull request Nov 10, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024

2d9a075 Cover text_selection tests with leak tracking. (flutter/flutt…

5f9f71f

…er#137009)

polina-c changed the title ~~Cover text_selection tests with leak tracking.~~ Cover text_selection tests with leak tracking. [prod-leak-fix] Aug 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Cover text_selection tests with leak tracking. [prod-leak-fix] #137009

Cover text_selection tests with leak tracking. [prod-leak-fix] #137009

Uh oh!

ksokolovskyi commented Oct 21, 2023

Uh oh!

ksokolovskyi commented Oct 21, 2023

Uh oh!

polina-c Oct 23, 2023

Uh oh!

ksokolovskyi Oct 24, 2023

Uh oh!

polina-c Oct 24, 2023

Uh oh!

ksokolovskyi Oct 24, 2023

Uh oh!

polina-c Nov 3, 2023

Uh oh!

ksokolovskyi Nov 3, 2023

Uh oh!

ksokolovskyi commented Nov 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Cover text_selection tests with leak tracking. [prod-leak-fix] #137009

Cover text_selection tests with leak tracking. [prod-leak-fix] #137009

Uh oh!

Conversation

ksokolovskyi commented Oct 21, 2023

Description

Tests

Pre-launch Checklist

Uh oh!

ksokolovskyi commented Oct 21, 2023

Uh oh!

polina-c Oct 23, 2023

Choose a reason for hiding this comment

Uh oh!

ksokolovskyi Oct 24, 2023

Choose a reason for hiding this comment

Uh oh!

polina-c Oct 24, 2023

Choose a reason for hiding this comment

Uh oh!

ksokolovskyi Oct 24, 2023

Choose a reason for hiding this comment

Uh oh!

polina-c Nov 3, 2023

Choose a reason for hiding this comment

Uh oh!

ksokolovskyi Nov 3, 2023

Choose a reason for hiding this comment

Uh oh!

ksokolovskyi commented Nov 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants