[Impeller] add OpenGL GPU tracing to devicelab tests. #136974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
Oct 20, 2023
Member
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
Code looks good. Are we sure we want this since devicelabs are often interpreted as benchmarks? Seems like this could interfere with those numbers?
Contributor
Author
|
I'm not sure I understand your point. We want to measure GPU performance in our benchmarks |
Member
With the name "trace" I thought this was related to the logging work that was discussed elsewhere, not measurement. |
Contributor
Author
|
Oh sorry, this is addition of GPU frame time measurements that we've already done for metal and vulkan. The OpenGLES APIs we use for these are crashy though, so its off by default for users. |
jonahwilliams
added
the
autosubmit
chinmaygarde
added
the
e: impeller
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 21, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 21, 2023
flutter/flutter@0883cb2...6f4850d 2023-10-21 [email protected] Roll Flutter Engine from a12116df3859 to 11f87dce1017 (1 revision) (flutter/flutter#137017) 2023-10-21 [email protected] Roll Flutter Engine from 755c477c96e7 to a12116df3859 (1 revision) (flutter/flutter#137013) 2023-10-21 [email protected] Roll Flutter Engine from 4f9f4013c3b3 to 755c477c96e7 (1 revision) (flutter/flutter#137008) 2023-10-21 [email protected] Test cover painting for memory leaks (flutter/flutter#136696) 2023-10-21 [email protected] Roll Flutter Engine from 2e5fb647a76f to 4f9f4013c3b3 (2 revisions) (flutter/flutter#136999) 2023-10-21 [email protected] Roll Flutter Engine from e4fc0c4e2b97 to 2e5fb647a76f (3 revisions) (flutter/flutter#136995) 2023-10-21 [email protected] Roll Flutter Engine from 9796817fb6e2 to e4fc0c4e2b97 (1 revision) (flutter/flutter#136993) 2023-10-20 [email protected] Roll Flutter Engine from 4a65910f0ab2 to 9796817fb6e2 (2 revisions) (flutter/flutter#136990) 2023-10-20 [email protected] Adds more a11y use cases (flutter/flutter#136761) 2023-10-20 [email protected] Reland "Use Layer.toImage for golden tests on CanvasKit" (flutter/flutter#136918) 2023-10-20 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.3 to 2.22.4 (flutter/flutter#136985) 2023-10-20 [email protected] Add missing call to parent method of GApplication::shutdown, implement GApplication::startup (flutter/flutter#136836) 2023-10-20 [email protected] Roll Flutter Engine from b27e1b38375b to 4a65910f0ab2 (5 revisions) (flutter/flutter#136987) 2023-10-20 [email protected] Bump dartdoc to 7.0.1 and clean-up (flutter/flutter#136975) 2023-10-20 [email protected] RenderEditable WidgetSpan intrinsics (flutter/flutter#136979) 2023-10-20 [email protected] Roll Flutter Engine from d46933e6772e to b27e1b38375b (9 revisions) (flutter/flutter#136982) 2023-10-20 [email protected] Roll pub packages (flutter/flutter#136924) 2023-10-20 [email protected] [docs] Expand categories for automated release notes (flutter/flutter#136967) 2023-10-20 [email protected] Roll Flutter Engine from 21b5c3771ee1 to d46933e6772e (3 revisions) (flutter/flutter#136973) 2023-10-20 [email protected] [Impeller] add OpenGL GPU tracing to devicelab tests. (flutter/flutter#136974) 2023-10-20 [email protected] Roll Flutter Engine from f9d1dbc39f4c to 21b5c3771ee1 (1 revision) (flutter/flutter#136969) 2023-10-20 [email protected] Default `NativeAssets` Darwin and IOS target archs if missing (flutter/flutter#136948) 2023-10-20 [email protected] Roll Flutter Engine from 6d1e9eec0841 to f9d1dbc39f4c (1 revision) (flutter/flutter#136966) 2023-10-20 [email protected] Roll Flutter Engine from 9b88ff83fd82 to 6d1e9eec0841 (2 revisions) (flutter/flutter#136965) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the metadata key required to enable OpenGLES GPU tracing. This is off by default because the API crashes on some GPU models, but it should be safe on the Pixel 7 (others TBD based on testing results).