[flutter_tools] toolexit when using plugins with preview device #136936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
christopherfujino
force-pushed
the
tool-exit-on-preview-plugins
branch
from
ffef6d1 to
4090221
Compare
| : fileSystem.directory(nameOrPath); | ||
| packagesFile.writeAsStringSync( | ||
| '$name:file://${pluginDirectory.childFile('lib').uri}\n', | ||
| '$name:${pluginDirectory.childFile('lib').uri}\n', |
Contributor
Author
There was a problem hiding this comment.
this was a pre-existing bug that apparently didn't affect any of the existing test results (but did affect my new test). calling pluginDirectory.childFile('lib').uri already has the file:// prefix, so we were getting strings with file://file://
8 tasks
Co-authored-by: Elias Yishak <[email protected]>
christopherfujino
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 8, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 8, 2023
flutter/flutter@5a6a322...4b4a1fe 2023-11-08 [email protected] Roll Flutter Engine from 117d47aa3f88 to b0310da3254d (1 revision) (flutter/flutter#138096) 2023-11-08 [email protected] Run a couple of iOS tests in presubmit (flutter/flutter#138089) 2023-11-08 [email protected] Roll Flutter Engine from 3e3be5e33bda to 117d47aa3f88 (20 revisions) (flutter/flutter#138091) 2023-11-08 [email protected] Roll Packages from be18d28 to 94c7623 (6 revisions) (flutter/flutter#138086) 2023-11-08 [email protected] Ticker should dispatch creation and disposal events. (flutter/flutter#137844) 2023-11-08 [email protected] [flutter_tools] Fix local engine preview device (flutter/flutter#138046) 2023-11-07 [email protected] Revert "Add no-shuffle to reorderable_list_test.dart" (flutter/flutter#137715) 2023-11-07 [email protected] Document where `Curves` curves correspond to CSS easing functions (flutter/flutter#137318) 2023-11-07 [email protected] Roll Flutter Engine from f8961d203039 to 3e3be5e33bda (1 revision) (flutter/flutter#138039) 2023-11-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use no-response from cocoon." (flutter/flutter#138042) 2023-11-07 [email protected] Use no-response from cocoon. (flutter/flutter#138037) 2023-11-07 [email protected] Roll Flutter Engine from 1b20752e2a63 to f8961d203039 (6 revisions) (flutter/flutter#138034) 2023-11-07 [email protected] Added an AnimationController API doc example (flutter/flutter#137975) 2023-11-07 [email protected] [flutter_tools] toolexit when using plugins with preview device (flutter/flutter#136936) 2023-11-07 [email protected] Roll Flutter Engine from 38895fbd9468 to 1b20752e2a63 (1 revision) (flutter/flutter#138020) 2023-11-07 [email protected] Roll Flutter Engine from a9e0f9514f78 to 38895fbd9468 (1 revision) (flutter/flutter#138016) 2023-11-07 [email protected] Move Skia new_gallery_transition_perf on a02 from staging to prod (flutter/flutter#138013) 2023-11-07 [email protected] Adaptive `Switch` (flutter/flutter#130425) 2023-11-07 [email protected] Roll Flutter Engine from e2810f07abb5 to a9e0f9514f78 (1 revision) (flutter/flutter#138005) 2023-11-07 [email protected] Roll Flutter Engine from b91400976b4a to e2810f07abb5 (1 revision) (flutter/flutter#138002) 2023-11-07 [email protected] [native assets] Tool exit on build failure (flutter/flutter#137995) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #130277
Without this, if a user runs an app that has plugins that call method channels with the
previewdevice, the app will build successfully, however, they will get a runtime error when their dart code tries to call the method channel that does not exist in the native build (which was pre-built and thus does not include the plugin code).This change adds a validation when injecting plugins that will tool exit if the device-id is
previewand their project contains plugins with method channels.