Reland "Fixes ability to call nextFocus() on a node to focus its desc… #136898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endant" (flutter#136894)" This reverts commit c2bd2c1.
github-actions
bot
added
framework
chunhtai
added
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/136898, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 23, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 23, 2023
flutter/flutter@823e083...5e8b5f4 2023-10-23 [email protected] Update `ColorScheme.fromSwatch` docs for Material 3 (flutter/flutter#136816) 2023-10-23 [email protected] Reland "Fixes ability to call nextFocus() on a node to focus its desc� (flutter/flutter#136898) 2023-10-23 [email protected] `OverlayPortal.overlayChild` contributes semantics to `OverlayPortal` instead of `Overlay` (flutter/flutter#134921) 2023-10-23 [email protected] Roll Packages from be915be to 4bf5114 (12 revisions) (flutter/flutter#137062) 2023-10-23 [email protected] Roll Flutter Engine from 8820a419c800 to 1dc66e8f2fba (1 revision) (flutter/flutter#137055) 2023-10-23 [email protected] Roll Flutter Engine from e2abdeb650f8 to 8820a419c800 (1 revision) (flutter/flutter#137051) 2023-10-23 [email protected] Roll Flutter Engine from 39f78ce1884d to e2abdeb650f8 (1 revision) (flutter/flutter#137050) 2023-10-23 [email protected] Roll Flutter Engine from 4899344c34d9 to 39f78ce1884d (1 revision) (flutter/flutter#137048) 2023-10-23 [email protected] Roll Flutter Engine from 9d05b061e245 to 4899344c34d9 (1 revision) (flutter/flutter#137046) 2023-10-23 [email protected] Roll Flutter Engine from cde34b8182b1 to 9d05b061e245 (1 revision) (flutter/flutter#137044) 2023-10-22 [email protected] Add timeline events for post frame callbacks (flutter/flutter#136435) 2023-10-22 [email protected] Roll Flutter Engine from b8d702c0e0d7 to cde34b8182b1 (1 revision) (flutter/flutter#137038) 2023-10-22 [email protected] Roll Flutter Engine from f3c7a50bc83f to b8d702c0e0d7 (1 revision) (flutter/flutter#137035) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
Oct 31, 2023
flutter#136898) �endant" (flutter#136894)" This reverts commit c2bd2c1. fixes flutter#134854 This is a straight reland, the internal test is testing a wrong behave. https://critique.corp.google.com/cl/575028981
chunhtai
added a commit
to chunhtai/flutter
that referenced
this pull request
Nov 7, 2023
flutter#136898) �endant" (flutter#136894)" This reverts commit c2bd2c1. fixes flutter#134854 This is a straight reland, the internal test is testing a wrong behave. https://critique.corp.google.com/cl/575028981
XilaiZhang
pushed a commit
to XilaiZhang/flutter
that referenced
this pull request
Nov 7, 2023
flutter#136898) �endant" (flutter#136894)" This reverts commit c2bd2c1. fixes flutter#134854 This is a straight reland, the internal test is testing a wrong behave. https://critique.corp.google.com/cl/575028981
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…endant" (#136894)"
This reverts commit c2bd2c1.
fixes #134854
This is a straight reland, the internal test is testing a wrong behave. https://critique.corp.google.com/cl/575028981
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.