[Reland] Skip injecting Bonjour settings when port publication is disabled #136842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform-ios
Contributor
Author
|
@christopherfujino I had to revert again due to merging issues (#135639 changed the I updated the tests in The tests that failed: |
christopherfujino
approved these changes
Oct 19, 2023
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM, third time's the charm!
vashworth
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 20, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 20, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 20, 2023
flutter/flutter@c2bd2c1...0883cb2 2023-10-20 [email protected] Roll Packages from 09c6b11 to be915be (6 revisions) (flutter/flutter#136964) 2023-10-20 [email protected] Roll Flutter Engine from de780872533c to 9b88ff83fd82 (4 revisions) (flutter/flutter#136959) 2023-10-20 [email protected] Roll Flutter Engine from 1e107c21328a to de780872533c (1 revision) (flutter/flutter#136952) 2023-10-20 [email protected] Roll Flutter Engine from fd33e7e75eac to 1e107c21328a (1 revision) (flutter/flutter#136949) 2023-10-20 [email protected] Roll Flutter Engine from 9dd59f7fcff9 to fd33e7e75eac (1 revision) (flutter/flutter#136942) 2023-10-20 [email protected] Roll Flutter Engine from cc3356c0e68f to 9dd59f7fcff9 (1 revision) (flutter/flutter#136935) 2023-10-20 [email protected] Roll Flutter Engine from 504a99d93f42 to cc3356c0e68f (2 revisions) (flutter/flutter#136934) 2023-10-19 [email protected] Roll Flutter Engine from 503b84295462 to 504a99d93f42 (3 revisions) (flutter/flutter#136930) 2023-10-19 [email protected] Roll Flutter Engine from 3b0469b0c718 to 503b84295462 (1 revision) (flutter/flutter#136928) 2023-10-19 [email protected] Revert "[Velocity Tracker] Fix: Issue 97761: Flutter Scrolling does not match iOS; inadvertent scrolling when user lifts up finger" (flutter/flutter#136905) 2023-10-19 [email protected] [flutter_tools] move build_preview_test from commands/permeable to integration shard (flutter/flutter#136912) 2023-10-19 [email protected] Roll Flutter Engine from b40042ebb95b to 3b0469b0c718 (2 revisions) (flutter/flutter#136922) 2023-10-19 [email protected] do not include entries from `--dart-define-from-file` files in the gradle config or environment during build (flutter/flutter#136865) 2023-10-19 [email protected] Roll Flutter Engine from bfd2ffb9a8bc to b40042ebb95b (2 revisions) (flutter/flutter#136915) 2023-10-19 [email protected] Roll Flutter Engine from 9d49175618f5 to bfd2ffb9a8bc (2 revisions) (flutter/flutter#136910) 2023-10-19 [email protected] Allow users to customize search algorithm in `DropdownMenu` (flutter/flutter#136848) 2023-10-19 [email protected] Upgrade Flutter deps to pull in latest vm_service and dwds (flutter/flutter#136734) 2023-10-19 [email protected] [Reland] Skip injecting Bonjour settings when port publication is disabled (flutter/flutter#136842) 2023-10-19 [email protected] _DefaultTabControllerState should dispose all created TabContoller instances. (flutter/flutter#136608) 2023-10-19 [email protected] Reland: "Add code for updating `focusedChild` when removing grandchildren from scope" (flutter/flutter#136899) 2023-10-19 [email protected] Roll Flutter Engine from 418dce4feaf7 to 9d49175618f5 (1 revision) (flutter/flutter#136901) 2023-10-19 [email protected] Unmark linux_android platform_channels_benchmarks as flaky (flutter/flutter#136838) 2023-10-19 [email protected] Roll Packages from 14aa69e to 09c6b11 (4 revisions) (flutter/flutter#136896) 2023-10-19 [email protected] Roll Flutter Engine from 28cb2508b8e0 to 418dce4feaf7 (2 revisions) (flutter/flutter#136895) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland #136751 with fixes.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.