Repository navigation
Reenable fade transition for Material page transition (#13048) - #13680
Conversation
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
(The commit in question has already been committed before, so I assume it's ok to commit again.) |
|
LG \o/ |
|
Well, this still caused a performance regression. Android-specific; it hurt average_frame_build_time_millis a little and average_frame_rasterizer_time_millis a lot. I'm going to condition this code on a constant so that it's easier to turn on and off, since some people are going to want it on regardless. |
Hopefully this will fix the performance regression in flutter#13680 but with an easier way to flip the switch.
Hopefully this will fix the performance regression in #13680 but with an easier way to flip the switch.
Hopefully this will fix the performance regression in flutter#13680 but with an easier way to flip the switch.
Fixes #12877 by reverting #9472.
Let's try this again, now that we've tried optimising Opacity.
This may get reverted it if affects the benchmarks badly again.