Skip to content

[CP][Android] Update Java/AGP/Gradle warning compatible Java range #136766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Oct 18, 2023
Merged

[CP][Android] Update Java/AGP/Gradle warning compatible Java range #136766

auto-submit merged 2 commits into from
Oct 18, 2023

Conversation

@camsim99
Copy link
Contributor

@camsim99 camsim99 commented Oct 17, 2023 •
edited
Loading

Cherry-pick for #136388.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@camsim99
[Android] Update Java/AGP/Gradle warning compatible Java range (flutt…
fd20eff 
…er#135710)

Specifies that compatible Java range stated in warning when Java version is incompatible with our template AGP & Gradle versions notes an exclusive upper bound Java version. This was a bug from flutter#131444, and I will file a CP request to stable once this lands.

The warning uses [`getJavaVersionFor`](https://github.com/flutter/flutter/blob/b5c8fd11e4906d900039584b4f67c9753327060c/packages/flutter_tools/lib/src/android/gradle_utils.dart#L606), which returns an exclusive upper bound, which is why this fix is necessary.
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 17, 2023
@camsim99 camsim99 mentioned this pull request Oct 17, 2023
Closed
@camsim99 camsim99 marked this pull request as ready for review October 17, 2023 22:12
@itsjustkevin itsjustkevin self-requested a review October 18, 2023 05:12
@itsjustkevin itsjustkevin added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 18, 2023
@auto-submit auto-submit bot merged commit f00b8f5 into flutter:flutter-3.16-candidate.0 Oct 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
f00b8f510 [CP][Android] Update Java/AGP/Gradle warning compatible Jav…
6e59696 
…a range (flutter/flutter#136766)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsjustkevin itsjustkevin itsjustkevin approved these changes

@reidbaker reidbaker Awaiting requested review from reidbaker

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camsim99 @itsjustkevin