[Reland] Skip injecting Bonjour settings when port publication is disabled #136751

vashworth · 2023-10-17T19:34:16Z

Reland of #136562 with fixes.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…blication

vashworth · 2023-10-17T19:43:19Z

dev/devicelab/lib/tasks/perf_tests.dart

             '-v',
            '--profile',
            '--target=$target',
+            if (deviceOperatingSystem == DeviceOperatingSystem.ios) '--no-publish-port',


Fixed Mac_benchmark platform_view_macos__start_up by limiting this to only be used for iOS.

Original PR failure: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_benchmark%20platform_view_macos__start_up/4413/overview

New PR passing: https://chromium-swarm.appspot.com/task?id=6557f6bd1e447a10

christopherfujino

LGTM

…command

vashworth · 2023-10-18T17:15:05Z

packages/flutter_tools/lib/src/commands/build_ios.dart

      deviceID: globals.deviceManager?.specifiedDeviceId,
+      disablePortPublication: usingCISystem &&
+          xcodeBuildAction == XcodeBuildAction.build &&
+          await disablePortPublication,


@christopherfujino I made an update to this, so it only checks disablePortPublication if the action is build (aka build ios). I did this because I didn't add the publish-port flag to the build ipa (archive) command, which also uses this function.

Original PR failure: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20ios_content_validation_test/13690/overview

New PR passing: https://chromium-swarm.appspot.com/task?id=655c94b693aaad10

…n is disabled (#136751)" This reverts commit 1599cbe.

…on is disabled" (#136839) Reverts #136751 Initiated by: vashworth This change reverts the following previous change: Original Description: Reland of #136562 with fixes.

…n is disabled (flutter/flutter#136751)

Manual roll Flutter from 6eea6e2 to 189196d (44 revisions) Manual roll requested by [email protected] flutter/flutter@6eea6e2...189196d 2023-10-18 [email protected] Roll Flutter Engine from ab86c53c19cd to 6caee3236d37 (2 revisions) (flutter/flutter#136834) 2023-10-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Reland] Skip injecting Bonjour settings when port publication is disabled" (flutter/flutter#136839) 2023-10-18 [email protected] Convert menus to use OverlayPortal (flutter/flutter#130534) 2023-10-18 [email protected] [Reland] Skip injecting Bonjour settings when port publication is disabled (flutter/flutter#136751) 2023-10-18 [email protected] Roll Flutter Engine from 0eff5d191856 to ab86c53c19cd (1 revision) (flutter/flutter#136832) 2023-10-18 [email protected] Fixes ability to call nextFocus() on a node to focus its descendant (flutter/flutter#136773) 2023-10-18 [email protected] Roll Flutter Engine from b778a07f8ae9 to 0eff5d191856 (6 revisions) (flutter/flutter#136829) 2023-10-18 [email protected] Implement GApplication:shutdown so a Flutter developer knows where to put code that should occur on application shutdown. (flutter/flutter#136780) 2023-10-18 [email protected] Roll Flutter Engine from 7f37c9b181af to b778a07f8ae9 (1 revision) (flutter/flutter#136818) 2023-10-18 [email protected] Fix `Slider` `onChanged` callback order & never calls `onChangeStart` on `SliderInteraction.slideOnly` allowed interaction (flutter/flutter#136720) 2023-10-18 [email protected] Roll Flutter Engine from 78026b4003fe to 7f37c9b181af (1 revision) (flutter/flutter#136817) 2023-10-18 [email protected] [Feat] Stroke color for Slider value indicator (flutter/flutter#135986) 2023-10-18 [email protected] Fixed : Empty Rows shown at last page in Paginated data table (flutter/flutter#132646) 2023-10-18 [email protected] Roll Flutter Engine from 46923fd39032 to 78026b4003fe (1 revision) (flutter/flutter#136814) 2023-10-18 [email protected] Roll Packages from d439062 to 14aa69e (1 revision) (flutter/flutter#136813) 2023-10-18 [email protected] Don't build native assets in `flutter build bundle` (flutter/flutter#136641) 2023-10-18 [email protected] Roll Flutter Engine from c9c9684e03a3 to 46923fd39032 (1 revision) (flutter/flutter#136795) 2023-10-18 [email protected] Roll Flutter Engine from 0c1c29271e8b to c9c9684e03a3 (1 revision) (flutter/flutter#136792) 2023-10-18 [email protected] Roll Flutter Engine from 1de09d13e708 to 0c1c29271e8b (3 revisions) (flutter/flutter#136789) 2023-10-18 [email protected] Roll Flutter Engine from 6fc36e61a99a to 1de09d13e708 (1 revision) (flutter/flutter#136785) 2023-10-18 [email protected] Roll Flutter Engine from 3f818efff3c5 to 6fc36e61a99a (1 revision) (flutter/flutter#136781) 2023-10-18 [email protected] Roll Flutter Engine from 2eef9b43cfb4 to 3f818efff3c5 (3 revisions) (flutter/flutter#136777) 2023-10-18 [email protected] Roll Flutter Engine from 5df7af34a718 to 2eef9b43cfb4 (4 revisions) (flutter/flutter#136774) 2023-10-18 [email protected] Flutter preview device (flutter/flutter#135639) 2023-10-18 [email protected] Add findChildIndexCallback examples (flutter/flutter#133469) 2023-10-18 [email protected] Adds API for performing semantics actions in tests (flutter/flutter#132598) 2023-10-18 [email protected] Roll Flutter Engine from e57b5bac4244 to 5df7af34a718 (2 revisions) (flutter/flutter#136772) 2023-10-17 [email protected] Roll Flutter Engine from f9f937e51080 to e57b5bac4244 (3 revisions) (flutter/flutter#136768) 2023-10-17 [email protected] clean up `--dart-define-from-file` option tests (flutter/flutter#135980) 2023-10-17 [email protected] GoldenFileComparators should dispose created Image objects. (flutter/flutter#136716) 2023-10-17 [email protected] make integration_test_driver_extended.dart support writeResponseData--(done) (flutter/flutter#128382) 2023-10-17 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.6.0 to 4.1.1 (flutter/flutter#136762) 2023-10-17 [email protected] Roll Flutter Engine from 289f29b1ad00 to f9f937e51080 (1 revision) (flutter/flutter#136755) 2023-10-17 [email protected] Roll Flutter Engine from 659e68a097b5 to 289f29b1ad00 (1 revision) (flutter/flutter#136752) 2023-10-17 [email protected] Support --web-header option for flutter run (flutter/flutter#136297) 2023-10-17 [email protected] Add Android 14 physical devices to firebase tests (flutter/flutter#136736) 2023-10-17 [email protected] Roll Flutter Engine from 62a90a91cee3 to 659e68a097b5 (3 revisions) (flutter/flutter#136746) 2023-10-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Skip injecting Bonjour settings when port publication is disabled" (flutter/flutter#136750) 2023-10-17 [email protected] Revert "[SingleChildScrollView] Correct the offset pixels if it is out of range during layout" (flutter/flutter#136744) 2023-10-17 [email protected] Skip injecting Bonjour settings when port publication is disabled (flutter/flutter#136562) 2023-10-17 [email protected] Roll Flutter Engine from 3ecbe924a598 to 62a90a91cee3 (2 revisions) (flutter/flutter#136739) 2023-10-17 [email protected] Roll Flutter Engine from 0a4d8b99a95b to 3ecbe924a598 (3 revisions) (flutter/flutter#136732) 2023-10-17 [email protected] Reenable NexusLowRes API 29 (flutter/flutter#136686) 2023-10-17 [email protected] Reenable the nexus 6p tests (flutter/flutter#136689) ...

…abled (#136842) Reland #136751 with fixes.

vashworth and others added 7 commits October 13, 2023 16:31

Skip injecting Bonjour settings when port publication is disabled

270e29b

some formatting, add another test

32c6a76

fix arg flag, temporarily run some test in presubmit

f9d3b98

Merge branch 'master' into skip_bonjour_settings_for_disabled_port_pu…

7fdce76

…blication

reset ci.yaml

dae7787

remove unneeded null check

f5f5222

only use no-publish-port for iOS builds

6b96553

github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Oct 17, 2023

vashworth commented Oct 17, 2023

View reviewed changes

vashworth changed the title ~~Skip bonjour settings for disabled port publication~~ [Reland] Skip injecting Bonjour settings when port publication is disabled Oct 17, 2023

vashworth requested a review from christopherfujino October 17, 2023 21:14

christopherfujino approved these changes Oct 17, 2023

View reviewed changes

only use publish-port flag with build ios command, exclude build ipa …

2b516ee

…command

vashworth commented Oct 18, 2023

View reviewed changes

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 18, 2023

auto-submit bot merged commit 1599cbe into flutter:master Oct 18, 2023

vashworth added the revert Autorevert PR (with "Reason for revert:" comment) label Oct 18, 2023

auto-submit bot mentioned this pull request Oct 18, 2023

Reverts "[Reland] Skip injecting Bonjour settings when port publication is disabled" #136839

Merged

8 tasks

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Oct 18, 2023

auto-submit bot pushed a commit that referenced this pull request Oct 18, 2023

Revert "[Reland] Skip injecting Bonjour settings when port publicatio…

cc94623

…n is disabled (#136751)" This reverts commit 1599cbe.

vashworth mentioned this pull request Oct 18, 2023

[Reland] Skip injecting Bonjour settings when port publication is disabled #136842

Merged

8 tasks

engine-flutter-autoroll mentioned this pull request Oct 18, 2023

Manual roll Flutter from 6eea6e277e56 to 189196d104e2 (44 revisions) flutter/packages#5178

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 18, 2023

1599cbe [Reland] Skip injecting Bonjour settings when port publicatio…

0c08147

…n is disabled (flutter/flutter#136751)

auto-submit bot pushed a commit that referenced this pull request Oct 19, 2023

[Reland] Skip injecting Bonjour settings when port publication is dis…

3c3d414

…abled (#136842) Reland #136751 with fixes.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Reland] Skip injecting Bonjour settings when port publication is disabled #136751

[Reland] Skip injecting Bonjour settings when port publication is disabled #136751

Uh oh!

vashworth commented Oct 17, 2023

Uh oh!

vashworth Oct 17, 2023

Uh oh!

christopherfujino left a comment

Uh oh!

vashworth Oct 18, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[Reland] Skip injecting Bonjour settings when port publication is disabled #136751

[Reland] Skip injecting Bonjour settings when port publication is disabled #136751

Uh oh!

Conversation

vashworth commented Oct 17, 2023

Pre-launch Checklist

Uh oh!

vashworth Oct 17, 2023

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

vashworth Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vashworth Oct 18, 2023 •

edited

Loading