Skip to content

Test cover painting for memory leaks #136696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 4 commits into from
Oct 21, 2023
Merged

Test cover painting for memory leaks #136696

polina-c merged 4 commits into from
Oct 21, 2023

Conversation

@droidbg
Copy link
Contributor

@droidbg droidbg commented Oct 17, 2023 •
edited
Loading

Description

As a part of Issue: #134 this PR includes coverage for test/painting/ by changing testWidgets to testWidgetsWithLeakTracking .

Tests

  • Updates decoration_image_lerp_test.dart to use testWidgetsWithLeakTracking.
  • Updates gradient_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 17, 2023
@droidbg droidbg mentioned this pull request Oct 17, 2023
Closed
@Piinks Piinks requested a review from polina-c October 17, 2023 22:24
Piinks
Piinks reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @droidbg it looks like there are some failing tests, can you take a look?

Also, I think @polina-c has an issue that is keeping track of all of these tests, this should sync up with that issue.

@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Oct 17, 2023
@polina-c
Copy link
Contributor

polina-c commented Oct 17, 2023 •
edited
Loading

Hey @droidbg it looks like there are some failing tests, can you take a look?

Also, I think @polina-c has an issue that is keeping track of all of these tests, this should sync up with that issue.

Thanks. Added label for tracking.

@droidbg droidbg marked this pull request as ready for review October 21, 2023 02:33
@droidbg
Copy link
Contributor Author

droidbg commented Oct 21, 2023

Hello @Piinks @polina-c , Thanks I have fixed the TCs. Could you please review it.

@polina-c polina-c merged commit 2ec771a into flutter:master Oct 21, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 21, 2023
@engine-flutter-autoroll
2ec771a Test cover painting for memory leaks (flutter/flutter#136696)
4ee44f2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 21, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 21, 2023
@engine-flutter-autoroll
2ec771a Test cover painting for memory leaks (flutter/flutter#136696)
0c5df60
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 21, 2023
@engine-flutter-autoroll
Roll Flutter from 0883cb2 to 6f4850d (24 revisions) (#5196)
69b166b 
flutter/flutter@0883cb2...6f4850d

2023-10-21 [email protected] Roll Flutter Engine from a12116df3859 to 11f87dce1017 (1 revision) (flutter/flutter#137017)
2023-10-21 [email protected] Roll Flutter Engine from 755c477c96e7 to a12116df3859 (1 revision) (flutter/flutter#137013)
2023-10-21 [email protected] Roll Flutter Engine from 4f9f4013c3b3 to 755c477c96e7 (1 revision) (flutter/flutter#137008)
2023-10-21 [email protected] Test cover painting for memory leaks (flutter/flutter#136696)
2023-10-21 [email protected] Roll Flutter Engine from 2e5fb647a76f to 4f9f4013c3b3 (2 revisions) (flutter/flutter#136999)
2023-10-21 [email protected] Roll Flutter Engine from e4fc0c4e2b97 to 2e5fb647a76f (3 revisions) (flutter/flutter#136995)
2023-10-21 [email protected] Roll Flutter Engine from 9796817fb6e2 to e4fc0c4e2b97 (1 revision) (flutter/flutter#136993)
2023-10-20 [email protected] Roll Flutter Engine from 4a65910f0ab2 to 9796817fb6e2 (2 revisions) (flutter/flutter#136990)
2023-10-20 [email protected] Adds more a11y use cases (flutter/flutter#136761)
2023-10-20 [email protected] Reland "Use Layer.toImage for golden tests on CanvasKit" (flutter/flutter#136918)
2023-10-20 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.3 to 2.22.4 (flutter/flutter#136985)
2023-10-20 [email protected] Add missing call to parent method of GApplication::shutdown, implement GApplication::startup (flutter/flutter#136836)
2023-10-20 [email protected] Roll Flutter Engine from b27e1b38375b to 4a65910f0ab2 (5 revisions) (flutter/flutter#136987)
2023-10-20 [email protected] Bump dartdoc to 7.0.1 and clean-up (flutter/flutter#136975)
2023-10-20 [email protected] RenderEditable WidgetSpan intrinsics (flutter/flutter#136979)
2023-10-20 [email protected] Roll Flutter Engine from d46933e6772e to b27e1b38375b (9 revisions) (flutter/flutter#136982)
2023-10-20 [email protected] Roll pub packages (flutter/flutter#136924)
2023-10-20 [email protected] [docs] Expand categories for automated release notes (flutter/flutter#136967)
2023-10-20 [email protected] Roll Flutter Engine from 21b5c3771ee1 to d46933e6772e (3 revisions) (flutter/flutter#136973)
2023-10-20 [email protected] [Impeller] add OpenGL GPU tracing to devicelab tests. (flutter/flutter#136974)
2023-10-20 [email protected] Roll Flutter Engine from f9d1dbc39f4c to 21b5c3771ee1 (1 revision) (flutter/flutter#136969)
2023-10-20 [email protected] Default `NativeAssets` Darwin and IOS target archs if missing (flutter/flutter#136948)
2023-10-20 [email protected] Roll Flutter Engine from 6d1e9eec0841 to f9d1dbc39f4c (1 revision) (flutter/flutter#136966)
2023-10-20 [email protected] Roll Flutter Engine from 9b88ff83fd82 to 6d1e9eec0841 (2 revisions) (flutter/flutter#136965)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@droidbg droidbg deleted the painting_image_leak branch November 13, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks left review comments

@polina-c polina-c polina-c approved these changes

Assignees

No one assigned

Labels

a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@droidbg @polina-c @Piinks